Bug 120408 - Dotted Calc borders appear wrong after upgrade to LibreOffice 6.0
Summary: Dotted Calc borders appear wrong after upgrade to LibreOffice 6.0
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard: target:6.2.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2018-10-08 11:15 UTC by johnmcfarlane01
Modified: 2018-10-29 16:33 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
my typical spreadsheet file (106.20 KB, application/vnd.oasis.opendocument.spreadsheet)
2018-10-19 09:13 UTC, johnmcfarlane01
Details

Note You need to log in before you can comment on or make changes to this bug.
Description johnmcfarlane01 2018-10-08 11:15:15 UTC
Description:
Libre Office Calc.  My file Cell outlines have changed to solid or broken lines randomly throughout the document.

Actual Results:
.

Expected Results:
.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Roman Kuznetsov 2018-10-08 12:09:20 UTC Comment hidden (obsolete)
Comment 2 johnmcfarlane01 2018-10-11 16:10:52 UTC
Sorry unable to take screenshot.  Have also tried version 6.1.2.1 and cell outlines again have changed from dotted outjine to random broken and solid lines.  Have now reverted back to version 5.4.7.2 which works fine as have all other previous versions.
Comment 3 johnmcfarlane01 2018-10-19 09:13:55 UTC
Created attachment 145823 [details]
my typical spreadsheet file
Comment 4 johnmcfarlane01 2018-10-20 14:19:25 UTC
I have found that if Zoom is increased from 100% to 200% and above the border outlines appear to display correctly (ie grid of small dotted lines) but document then too large for screen
Comment 5 johnmcfarlane01 2018-10-20 17:51:21 UTC Comment hidden (obsolete)
Comment 6 johnmcfarlane01 2018-10-25 16:40:50 UTC Comment hidden (obsolete)
Comment 7 johnmcfarlane01 2018-10-25 16:42:49 UTC Comment hidden (obsolete)
Comment 8 Aron Budea 2018-10-25 18:51:03 UTC
I can repro this with my latest state of the 6.2 linux bibisect repo (49c87270f7176312806d1759967c247a312f0acf) / Ubuntu 18.04.

It seems to be fine in a fresh master build (313392119522c21a6ecd14403d6f92c948149df7), though.

I'll confirm this, technically it could be set to RESOLVED WORKSFORME, but wait until someone else can repro both the bug and that it's gone now, and in that case a reverse bibisect is in order.
Comment 9 Aron Budea 2018-10-26 01:03:45 UTC
Still looks buggy in bibisect-win32-6.2's latest build (b6b31bbb1a9e2272ac77de127825c4ee9f71effa) / Windows 7.
Comment 10 Timur 2018-10-26 08:00:09 UTC
Interesting that dotted borders look fine in LO 5.4.7.2 and wrong in Lo 6.0.
Which is not consistent with behavior from Bug 77369. 
But it's only a preview with 100% zoom, larger zoom is better, print and export are fine. 
This is probably a duplicate.
Comment 11 Xisco Faulí 2018-10-26 09:24:03 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=f65cbae8947c0462b35c8d3c3d5124e431b100b6

author	Armin Le Grand <Armin.Le.Grand@cib.de>	2017-07-04 16:28:58 +0200
committer	Armin Le Grand <Armin.Le.Grand@cib.de>	2017-07-12 21:01:20 +0200
commit f65cbae8947c0462b35c8d3c3d5124e431b100b6 (patch)
tree e8248f034f7a97e1716f9477937b55ae31038a76
parent fc55711f01af172eb3a034454405fa941454c781 (diff)
borderline: correct problems with border display

Bisected with: bibisect-linux64-6.0

Adding Cc: to Armin Le Grand
Comment 12 Aron Budea 2018-10-26 11:41:32 UTC
The issue has been fixed, the fix is in the following range, reverse bibisected using repo lo-linux-dbgutil-daily:
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=8e8d89b27167a524d7e591d00e5d1ed20288c964..28cc9746a9639ac14d3f6816b7fbf59cacbb42f4

Possibly by this exact commit (confirmation needed):
https://cgit.freedesktop.org/libreoffice/core/commit/?id=313392119522c21a6ecd14403d6f92c948149df7
author		Armin Le Grand <Armin.Le.Grand@cib.de>	2018-10-25 10:06:05 +0200
committer	Armin Le Grand <Armin.Le.Grand@cib.de>	2018-10-25 12:43:55 +0200

"Reorganize FrameBorderPrimitive creation (II)"

If that's the case, Armin, could this fix be backported, or is the backport too complicated/dangerous?
Comment 13 Aron Budea 2018-10-26 14:11:09 UTC
Verified that the commit mentioned above fixed the bug.
Comment 14 johnmcfarlane01 2018-10-28 11:37:45 UTC
(In reply to Aron Budea from comment #13)
> Verified that the commit mentioned above fixed the bug.

My typical spreadsheet attachment looks much better but still dark and a heavier dotted line compared with finer lighter dotted display in 5.4.7.2
Comment 15 Xisco Faulí 2018-10-29 16:33:27 UTC
Verified in

Version: 6.2.0.0.alpha1+
Build ID: 19a0698079fbba36646a2d06eaec3a7fde60b2f5
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: threaded

@Armin Le Grand, Thanks for fixing this!!


> If that's the case, Armin, could this fix be backported, or is the backport
> too complicated/dangerous?

What do you think about Aron's comment ?
Comment 16 Xisco Faulí 2018-10-29 16:33:58 UTC
(In reply to johnmcfarlane01 from comment #14)
> (In reply to Aron Budea from comment #13)
> > Verified that the commit mentioned above fixed the bug.
> 
> My typical spreadsheet attachment looks much better but still dark and a
> heavier dotted line compared with finer lighter dotted display in 5.4.7.2

Could you please report it in a different issue? The main problem of this issue is indeed fixed!