Created attachment 145479 [details] Screenshot: comparison of different filetypes' icon sizes 1. Insert→Object→OLE Object... 2. Choose "Create from file", check "Display as icon" ("Link to file" status doesn't matter) 3. Select an ODS document, or an ODT document, then OK. 4. Repeat steps 1-2; select an DOC(X) or XLS(X) document, OK. The icon added to the document on step 3 will be smaller than that is added on step 5 (see the screenshot). They should be equal. I suppose that there is possibly some difference in available icon sizes in respective icon resources; since all these icons are LibreOffice-provided (they have LO logo, and don't depend upon OS or if MS Office is also installed on the box), this should be LibreOffice problem. Tested with Version: 6.1.2.1 (x64) Build ID: 65905a128db06ba48db947242809d14d3f9a93fe CPU threads: 12; OS: Windows 10.0; UI render: GL; Locale: ru-RU (ru_RU); Calc: CL and also with Version: 6.1.2.1 Build ID: 1:6.1.2~rc1-0ubuntu0.18.04.1 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); Calc:
Repro with Colibre, but not with Tango. Got a crash with master, have to check it tomorrow. Arch Linux 64-bit Version: 6.1.2.1 Build ID: 6.1.2-1 CPU threads: 8; OS: Linux 4.18; UI render: default; VCL: gtk3_kde5; Locale: fi-FI (fi_FI.UTF-8); Calc: group threaded
Dear Mike Kaganski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Still repro with Version: 6.4.0.0.alpha1+ (x64) Build ID: c0b8be4d7eb9fa1a0d8abfb1d27c71ac34bffd1b CPU threads: 12; OS: Windows 10.0 Build 18362; UI render: GL; VCL: win; Locale: ru-RU (ru_RU); UI-Language: en-US Calc: CL
Reproducible with Colibre Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 2816f498505bab01bc0f17ef0962ece663c607c9 CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: id-ID (id_ID.UTF-8); UI: en-US Calc: threaded Any design part which should be updated?
(In reply to Rizal Muttaqin from comment #4) Could you please tell which specific icons (filenames) are those? And what is different wrt those filenames compared to Tango (comment 0)?
(In reply to Mike Kaganski from comment #5) > (In reply to Rizal Muttaqin from comment #4) > > Could you please tell which specific icons (filenames) are those? And what > is different wrt those filenames compared to Tango (comment 0)? Just tried Galaxy and the issue is reproducible also. I guess some icons that being used from Galaxy reference: - ODT: res/lx03251.png (26px) - ODS: res/lx03250.png (26px) - XLSX: res/lx03188.png or res/lx03126.png (?) (32px) - DOCX: res/lx03162.png or res/lx03156.png (?) (32px) Here come the confusion. Does lx* files are supposed to be 24px (Galaxy use 26px instead of 24px in their large size variants) or 32px? This is my long question actually
(In reply to Mike Kaganski from comment #5) > (In reply to Rizal Muttaqin from comment #4) > > Could you please tell which specific icons (filenames) are those? And what > is different wrt those filenames compared to Tango (comment 0)? For Tango - ODT: res/lx03251.png (24px) - ODS: res/lx03250.png (24px) - XLSX: res/lx03126.png (24px) which has same exact appearance with res/lx03127.png. But from Galaxy reference, I can say lx03126.png is the file - DOCX: res/lx03162.png (24px)
(In reply to Rizal Muttaqin from comment #6) > Does lx* files are supposed to be 24px (Galaxy use 26px instead of 24px in > their large size variants) or 32px? This is my long question actually https://opengrok.libreoffice.org/xref/core/svtools/source/misc/imagemgr.cxx?r=60eaa424#505 (and its respective BMP_* constants defined in https://opengrok.libreoffice.org/xref/core/svtools/inc/bitmaps.hlst?r=60eaa424) suggests that lx are 24/26 pixels (and the 24/26 is documented at https://opengrok.libreoffice.org/xref/core/include/vcl/vclenum.hxx?r=2f4f4cbe&fi=Size26#320).
(In reply to Mike Kaganski from comment #8) > https://opengrok.libreoffice.org/xref/core/include/vcl/vclenum. > hxx?r=2f4f4cbe&fi=Size26#320). Likely 26px should be updated as now all icon themes are using 24px instead. But it's another topic.
(Back in 2019, I wrote in commit bea44e5c1b982d05314b72452b94fe288071a496 that the canonical size should be 24 × 24. It’s a logical value that has precedence in Linux icon themes, and I’ve never known why Sun decided on a seemingly random value of 26 pixels.)
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/95e85730ad850a66879a639d9f5936fa67549ab7 Colibre: tdf#120425 equalize icon dimensions It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 179220 [details] Object inserted in WPS Office use huge icons Just curious, do we need too enlarge the icon? The 24px for me is too tiny for a OLE OBJECT document icon inserted?
Created attachment 179221 [details] Image inserted as OLE in Galaxy use 32px (In reply to Rizal Muttaqin from comment #12) > Just curious, do we need too enlarge the icon? The 24px for me is too tiny > for a OLE OBJECT document icon inserted? Galaxy as the main fallback in the past use 32px (lx03125.png) for inserted OLE Object image type. This size more suitable for me, not too large nor too tiny. But how we deal with lx* file? Mike you said that the file is supposed to be 24 px? So why some of res/lx* Galaxy icons are 32px? I think we should have an agreement here - What are proper/the best icon dimension size for the embedded OLE Object file? - Do all lx* files have to be 24px? If there is a 32px size, do we need to define it in the coding section, for example an xlx* image with a size of 32px.
(In reply to Rizal Muttaqin from comment #13) This is not related to this bug. If needed, please file another one. Specifically, the icons that you fixed, you fixed *correctly* to 24px. Your question is related to "do we want to use *these* icons for inserted objects, or should we use lxNNN_32 variants instead?".