Bug 120429 - Functions “Insert Columns Left” and “Insert Rows Above” Exist Two Times in Customize Dialogue
Summary: Functions “Insert Columns Left” and “Insert Rows Above” Exist Two Times in Cu...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.1.2.1 release
Hardware: All Windows (All)
: medium normal
Assignee: Heiko Tietze
URL:
Whiteboard: target:6.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-08 17:28 UTC by Harald Koester
Modified: 2019-04-09 09:36 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Koester 2018-10-08 17:28:02 UTC
In order to reproduce the bug:

[1] Open new spreadsheet.
[2] Open Customize Dialogue and select tab Menus.
[3] In “Target” select “Sheet”.
[4] In “Function” (left side) scroll down to “Insert Columns left”. This item exists 2 times. Expected: Only one item.
[5] Add both functions to “Function” (right side).
[6] In “Function” (left) scroll down to “Insert Rows Above” This item also exists 2 times. Expected: Only one item.
[7] Add both functions to “Function” (rigtht).
[8] Close Customize dialogue with OK.
[9] Fill cells A1 to B2 with some text.
[10] Save but don't close spreadsheet.
[11] Change to read-only mode: Edit > Edit Mode.
[12] Select second row.
[13] Open menu “Sheet”. The items “Rows Above” is displayed twice. One of them is greyed and one is not greyed. This means that the function of both items is different. Also expected, that both items “Rows Above” are greyed because document is in read-only mode.
[14] Click the non-greyed item. A row is inserted. Expected: No insertion because document is in read-only mode.
[15] You can repeat the steps 12 to 14 with a column instead of a row. The result is equivalent.
Comment 1 V Stuart Foote 2018-10-08 18:34:15 UTC
Confirmed.

Looking in CalcCommands.xcu a collision of uno:InsertRows and uno:InsertRowsBefore; and uno:InsertColumns and uno:InsertColumnsBefore

Not sure if the issue for the duplicated UNO controls remains and can now be removed, but the duplication was intentional at the time. 

=-ref-=
https://gerrit.libreoffice.org/#/c/16099/
Comment 2 Heiko Tietze 2018-10-09 07:19:56 UTC
Looks like we can easily remove the legacy commands https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/cellsh1.cxx#219 (and #225) 

Patch is here https://gerrit.libreoffice.org/#/c/61567/
Comment 3 Commit Notification 2018-10-15 10:25:24 UTC
heiko tietze committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7f5fd9d9ebffa692ba670f01f8f833657bb7745f

tdf#120429 - Functions Insert Columns Exist Two Times

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Harald Koester 2019-04-09 09:36:52 UTC
Checked with version 6.2.2 (64 bit, Win10). In customize dialogue all insert functions (rows and columns) only exist once. In read-only mode all insert functions (rows and columns) are greyed and insertion of rows and columns is no longer possible. Hence works now as expected.

Thanks for fixing.