Bug 120473 - SIDEBAR: Proposal for panel tab navigation behavior change
Summary: SIDEBAR: Proposal for panel tab navigation behavior change
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Jim Raykowski
URL:
Whiteboard: target:6.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-10 03:27 UTC by Jim Raykowski
Modified: 2018-11-10 04:06 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Raykowski 2018-10-10 03:27:06 UTC
There is an inconsistency between the way tab navigation behaves before and after a panel title bar gets focus.

To reproduce this in Writer:

1) Open sidebar Menu->View->Sidebar
2) click on Page tab in sidebar tab bar
3) click on Number combobox in Styles panel (must be direct click on combobox, no click on Styles title to expand panel)
4) press tab key to tab through each item in the panel content until returning to the Number combobox
5) press shift+tab key to reverse tab through each item

Notice tab cycle does not enter panel title tab bar.

6) click on Styles title or press Escape key (focus is now on Styles title)
7) press tab key (focus is now on Styles panel title bar tool box)
8) press tab key (focus is now in panel content Number combobox)
9) press tab key until focus is on Columns combobox
10) press tab key

Notice focus returns to Styles title.

So far this doesn't seem bad but it isn't consistent.

Even less consistent/expectant is when shift+tab is used to move through panel content after panel title bar gets focus.

11) click on Styles title
12) press shift+tab key (focus moves to Number combobox, user may expect focus to move to Columns combobox)
13) press shift+tab key (focus moves to Columns combobox)
14) press shift+tab key (focus moves to Layout combobox, expected)
15) press shift+tab key (focus moves to Background combobox, expected)
16) press shift+tab key (focus moves to Styles panel title, jumps over the first combobox in panel and over panel tool box)

I would like to propose that after entering a panel content in any way, tab navigation behaves as in steps 4 and 5 and panel title tab bar is not included in tab stops. To move focus to the panel title bar use the Escape key or mouse click on the panel title bar.
Comment 1 Heiko Tietze 2018-10-15 09:48:47 UTC
(In reply to Jim Raykowski from comment #0)
> 1) Open sidebar Menu->View->Sidebar
> ...
> 4) press tab key to tab through each item in the panel content until returning to the Number combobox
> 5) press shift+tab key to reverse tab through each item
> 
> Notice tab cycle does not enter panel title tab bar.

Yes, that violates the guideline https://wiki.documentfoundation.org/Design/SideBar

> 6) click on Styles title or press Escape key (focus is now on Styles title)
> ...
> 10) press tab key
> 
> Notice focus returns to Styles title.

Weird behavior.

> So far this doesn't seem bad but it isn't consistent.
> 
> Even less consistent/expectant is when shift+tab is used to move through
> panel content after panel title bar gets focus.
> ...

Totally wrong, true.

> I would like to propose that after entering a panel content in any way, tab
> navigation behaves as in steps 4 and 5 and panel title tab bar is not
> included in tab stops. To move focus to the panel title bar use the Escape
> key or mouse click on the panel title bar.

We have clearly stated in the HIG that

| 5) Use Escape to go back one step in the navigation, meaning from the content to the content panel title and then to the document.

So yes, your request is valid.
Comment 2 Jim Raykowski 2018-10-18 18:22:16 UTC
Here is a patch for review/testing:
https://gerrit.libreoffice.org/#/c/61949/
Comment 3 Commit Notification 2018-11-05 07:48:27 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/cd086621e3d4fd4b90fabe0b20c0ae4602447d8a%5E%21

tdf#120473 Change sidebar panel content tab navigation behavior

It will be available in 6.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.