Description: Delete all comments leaves a comment box behind (and will end in crash) Steps to Reproduce: 1. Open the attached file 2. Click bottom comment box arrow & delete all comments 3. Comment box stays behind. 4. Enter the remain textbox and press CUT -> Crash (there a more scenarios which will end in crash) Actual Results: Crash Expected Results: No crash Reproducible: Always User Profile Reset: No Additional Info: Version: 6.2.0.0.alpha0+ Build ID: 87e3539d69626780c6d7531b725dd0d64c69e6d8 CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-10-10_06:50:13 Locale: nl-NL (nl_NL); Calc: CL
Created attachment 145573 [details] Example file
I can reproduce it in Version: 6.2.0.0.alpha0+ Build ID: 87e3539d69626780c6d7531b725dd0d64c69e6d8 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; Locale: ca-ES (ca_ES.UTF-8); Calc: threaded and Versión: 6.1.2.1 Id. de compilación: 65905a128db06ba48db947242809d14d3f9a93fe Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; Configuración regional: es-ES (es_ES); Calc: group threaded
Regression introduced by: author Caolán McNamara <caolanm@redhat.com> 2018-08-07 13:44:17 +0100 committer Caolán McNamara <caolanm@redhat.com> 2018-08-07 17:18:01 +0200 commit b8a83417ed080b4c63b797d3f6837c49cdbdd2a2 (patch) tree 73d5b34fd4c6d837e8e6d75eebacb6dea478a3e8 parent 0dced3431fd7ef664d55d73ac9b1ec76d28c51fd (diff) tdf#119130 only have the active postit as a dialog control... Bisected with: bibisect-linux64-6.2 Adding Cc: to Caolán McNamara
I can't reproduce it in gtk3, only gtk or gen
Created attachment 145577 [details] screencast
Created attachment 145581 [details] bt from assert with debug symbols (gtk) On pc Debian x86-64 with master sources updated today, I got an assert when trying to delete all comments.
Created attachment 145582 [details] bt with debug symbols (gen) On pc Debian x86-64 with master sources updated today, I could reproduce the pb with gen rendering. There's a remnant comment after having clicked "Delete all comments" and when clicking on button on it, it crashed.
looks like a tricky focus problem, disposing the window causes the focus to move to another window, and eventually triggers recreating missing comment boxes because the comment is still in the list of comments, because its removed after the dispose completes
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=759dcc107cb7740ec4242634a19631d9ed70cb0f Resolves: tdf#120487 postit losing focus triggering recreation of postit It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
backport to 6-1 in gerrit
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f1e09253316d9db39b7adab6d31e759c09de3406&h=libreoffice-6-1 Resolves: tdf#120487 postit losing focus triggering recreation of postit It will be available in 6.1.4. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in Version: 6.2.0.0.alpha0+ Build ID: 49c87270f7176312806d1759967c247a312f0acf CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; Locale: ca-ES (ca_ES.UTF-8); Calc: threaded @Caolán, Thanks for fixing this!
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-1-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a4257d576cb77753979aae14a9c1751d14d6e375&h=libreoffice-6-1-3 Resolves: tdf#120487 postit losing focus triggering recreation of postit It will be available in 6.1.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Simplify targets