When we try to use a persona by directly giving its URL, it gives an error if the persona doesn't have the accentcolor info set.
And when searching, it doesn't bring the personas which don't have the accentcolor.
In fact, accentcolor is not used anywhere, in LibreOffice currently. And we should allow such personas.
I propose we stop parsing and storing that info.
Could you please explain what accent color means? Maybe we can set missing information automatically or per default.
(In reply to Heiko Tietze from comment #1)
> Could you please explain what accent color means? Maybe we can set missing
> information automatically or per default.
No idea. It is just a color value we parse from Persona info and store, but never use.
An example for a persona which doesn't have the accentcolor: https://addons.mozilla.org/en-US/firefox/addon/libreoffice-4-green
So why not silently catch the error?
(In reply to Heiko Tietze from comment #3)
> So why not silently catch the error?
That's what we are currently doing, and it is a source of unnecessary noise & code clutter, and waste of cycles.
Parsing/processing/storing something useless to us doesn't make sense to me. It is probably some leftover, forgotten there.
And if you are asking me what it is (c#2), then that means it is already dead. :)
(In reply to Muhammet Kara from comment #4)
> And if you are asking me what it is (c#2), then that means it is already
> dead. :)
Kill the zombies.
(In reply to Heiko Tietze from comment #5)
> (In reply to Muhammet Kara from comment #4)
> > And if you are asking me what it is (c#2), then that means it is already
> > dead. :)
> Kill the zombies.
One homemade flamethrower is coming up for htietze: https://gerrit.libreoffice.org/#/c/61668/
Muhammet Kara committed a patch related to this issue.
It has been pushed to "master":
tdf#120506: Get rid of unnecessary accentcolor parsing for personas
It will be available in 6.2.0.
The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.
Thank you for reporting, fixing and adding me in CC.
Can this fix be cherry picked to branch 6.1?
(In reply to Pedro from comment #8)
> Hi Muhammet
> Thank you for reporting, fixing and adding me in CC.
> Can this fix be cherry picked to branch 6.1?
(In reply to Muhammet Kara from comment #9)
> (In reply to Pedro from comment #8)
> > Can this fix be cherry picked to branch 6.1?
> Unfortunately, no.
Thank you for the fast answer!
Ok, I'll test it when 6.2 is released! Thanks!