Bug 120563 - Improve the preview of numbering with relative size
Summary: Improve the preview of numbering with relative size
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Réka Csékei
URL:
Whiteboard: target:6.3.0
Keywords: difficultyBeginner, easyHack, skillCpp, topicUI
Depends on:
Blocks:
 
Reported: 2018-10-13 12:28 UTC by Tamás Zolnai
Modified: 2019-01-28 15:24 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Screenshot of the worng preview of relative size (12.36 KB, image/png)
2018-10-13 12:29 UTC, Tamás Zolnai 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tamás Zolnai 2018-10-13 12:28:09 UTC 
Description:
In Impress we can specify a relative size for bullets and numbering. The effect of this relative size value is shown on the preview when we use a bulleting character, but it has no effect when we use numbering (e.g. 1., 2., etc). The preview I'm speaking about is on the Bullets and Numbering dialog, Position and Customize tab page.
It would be a good enhanchement to make the preview show the result of changing the relative size, also for numberings. Since bullet symbol is also a text as the numbering character, it must be easy to reuse the same code.

Steps to Reproduce:
1. Open Impress
2. Open Bullets and Numbering dialog (select a text, right click, Bullets and Numbering)
3. Move to Customize tab page
4. Select "Number:" field to be an actual numbering (e.g. 1, 2, 3, ...)
5. Change relative size field's value

Actual Results:
The preview does show the set relative size.

Expected Results:
The preview should show the set relative size.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Tamás Zolnai 2018-10-13 12:29:57 UTC 
Created attachment 145674 [details]
Screenshot of the worng preview of relative size

On the preview the numbering is rendered as 100% size, even if we set it to 25%.
Comment 2 Tamás Zolnai 2018-10-13 12:31:50 UTC 
Let's turn it into a easy hack. The code is here:
cui/source/tabpages/numpages.cxx
Check SvxNumberingPreview::Paint method.
Comment 3 Xisco Faulí 2018-11-16 03:40:22 UTC Comment hidden (obsolete)
Comment 4 Commit Notification 2018-11-20 13:49:55 UTC 
Réka Csékei committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/4610388a6cccf45c232bcdfb67d45c0443058b9f%5E%21

tdf#120563 Improve the preview of numbering with relative size

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2018-12-21 03:49:36 UTC Comment hidden (obsolete)
Comment 6 Xisco Faulí 2019-01-21 03:38:11 UTC Comment hidden (obsolete)
Comment 7 Tamás Zolnai 2019-01-23 17:35:08 UTC 
The main use case is fixed, so close this bug. Thanks for the contribution.
Comment 8 BogdanB 2019-01-28 15:24:17 UTC 
Works as expected. The preview reflects the changeing procent.

Version: 6.3.0.0.alpha0+
Build ID: 9bc10964f0673b64e282ad567d08bf7ebba4df65
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-01-27_18:08:30
Locale: ro-RO (ro_RO.UTF-8); UI-Language: en-US
Calc: threaded