Bug 120801 - The background color is active when inserting a header using Insert Header/Footer - Header default style.
Summary: The background color is active when inserting a header using Insert Header/Fo...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.4 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Writer-Header-Footer Area-Fill-Tab
  Show dependency treegraph
 
Reported: 2018-10-22 16:36 UTC by Telesto
Modified: 2019-05-11 14:01 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2018-10-22 16:36:49 UTC
Description:
The background color is active when inserting a header using Insert Header/Footer - Header default style. 

Steps to Reproduce:
1. Open Writer
2. Insert -> Header/Footer -> Header -> Default style
3. Format -> Page -> Header tab
4. Click More -> Area tab -> Color tab will be active
5. Press OK, OK -> Header will be blue

Color tab should be set to none.

Actual Results:
Color is enabled

Expected Results:
No color. Same as when insert a header from: Format -> Page -> Header tab


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.2.0.0.alpha0+
Build ID: 3846561f79cf9065abd9ca83c9fbfbe7e52e28e2
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-10-20_23:33:00
Locale: nl-NL (nl_NL); Calc: CL
Comment 1 Durgapriyanka 2018-11-15 21:58:20 UTC
Version: 6.0.6.2
Build ID: 0c292870b25a325b5ed35f6b45599d2ea4458e77
CPU threads: 2; OS: Windows 6.1; UI render: default; 
Locale: en-US (en_US); Calc: group

Thank you for reporting the bug. I can confirm that the bug is present.
Comment 2 Xisco Faulí 2018-11-16 11:27:15 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=7d9bb549d498d6beed2c4050c402d09643febdfa

author	Armin Le Grand <alg@apache.org>	2014-06-02 15:00:50 +0000
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2014-07-01 13:30:09 +0200
commit	7d9bb549d498d6beed2c4050c402d09643febdfa (patch)
tree	2caf67e36c9ccd058268b003cf2bc39b9b102b53
parent	a5e137eb1d37361c60175e8fba780fc46b377a23 (diff)
Related: #i124638# Second step of DrawingLayer FillAttributes...

Bisected with: bibisect-44max

Adding Cc: to Armin Le Grand
Comment 3 Jim Raykowski 2019-03-10 19:48:09 UTC
Code Pointer:

One approach is to check the fill style attribute item state in the border background set, pBBSet, after the page header or footer set is put. If the fill style attribute is not SET put the fill style item to none.

LO code that will be used in this approach
SfxItemSet
SfxItemSet::GetItemState
SfxItemState::SET
SfxTabPage::GetWhich
XATTR_FILLSTYLE
SfxItemSet::Put
XFillStyleItem
drawing::FillStyle_NONE

https://opengrok.libreoffice.org/xref/core/svx/source/dialog/hdft.cxx?r=55042cb5#594