build LibreOffice with GTK3-support, try to launch LibreOffice with ./instdir/program/soffice --writer → result is that LibreOffice crashes. (has been reproduced during Hackfest on Debian and Ubuntu and Mageia) no crash when creating new writer document after having it launched with ./instdir/program/soffice I created debug-build with symbols for crashreport server → http://crashreport.libreoffice.org/stats/crash_details/30dfde45-1cec-4679-9252-19c5aab62374 (based on 0f190f50368816964b2a1b7bb58000ac1792d640 )
reverting e194f597ae5882e1cda2cac2925577fff609f101 "Change GlyphItem::nFallbackLevel to font instance" makes the error go away...
I do confirm it was introduced by https://cgit.freedesktop.org/libreoffice/core/commit/?id=e194f597ae5882e1cda2cac2925577fff609f101. Bisected with bibisect-linux64-6.2
Jan-Marek: I think it's not valid to assume "GlyphItems are bound to their GenericSalLayout", GlyphItems are actually stored and reused with later new layouts as well, see e.g. the status bar, menu, ruler or Writer.
*** Bug 120987 has been marked as a duplicate of this bug. ***
*** Bug 121009 has been marked as a duplicate of this bug. ***
About my crash I generated a crash report: crashreport.libreoffice.org/stats/crash_details/13aeba28-cf91-45d1-9356-1a4cb1e3aa2b Maybe this help you.
(In reply to Miklos Vajna from comment #3) > Jan-Marek: I think it's not valid to assume "GlyphItems are bound to their > GenericSalLayout", GlyphItems are actually stored and reused with later new > layouts as well, see e.g. the status bar, menu, ruler or Writer. Yup - that code is broken, as the glyphs just keep a fallout level, which might vary per MultiSalLayout. We're just lucky this doesn't crash more often. The Glyphs are just supposed to work with the same GenericSalLayout or MultiSalLayout. You don't even know, if a new MultiSalLayout has sufficient levels.
The intention with keeping GlyphItems around was that a GlyphItem just contains a glyph id and a position/width, which should be independent from the layout. So if m_nFallbackLevel refers to the layout that created it, such GlyphItems should not be cached. Perhaps you can check for this in OutputDevice::ImplLayout(), in the SalLayoutFlags::GlyphItemsOnly case -- if fallback level is "not 0" (or something) then return nullptr to indicate no pre-computed layout is possible? If the fix is more complex than this, then perhaps your fix should be first reverted so there is time to came up with a correct fix.
This is the most annoying bug I met in 6.2. It's hard to use 6.2 because of this. Every second times you open it crushes... See the video here: https://bugs.documentfoundation.org/show_bug.cgi?id=121009#c5
Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/71507ba3eb4bc6e8b36cd66b865c49a1b66b787e%5E%21 tdf#120982 add font reference to SalLayoutGlyphsImpl It will be available in 6.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Hi Jan-Marek, I'm afraid it's still crashing in Version: 6.2.0.0.alpha1+ Build ID: 2a06d78483db77aab28eaa522791bb4d96a4094e CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: threaded while it's not in Version: 6.2.0.0.alpha1+ Build ID: 2a06d78483db77aab28eaa522791bb4d96a4094e CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; Locale: ca-ES (ca_ES.UTF-8); Calc: threaded or calling LibreOffice like instdir/program/soffice
(In reply to Xisco Faulí from comment #11) > Hi Jan-Marek, I'm afraid it's still crashing. Yup - I know. It's bug 121030. And there is already a patch in Gerrit, but I didn't get any builds on it since some hours.
Seems to be fixed now in Version: 6.2.0.0.alpha1+ Build ID: 4326fb3ef3ddd7c6f9d08ba96add4f4736503ceb CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: threaded
Still crashing Version: 6.2.0.0.alpha1+ Build ID: e49c42d17f50c8b0cac9db08dedc375dd5aa8a98 CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: nl-BE (en_US.UTF-8); Calc: threaded
(In reply to Xavier Van Wijmeersch from comment #14) > Still crashing > > Version: 6.2.0.0.alpha1+ > Build ID: e49c42d17f50c8b0cac9db08dedc375dd5aa8a98 > CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: gtk3; > Locale: nl-BE (en_US.UTF-8); Calc: threaded That's a different crash. You need the fix for bug 121030, commit 4a66d7f0dd40c54307b5f750723f68b53703b01a ("tdf#121030 invalidate referenced FontInstances"), too, which was committed a few hours later.