Created attachment 146156 [details] wrong separator color In the GTK3 backend the separator for the Statusbar AND the notebookbars are black. They should have the same colors than in the default toolbar.
The standard toolbar shows separators in gray with some bright highlight color (3d effect) to the left. But on Notebookbars, for example the Contextual Groups (notebookbar_groups.ui), it is just a black line. Any idea, Caolan? Version: 6.2.0.0.alpha1+ Build ID: bc32c683117c771f6402165b151cd621ab69780f CPU threads: 8; OS: Linux 4.18; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); Calc: threaded LXQt using Breeze theming for Gtk2/Gtk3 (but same issue with Raleight/Emacs)
Created attachment 146765 [details] different separators in toolbar and statusbar the different colors are not only an issue in Notebookbar, also in Statusbar where you have also the hard black separtors
what can I do that this bug will be fixed caolanm@redheat.com ?
it needs investigation, perhaps this is vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx ControlPart::SeparatorVert. Someone needs to see if that's the code thats getting called, by e.g. commenting it out and seeing if that makes a difference, and if its the right code, figure out what it should do instead, and if that's not the right code to see what widget is drawing the lines instead
@bubli: Rough code pointer vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx The thing you're looking for is RenderType::Separator
how about https://gerrit.libreoffice.org/#/c/65110/ which draws such vertical lines like we do toolbar vertical separator
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/baa3c7389ec3f570be0486b3647ab424c7835ee1%5E%21 Resolves: tdf#121050 draw fixedlines like toolbar separators It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/d3e4c06ccb3aa4bb9078077a49dc2b2795835a5c%5E%21 Resolves: tdf#121050 draw fixedlines like toolbar separators It will be available in 6.2.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.