Bug 121102 - Offline language packs installation nests parentheses unnecessarily
Summary: Offline language packs installation nests parentheses unnecessarily
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Installation (show other bugs)
Version:
(earliest affected)
6.1.3.2 release
Hardware: All All
: lowest enhancement
Assignee: Raphael Bircher
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillPerl
Depends on:
Blocks: Language-Help-Packs
  Show dependency treegraph
 
Reported: 2018-11-01 19:41 UTC by Marco A.G.Pinto
Modified: 2023-06-16 23:43 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments
Too many parentheses (25.53 KB, image/png)
2018-11-01 19:41 UTC, Marco A.G.Pinto
Details
LO 6.3 RC1 screenshot (29.06 KB, image/png)
2019-07-09 09:20 UTC, Marco A.G.Pinto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marco A.G.Pinto 2018-11-01 19:41:45 UTC
Created attachment 146231 [details]
Too many parentheses

Hello!

Could the text be simplified to:
"Installing LibreOffice 6.1 Help Pack: English (United Kingdom)"
?

There is an excessive use of parentheses currently.

This is just an enhancement request.
Comment 1 Heiko Tietze 2018-11-08 15:40:39 UTC
Reasonable request. What can we do, Olivier? How about "Installing LibreOffice 6.2 Help Pack: English (UK)"?
Comment 2 Marco A.G.Pinto 2019-07-09 09:20:00 UTC
Created attachment 152663 [details]
LO 6.3 RC1 screenshot

This hasn't been improved in 6.3 RC1.

It still shows too many parentheses.

See the attached screenshot.

What it should show:

1) On the title bar:
"
LibreOffice 6.3 Help Pack: English (United Kingdom) - Installation Wizard
"


2) Inside the window:
"
Welcome to the Installation Wizard for
LibreOffice 6.3 Help Pack:
English (United Kingdom)
"


3) Inside the window:
"
The Installation Wizard will install LibreOffice 6.3 Help Pack:
English (United Kingdom)
on your computer. To continue, click Next.
"

And, maybe on 3) it shouldn't repeat the locale.
Comment 3 Stéphane Guillou (stragu) 2023-03-21 10:33:33 UTC
Hossein, could be an easyHack?
Comment 4 Hossein 2023-03-21 14:33:29 UTC
(In reply to Stéphane Guillou (stragu) from comment #3)
> Hossein, could be an easyHack?
Yes, this can be an EasyHack.
For code pointers, one can start from searching for "Installation Wizard" string:

 $ git grep "Installation Wizard"

which leads to instsetoo_native/inc_openoffice/windows/msi_languages/*.ulf, and then following the token ProductName:

 $ git grep ProductName instsetoo_native/

leads to the token PRODUCTNAMETEMPLATE. Searching for it:

 $ git grep PRODUCTNAMETEMPLATE

leads to the file solenv/bin/modules/installer/windows/property.pm. One should modify this Perl file to do the required changes.

To test the changes in action, one should build MSI packages by adding "--with-package-format=msi --without-ucrt-dir" to the autogen.input, then configure and build LibreOffice. After a successful build, the main MSI installer will be in the below folder available for testing:

 workdir/installation/LibreOfficeDev_SDK/msi/install/

For the language packs, you have to add the desired language to the build options. For example, for having English (US) and English (GB), you have to add --with-lang=en-GB while knowing en-US is always included.

Also, make sure that you have cloned the dictionaries and translations submodules. You can see the settings inside .git/config file after invoking "git submodule init". To avoid huge cloning, you can set "active = false" for helpcontents2 in .git/config and then invoke "./g pull -r". Be prepared to clone huge repositories with the download size > 10GB in total.
Comment 5 Raphael Bircher 2023-06-16 11:44:32 UTC
Hi everyone

I try to take over this