Bug 121120 - Png image is black when OpenGL enabled
Summary: Png image is black when OpenGL enabled
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.3.7.2 release
Hardware: All All
: medium normal
Assignee: Miklos Vajna
URL:
Whiteboard: target:6.3.0 target:6.2.3 target:7.1....
Keywords:
Depends on:
Blocks: Writer-Images VCL-OpenGL
  Show dependency treegraph
 
Reported: 2018-11-02 08:39 UTC by Pierre C
Modified: 2020-07-02 10:59 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
test file with 2 images. First is problematic (17.45 KB, application/vnd.oasis.opendocument.text)
2018-11-02 08:39 UTC, Pierre C
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre C 2018-11-02 08:39:19 UTC
Created attachment 146246 [details]
test file with 2 images. First is problematic

Just open the attached document.
The first image is a black rectangle when OpenGL is enabled.
The second is correct

When OpenGL is disabled all is fine
Comment 1 Marina Latini (SUSE) 2018-11-02 09:20:07 UTC
Confirmed on:

Version: 5.3.7.2 (x64)
Build ID: 6b8ed514a9f8b44d37a1b96673cbbdd077e24059
CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; Layout Engine: new; 
Locale: en-US (en_US); Calc: CL

Version: 6.2.0.0.alpha1
Build ID: ff46ad24d1d3cbcea45895520483ed1fd4ff488b
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: de-DE (en_US); Calc: CL

Version: 6.2.0.0.alpha1+ (x64)
Build ID: 0ee11c3f55ec1285d8febc065bda44224052eaae
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2018-11-01_20:45:03
Locale: en-US (en_US); Calc: CL

The image with the wrong rendering is a PNG. Updating the subject.
Comment 2 Miklos Vajna 2019-03-08 14:04:38 UTC
I'll look at this.
Comment 3 Commit Notification 2019-03-08 16:59:52 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/ba0abd02df8d62342497018f516535a2f1597fb6%5E%21

tdf#121120 vcl opengl: handle 8-bit palette bitmap as 24 bit RGB texture

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2019-03-11 21:27:13 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/20726c61680242eb647253651302dc048348687d%5E%21

tdf#121120 vcl opengl: handle 8-bit palette bitmap as 24 bit RGB texture

It will be available in 6.2.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2020-06-30 12:20:14 UTC
Luboš Luňák committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/29dc1029be6d8d02f4b639b32274a286afd0b1b3

differentiate between 8bit and any-bit grey palette (tdf#121120)

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2020-07-02 10:59:28 UTC
Luboš Luňák committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/08278332e3b39fc968a6a7ef603f39cbca108d4e

differentiate between 8bit and any-bit grey palette (tdf#121120)

It will be available in 7.0.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.