Bug Hunting Session
Bug 121166 - TRACK CHANGES: linked files changes are not shown in the master document
Summary: TRACK CHANGES: linked files changes are not shown in the master document
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: high normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsDevEval
Depends on:
Blocks: Track-Changes Writer-Master-Doc
  Show dependency treegraph
 
Reported: 2018-11-04 22:48 UTC by Emanuele Gissi
Modified: 2018-12-27 23:55 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
Test case, very simple master document (8.95 KB, application/vnd.oasis.opendocument.text-master)
2018-11-04 22:49 UTC, Emanuele Gissi
Details
Test case, very simple linked file (8.67 KB, application/vnd.oasis.opendocument.text)
2018-11-04 22:50 UTC, Emanuele Gissi
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Emanuele Gissi 2018-11-04 22:48:34 UTC
Description:
We have a large master odm document. Each chapter of the document is a linked file. We uses track changes to edit each chapter and submit the modifications to several committees.
I could not find a way to have the linked files changes shown in the master document.

Steps to Reproduce:
1. Create a master document
2. Link an external file
3. Set track changes in the external file and in the master document
4. Show the changes both in the external file and in the master document
5. The master document does not show the tracked changes of the external file

Actual Results:
The master document does not show the tracked changes of the external file

Expected Results:
The master document should show the tracked changes of the external file


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
This is rather important for our project. We are ready to finance any development.
Comment 1 Emanuele Gissi 2018-11-04 22:49:45 UTC
Created attachment 146302 [details]
Test case, very simple master document
Comment 2 Emanuele Gissi 2018-11-04 22:50:24 UTC
Created attachment 146303 [details]
Test case, very simple linked file
Comment 3 Drew Jensen 2018-11-04 23:53:56 UTC
Confirmed that this is indeed the behavior currently (from AOO 4.1.6 -> LO 6.2Aphla) .

Changed to enhancement request and added keywords for dev and UX evaluation, and set to new.
Comment 4 Emanuele Gissi 2018-11-05 00:04:47 UTC
Thank you Drew for triaging it.
Comment 5 Heiko Tietze 2018-11-05 08:21:43 UTC
needsUXEval needs CC ux-advise
Comment 6 Drew Jensen 2018-11-05 13:43:25 UTC
(In reply to Heiko Tietze from comment #5)
> needsUXEval needs CC ux-advise

OK, I'll try to remember that.

So anyway, I was thinking that a tree view would be a good way to display this type of sub-document change tracking. It would require quite the rework of the manage changes UI however.
Comment 7 Emanuele Gissi 2018-11-05 15:46:57 UTC
@Drew
In my opinion, just *showing* the changes of the linked files in the master document would be enough as a start.
When using a master document, the linked files are often (and reasonably) read-only.
The change tracking (accept/refuse) can be done by opening each linked file, as already allowed by the current UI.

(This would also be much faster to implement, before an hypothetical full rework of the feature)

Thank you,
Emanuele
Comment 8 Heiko Tietze 2018-11-05 16:25:30 UTC
Would be also my expectation. The linked documents could combine in the master and TC should work as it was one file. There might be the idea to have different TC comment colors per document but color is reserved to the authors.

Would understand the issue as a bug not an enhancement that needs UX.
Comment 9 Thomas Lendo 2018-11-10 04:58:40 UTC
I'm with Emanuele in comment 7. Linked files are not supposed to be edited directly but only if you edit them (separately or from the master document's Navigator).

Changing changes directly in the master document would require a change of the whole master document concept. This is too much for this enhancement request and will not be done in a foreseeable future.
Comment 10 Emanuele Gissi 2018-11-16 07:28:11 UTC
Hi all,
this bug is preventing us to assemble a full document while showing the tracked changes. We need the full document together, otherwise the references are all broken.

May I kindly ask if anybody is working on that?
How can I facilitate a solution to this issue?
How could I circumvent the problem in the meantime?

Thank you in advance,
Emanuele Gissi
Comment 11 Heiko Tietze 2018-11-16 07:42:36 UTC
(In reply to Emanuele Gissi from comment #10)
> May I kindly ask if anybody is working on that?

We can raise the importance, not more. The most experienced developer in the area of TC is CC'ed and working on the code. No idea if he is aware of this issue.
Comment 12 Xisco Faulí 2018-11-16 10:09:35 UTC
Adding László Németh as he has been working with track changes recently...
Comment 13 Emanuele Gissi 2018-12-13 09:59:13 UTC
Any good news?
Fixing this bug is very important to me.