Bug 121229 - Black box blinking inside the scrollbar of the special character dialog (gtk/gen)
Summary: Black box blinking inside the scrollbar of the special character dialog (gtk/...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:6.2.0 target:6.1.4
Keywords: bibisected, bisected, regression
: 121230 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-11-07 09:21 UTC by Telesto
Modified: 2018-11-15 13:30 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2018-11-07 09:21:16 UTC
Description:
MacOS: Black box blinking inside the scrollbar of the special character dialog

Steps to Reproduce:
1. Open Writer
2. Open the special character dialog
3. Cursor inside the search dialog
4. Press Arrow down (focus goes to the scrollbar, including a black blinking box

Actual Results:
black blinking box

Expected Results:
No blinking stuff


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.2.0.0.alpha0+
Build ID: 9356a2d98b13f45b3d17d181b1ad79d541d7d2f8
CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2018-09-30_23:41:16
Locale: nl-NL (nl_NL.UTF-8); Calc: threaded
Comment 1 Alex Thurgood 2018-11-07 09:43:57 UTC
Confirming also with

Version: 6.2.0.0.alpha1+
Build ID: 740b99783b5480fcd1e5fce7c1beb5967d015041
CPU threads: 4; OS: Mac OS X 10.14.1; UI render: default; VCL: osx; 
Locale: fr-FR (fr_FR.UTF-8); Calc: threaded
Comment 2 Alex Thurgood 2018-11-07 09:44:59 UTC
*** Bug 121230 has been marked as a duplicate of this bug. ***
Comment 3 Xisco Faulí 2018-11-13 14:40:48 UTC
Also reproduced with GEN and GTK2 but not with GTK3. Cursor moves to the character grid.

Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=374599f8c26713905a310673d2b429083321186a

author	Caolán McNamara <caolanm@redhat.com>	2018-03-22 13:41:50 +0000
committer	Caolán McNamara <caolanm@redhat.com>	2018-03-30 14:32:12 +0200
commit 374599f8c26713905a310673d2b429083321186a (patch)
tree 2ee4be182670b2ca9396a5f42d4122bed806a3ba
parent 2d3a5e81e9730c1190f8592f85f5b99b6d4587ef (diff)
weld SvxCharacterMap dialog

Bisected with: bibisect-linux64-6.1

Adding Cc: to Caolán McNamara
Comment 4 Caolán McNamara 2018-11-14 09:22:15 UTC
focus is given to the scrollbar, because it happens to be the first child of the ScrolledWindow which fits the (odd, but old) criteria of the cursor traversal.

A little annoying perhaps, but hardly "high, major" importance
Comment 5 Xisco Faulí 2018-11-14 10:03:56 UTC
(In reply to Caolán McNamara from comment #4)
> A little annoying perhaps, but hardly "high, major" importance

I agree...
Comment 6 Commit Notification 2018-11-14 20:26:25 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/20b2903354138f8ab19261fab74658fcf6af70e3%5E%21

Resolves: tdf#121229 ignore internal children of VclScrolledWindow

It will be available in 6.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Caolán McNamara 2018-11-14 20:42:50 UTC
backport to 6-1 in gerrit
Comment 8 Xisco Faulí 2018-11-15 12:53:08 UTC
Verified in

Version: 6.2.0.0.alpha1+
Build ID: 843fa5ff69f2bc502a6fa35878104d067b2a1e77
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

Now the moving down does nothing...

@Caolán, thanks for fixing this!
Comment 9 Commit Notification 2018-11-15 13:30:49 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

https://git.libreoffice.org/core/+/2cf23c31dd0cc9a9311770c00cf8525240d98fe7%5E%21

Resolves: tdf#121229 ignore internal children of VclScrolledWindow

It will be available in 6.1.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.