Bug 121354 - In Writer the SAVE icon continues to show aftersaving
Summary: In Writer the SAVE icon continues to show aftersaving
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
(earliest affected) release
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Not Assigned
Depends on:
Blocks: Writer-Toolbars
  Show dependency treegraph
Reported: 2018-11-11 17:42 UTC by Peter Banks
Modified: 2019-05-10 14:24 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Empty file. check the SAVE icon doesn't (36.55 KB, image/jpeg)
2018-11-12 06:02 UTC, Dieudonne Dukuzumuremyi
After writing the text before you click SAVE (46.22 KB, image/jpeg)
2018-11-12 06:03 UTC, Dieudonne Dukuzumuremyi
How the SAVE icon looks like after saving (31.53 KB, image/jpeg)
2018-11-12 06:04 UTC, Dieudonne Dukuzumuremyi
The way the pop up wizard looks like (60.67 KB, image/jpeg)
2018-11-12 06:05 UTC, Dieudonne Dukuzumuremyi
Check the SAVE icon, after adding a text to a none saved file (45.67 KB, image/jpeg)
2018-11-12 06:07 UTC, Dieudonne Dukuzumuremyi
Check the SAVE icon, after adding a text and save all (51.42 KB, image/jpeg)
2018-11-12 06:08 UTC, Dieudonne Dukuzumuremyi
video showning the Writer work ok (740.22 KB, video/mp4)
2018-11-12 06:29 UTC, BogdanB

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Banks 2018-11-11 17:42:43 UTC
After saving the SAVE icon does not get hidden. You can SAVE and SAVE again if you want.

When you close the file it recognises that the file has been saved and does not ask "do you want to save file"

Actual Results:
Just by editing a document

Expected Results:
Will not hide SAVE icon

Reproducible: Always

User Profile Reset: No

Additional Info:
Comment 1 Dieter 2018-11-11 20:34:55 UTC
Just for clarification: in LO5 the icon itself changes if you save a document. In LO6 there is al little dot, that disappears after saving. This dot remains?

I have set the bug's status to 'NEEDINFO'.
Comment 2 Dieudonne Dukuzumuremyi 2018-11-12 05:37:06 UTC
It is not easy to understand the reported bug but here there is what i tried and the result i got.
please describe this bug clearly.

Here is what i did:

1. I opened a new Writer file using LibreOffice

     - Before writing any content "SAVE" icon was still active.
     - When I added text in Writer, I clicked the Close file without Saving, and 
       message pop up came asking if I want to close without saving or if i want   to close.
     - When I chose Close without saving, The file disappeared of course i didn't save it.

2. I opened again a new writer and add a text "Hello QA Team":
    - I clicked on Save and the Wizard to choose the location and the file name appeared then file was saved.
    - Then I closed the file.
    - I reopened the file, and added another text then I clicked on close
      the file, after I received a pop up message asking me whether i want
      close without saving the changes or not. I chose YES. then the file were closed but the added message was not visible. of course its true because I chose "YES" to close without saving the changes
3. I reopened the file and add again a new text and the click on "SAVE" icon then i close the file and it was working properly.

NB: On "SAVE" icon, when there is an unsaved contents there is a small yellow dot on the Icon.

Please check on the attached pictures. 

My computer description:

Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.5 LTS
Release:	16.04
Codename:	xenial

LibreOffice Version:
Build ID: 86daf60bf00efa86ad547e59e09d6bb77c699acb
CPU threads: 8; OS: Linux 4.8; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group threaded
Comment 3 Dieudonne Dukuzumuremyi 2018-11-12 06:02:14 UTC
Created attachment 146545 [details]
Empty file. check the SAVE icon doesn't
Comment 4 Dieudonne Dukuzumuremyi 2018-11-12 06:03:50 UTC
Created attachment 146546 [details]
After writing the text before you click SAVE
Comment 5 Dieudonne Dukuzumuremyi 2018-11-12 06:04:36 UTC
Created attachment 146547 [details]
How the SAVE icon looks like after saving
Comment 6 Dieudonne Dukuzumuremyi 2018-11-12 06:05:56 UTC
Created attachment 146548 [details]
The way the pop up wizard  looks like
Comment 7 Dieudonne Dukuzumuremyi 2018-11-12 06:07:06 UTC
Created attachment 146549 [details]
Check the SAVE icon, after adding a text to a none saved file
Comment 8 Dieudonne Dukuzumuremyi 2018-11-12 06:08:04 UTC
Created attachment 146550 [details]
Check the SAVE icon, after adding a text and save all
Comment 9 BogdanB 2018-11-12 06:25:34 UTC
This is the correct behaviour:
- the disket icon is black when there is NO change in the file, the file was not modified
- the discket has a red star when something was modified in the file, idicating that you must save your work in order to keep it.
Comment 10 BogdanB 2018-11-12 06:29:07 UTC
Created attachment 146551 [details]
video showning the Writer work ok

You can see in this video what I described earlier. The black point is appearing when something changed, and the simple disket when nothing to save.
Comment 11 Peter Banks 2018-11-12 17:52:34 UTC
Thank you. I can see the little dot now.

I have recently started using LibreOffice after several years with OpenOffice. I must say I am very impressed with LibreOffice!

I use Writer, Calc Spreadsheet and Base Database.
Each deals with the SAVE icon differently.

Writer has the little dot and if you select the icon it saves the file whether the dot is there or not.

Calc has no little dot and one doesn't know if the file has been modified.

Base the icon is opaque and cannot be accessed if the file has not been modified; it becomes bold if the file needs saving.

Would it be better if there was a standard method?

All the best
Peter Banks
Comment 12 Dieter 2018-11-12 19:55:10 UTC
Peter, I agree, that the icons should be consistent. But I can't see differences between writer, calc and impress. I use LO 6.1.3 and Colibre as icon set.

Since your original problem is solved I think, I propose to close this bug report as RESOLVED WORKSFORME. Making icons consistent should be a different report. Do you agree?
Comment 13 Timur 2019-05-10 14:24:02 UTC
This is not WORKSFORME but NotABug. 
per https://bugs.documentfoundation.org/page.cgi?id=fields.html#bug_status