Bug 121412 - Minimal extensions no longer shows its toolbar and menu config
Summary: Minimal extensions no longer shows its toolbar and menu config
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Extensions (show other bugs)
(earliest affected)
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
Depends on:
Reported: 2018-11-14 09:59 UTC by Thorsten Behrens (allotropia)
Modified: 2023-11-17 03:12 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:

StarterProject.oxt (15.09 KB, application/vnd.openofficeorg.extension)
2018-11-14 11:12 UTC, Samuel Mehrbrodt (allotropia)

Note You need to log in before you can comment on or make changes to this bug.
Description Thorsten Behrens (allotropia) 2018-11-14 09:59:47 UTC
After a26adf6679aa13dc5821047f6aa1f05e7d0d00fd e.g. https://github.com/smehrbrodt/libreoffice-starter-extension/raw/master/dist/StarterProject.oxt stopped working for e.g. russian locales on Windows

Steps to Reproduce:
Load extension, restart LibO

Actual Results:
No toolbars/menus visible from extension

Expected Results:
Extension should work

Reproducible: Always

User Profile Reset: No

Additional Info:
Comment 1 Stephan Bergmann 2018-11-14 10:32:32 UTC
The registry/org/openoffice/Office/Addons.xcu in <https://github.com/smehrbrodt/libreoffice-starter-extension/raw/master/dist/StarterProject.oxt> shouldn't contain "Title" props that only have xml:lang="de" values.  At a minimum, a non-xml:lang or xml:lang="en-US" fallback should be provided (as the LO code that builds toolbars/menus from these configuration items apparently skips them for nil "Title" values).  (That StarterProject.oxt also looks suspicious in that it contains a random-looking mixture of xml:lang="de" and xml:lang="en-US" values.)

The rationale given in the commit message of <https://gerrit.libreoffice.org/plugins/gitiles/core/+/a26adf6679aa13dc5821047f6aa1f05e7d0d00fd%5E!/> "Better return nil than an arbitrary xml:lang="..." value" still looks compelling to me.
Comment 2 Samuel Mehrbrodt (allotropia) 2018-11-14 10:42:20 UTC
Ok you are right, the Addons.xcu should have fallbacks for en-US, will fix that.

But we are probably breaking other extensions too with this change which leads to menu/toolbar entries just disappearing.

As someone who installs the extension, I'd rather have a menu entry in a different language than no menu entry at all.

So maybe this needs some more consideration.
Comment 3 Samuel Mehrbrodt (allotropia) 2018-11-14 11:12:55 UTC
Created attachment 146617 [details]

Attaching the affected extension as I will update the upstream extension with the correct xml:lang settings.
Comment 4 Stephan Bergmann 2018-11-14 12:41:42 UTC
(Retroactively noted this change in behavior now at <https://wiki.documentfoundation.org/index.php?title=ReleaseNotes/6.1&oldid=169128> "Change in configuration behavior (fallback values for localized, nillable properties)".)
Comment 5 QA Administrators 2019-11-16 03:40:55 UTC Comment hidden (obsolete)
Comment 6 Thorsten Behrens (allotropia) 2019-11-16 18:44:14 UTC
Anyone still planning to change this? Otherwise, let's close as WONTFIX, at least the starter extension is adapted now.
Comment 7 QA Administrators 2021-11-16 04:09:55 UTC Comment hidden (obsolete)
Comment 8 QA Administrators 2023-11-17 03:12:41 UTC
Dear Thorsten Behrens (allotropia),

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)

If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword

Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team