Bug 121412 - Minimal extensions no longer shows its toolbar and menu config
Summary: Minimal extensions no longer shows its toolbar and menu config
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Extensions (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha0+
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-14 09:59 UTC by Thorsten Behrens (CIB)
Modified: 2018-11-15 12:27 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
StarterProject.oxt (15.09 KB, application/vnd.openofficeorg.extension)
2018-11-14 11:12 UTC, Samuel Mehrbrodt (CIB)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thorsten Behrens (CIB) 2018-11-14 09:59:47 UTC
Description:
After a26adf6679aa13dc5821047f6aa1f05e7d0d00fd e.g. https://github.com/smehrbrodt/libreoffice-starter-extension/raw/master/dist/StarterProject.oxt stopped working for e.g. russian locales on Windows

Steps to Reproduce:
Load extension, restart LibO

Actual Results:
No toolbars/menus visible from extension

Expected Results:
Extension should work


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Stephan Bergmann 2018-11-14 10:32:32 UTC
The registry/org/openoffice/Office/Addons.xcu in <https://github.com/smehrbrodt/libreoffice-starter-extension/raw/master/dist/StarterProject.oxt> shouldn't contain "Title" props that only have xml:lang="de" values.  At a minimum, a non-xml:lang or xml:lang="en-US" fallback should be provided (as the LO code that builds toolbars/menus from these configuration items apparently skips them for nil "Title" values).  (That StarterProject.oxt also looks suspicious in that it contains a random-looking mixture of xml:lang="de" and xml:lang="en-US" values.)

The rationale given in the commit message of <https://gerrit.libreoffice.org/plugins/gitiles/core/+/a26adf6679aa13dc5821047f6aa1f05e7d0d00fd%5E!/> "Better return nil than an arbitrary xml:lang="..." value" still looks compelling to me.
Comment 2 Samuel Mehrbrodt (CIB) 2018-11-14 10:42:20 UTC
Ok you are right, the Addons.xcu should have fallbacks for en-US, will fix that.

But we are probably breaking other extensions too with this change which leads to menu/toolbar entries just disappearing.

As someone who installs the extension, I'd rather have a menu entry in a different language than no menu entry at all.

So maybe this needs some more consideration.
Comment 3 Samuel Mehrbrodt (CIB) 2018-11-14 11:12:55 UTC
Created attachment 146617 [details]
StarterProject.oxt

Attaching the affected extension as I will update the upstream extension with the correct xml:lang settings.
Comment 4 Stephan Bergmann 2018-11-14 12:41:42 UTC
(Retroactively noted this change in behavior now at <https://wiki.documentfoundation.org/index.php?title=ReleaseNotes/6.1&oldid=169128> "Change in configuration behavior (fallback values for localized, nillable properties)".)