Bug 121638 - Different angle shown between sidebar & size and position dialog
Summary: Different angle shown between sidebar & size and position dialog
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
5.3 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.3.0 target:6.2.0.1
Keywords: difficultyBeginner, easyHack, skillCpp, topicUI
Depends on:
Blocks:
 
Reported: 2018-11-22 19:26 UTC by Telesto
Modified: 2018-12-17 09:22 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2018-11-22 19:26:02 UTC
Description:
Different angle shown between sidebar & size and position dialog

Steps to Reproduce:
1. Open Draw
2. Insert a line 45 degree
3. Look at the rotation in the sidebar (-45.00)
4. Press F4 -> Rotation tab -> 315.00
5. Save & reload -> 315 in the sidebar 

Actual Results:
Difference in rotation 

Expected Results:
Same results in every dialog


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.3.0.0.alpha0+
Build ID: d71ea82055a6a304493c7eaa90809a348e23784d
CPU threads: 4; OS: Windows 6.3; UI render: GL; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-11-19_03:25:07
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL
Comment 1 Xisco Faulí 2018-11-22 23:20:47 UTC
Reproduced in

Version: 6.2.0.0.beta1+
Build ID: a5bb6a0406d0018d1df279b925c80b392d9db277
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

and

Version: 5.3.0.0.alpha1+
Build ID: 4136757b4e51c4e6f7cb4132c95538a7f831ef2c
CPU Threads: 4; OS Version: Linux 4.15; UI Render: default; VCL: gtk3; Layout Engine: new; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

it seems it only reproducible when the line is drawn from top to bottom, no the other way around
Comment 2 Heiko Tietze 2018-11-23 08:09:03 UTC
We should add the code from dialog making the input -x into +(360)-x to the sidebar controls for a consistent UX. Should be an easyhack.
Comment 3 Xisco Faulí 2018-11-23 08:50:22 UTC
(In reply to Heiko Tietze from comment #2)
> We should add the code from dialog making the input -x into +(360)-x to the
> sidebar controls for a consistent UX. Should be an easyhack.

any code pointer ?
Comment 4 Sumit Chauhan 2018-12-12 16:28:51 UTC
(In reply to Xisco Faulí from comment #3)
> (In reply to Heiko Tietze from comment #2)
> > We should add the code from dialog making the input -x into +(360)-x to the
> > sidebar controls for a consistent UX. Should be an easyhack.
> 
> any code pointer ?


I guess the code is here : svx/source/sidebar/possize/PosSizePropertyPanel.cxx

Line : 677 

 case SID_ATTR_TRANSFORM_ANGLE:
            if (eState >= SfxItemState::DEFAULT)
            {
                const SfxInt32Item* pItem = dynamic_cast< const SfxInt32Item* >(pState);

                if(pItem)
                {
                    long nTmp = pItem->GetValue();

I think nTmp value need to be changed or we can check what GetValue returns.
Comment 5 Commit Notification 2018-12-16 16:42:04 UTC
Sumit Chauhan committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/294c38229a37604fe2d0d82a6ebc7bcd086963f4%5E%21

tdf#121638 , Different angle shown between sidebar & size and position dialog

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Xisco Faulí 2018-12-17 09:19:32 UTC
Verified in

Version: 6.3.0.0.alpha0+
Build ID: bdc82e277759a2df68855fce0a3fdd58f9b1ea66
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Sumit Chauhan, thanks for fixing this!!
Comment 7 Commit Notification 2018-12-17 09:22:08 UTC
Sumit Chauhan committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/b3eb3ef769642b2fa5b9453a8900bcb944643215%5E%21

tdf#121638 , Different angle shown between sidebar & size and position dialog

It will be available in 6.2.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.