Bug 121698 - Saving a document with thousands of comments hangs (GTK3)
Summary: Saving a document with thousands of comments hangs (GTK3)
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.2.0.3 release
Hardware: x86-64 (AMD64) Linux (All)
: high major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: gtk3-whipping-boy
  Show dependency treegraph
 
Reported: 2018-11-24 17:38 UTC by Buovjaga
Modified: 2022-07-14 15:05 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
GDB trace of hang with master (42.01 KB, text/plain)
2018-11-24 17:38 UTC, Buovjaga
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Buovjaga 2018-11-24 17:38:34 UTC
Created attachment 147005 [details]
GDB trace of hang with master

1. Open attachment 96007 [details] from bug 76324
2. Save as under some name

It hangs, but only with GTK3. Doesn't hang with 6.1.3

Arch Linux 64-bit
Version: 6.3.0.0.alpha0+
Build ID: 51e6a95757906dff8b2819a4141bf3dc7938e95f
CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded
Built on 24 November 2018
Comment 1 Xavier Van Wijmeersch 2018-11-24 19:47:41 UTC
confirm with

Version: 6.3.0.0.alpha0+
Build ID: d112ffd5f101a8533c48b2ce250951d8a1332252
CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: nl-BE (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 2 Caolán McNamara 2018-12-03 13:56:17 UTC
I don't believe this is specific to gtk3, just that accessibility works in gtk3 so the a11y hand/performance horror is visible
Comment 3 Aron Budea 2020-07-25 22:03:47 UTC
Bibisected the hang to the following commit using repo bibisect-linux-64-6.2.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=4804a1474ccba8df57f0a0151bd69237e82eb618
author		Armin Le Grand <Armin.Le.Grand@cib.de>	2018-08-01 21:47:30 +0200
committer	Armin Le Grand <Armin.Le.Grand@cib.de>	2018-08-02 10:53:47 +0200

Directly prevent multiple change broadcasts
Comment 4 Buovjaga 2022-06-20 07:25:40 UTC
Completes in about 12 secs stopwatch time now with gtk3. Tested again with 6.3 to be sure and it definitely takes longer (killed it).

Arch Linux 64-bit
Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 1c6057aa5a6b6cbd9cc8cbfbc3080dd2fdbd8783
CPU threads: 8; OS: Linux 5.18; UI render: default; VCL: gtk3
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 19 June 2022
Comment 5 Timur 2022-07-14 15:05:20 UTC
Hm, something is still wrong here. 
File gets saved fast but it stays very slow for a long time (again bug 76324).