Bug 121713 - Insert OLE Object File open dialog, add filters to match those displayed in dialog
Summary: Insert OLE Object File open dialog, add filters to match those displayed in d...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:6.3.0
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-26 13:17 UTC by Drew Jensen
Modified: 2018-11-27 11:31 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Screen shot of file open dialog (40.68 KB, image/jpeg)
2018-11-26 13:17 UTC, Drew Jensen
Details
OLE Object Dialog (21.58 KB, image/png)
2018-11-26 21:58 UTC, Drew Jensen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Drew Jensen 2018-11-26 13:17:54 UTC
Created attachment 147038 [details]
Screen shot of file open dialog

System Ubuntu 18.04, LO Version: 6.3.0.0.alpha0+
Build ID: 85f129b59ca690ba519cdbbdb4219fddc3e90098
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 

Steps to reproduce:
1 - Open Calc
2 - Start the process to o insert an OLE Object
3 - The file open dialog box includes a drop down list in the lower right corner
4 - Try to drop down that list

result
The drop down list is nor correctly drawn
The drop down list does not work

expected
The user can use that control on this dialog
Comment 1 Xisco Faulí 2018-11-26 17:58:56 UTC
Reproduced in

Version: 6.2.0.0.beta1+
Build ID: a63cd8bbe7cf881daa8dc7a7f32f3e5ac384e902
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

Version: 4.3.0.0.alpha1+
Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e

and

Versión: 6.1.3.2
Id. de compilación: 86daf60bf00efa86ad547e59e09d6bb77c699acb
Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; 
Configuración regional: es-ES (es_ES); Calc: group threaded

Same in Writer
Comment 2 Xisco Faulí 2018-11-26 17:59:27 UTC
@Caolán, I thought you could be interested in this issue...
Comment 3 Heiko Tietze 2018-11-26 20:55:25 UTC
Looks like the filter is missing but code at [1] has xFilePicker->appendFilter(*.*...). 

[1] https://opengrok.libreoffice.org/xref/core/cui/source/dialogs/insdlg.cxx#95
Comment 4 Caolán McNamara 2018-11-26 21:34:53 UTC
well, it does work, in that it sets the filter to "*.*" so anything can be selected. It has no name, so it looks odd, but there are no other options so... *shrug*, lets give it a name with https://gerrit.libreoffice.org/#/c/64077/ and then not worry about this
Comment 5 Drew Jensen 2018-11-26 21:51:08 UTC
Changing this to an enhancement request.
Comment 6 Drew Jensen 2018-11-26 21:58:58 UTC
Created attachment 147058 [details]
OLE Object Dialog

Insert->Object->OLE Object launches a dialog which by default offers to create a new object of type Drawing, Formula, Chart, Text, Presentation.

If the user selects to use an existing file, and then 'create from file', the file open dialog filter list could include a set of filters closely matching the above list [(All,*.*),(Drawing,*.odg), (Formula or Chart,*.ods,*.xslsx), (Text, *.odt, *.docx), etc)]
Comment 7 Heiko Tietze 2018-11-26 23:39:03 UTC
(In reply to Drew Jensen from comment #6)
> ...and then 'create from file', the file open dialog filter list 
> could include a set of filters...

Way too much fuss for this hidden feature. "All files|*.*" as done by Caolan works well.
Comment 8 Drew Jensen 2018-11-27 00:00:18 UTC
(In reply to Heiko Tietze from comment #7)
> (In reply to Drew Jensen from comment #6)
> > ...and then 'create from file', the file open dialog filter list 
> > could include a set of filters...
> 
> Way too much fuss for this hidden feature. "All files|*.*" as done by Caolan
> works well.

ah ha! I didn't realize he changed the code (for some reason thought it was a place holder) there. Alright, I'll set it to resolved at that.
Comment 9 Commit Notification 2018-11-27 11:31:08 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/3f2ac501e6593ef5095b308b887c48349e00c0a3%5E%21

tdf#121713 give filter a name

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.