In an empty presentation, click into a text box, and click away. => An undo step "Edit text of Text Frame..." is generated. If the text box contains text, no undo step is generated. Observed using LO 6.2.0.0.alpha1+ (26caf1bc59c81704f11225e3e431e412deb8c475) & 3.3.0 / Ubuntu 18.04.
Thank you for reporting the bug. I can not confirm the second step (If the text box contains text, no undo step is generated) in Version: 6.1.3.2 Build ID: 86daf60bf00efa86ad547e59e09d6bb77c699acb CPU threads: 2; OS: Windows 6.1; UI render: default; Locale: en-US (en_US); Calc: group threaded
Repro. Arch Linux 64-bit Version: 6.3.0.0.alpha0+ Build ID: c2d59ec2832c8b51568e73e9314ab9c82f1f5b7b CPU threads: 8; OS: Linux 4.20; UI render: default; VCL: gtk3; Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US Calc: threaded Built on 8 January 2019
Also on Win Version: 6.3.0.0.alpha0+ Build ID: 6b4ea2d8ddd681fec98773d7e0bbec9657a1fc08 CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; Locale: fi-FI (fi_FI); UI-Language: en-US Calc: threaded
Dear Aron Budea, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
still repro in Version: 7.2.0.0.alpha0+ (x64) Build ID: 94f6765d6ecc3145fa2d266231124003cf953118 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: CL
Dear Aron Budea, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
This is improved in LO 7.6.0.0.alpha0+ (f65d7fb18c5b850a381727a67c97fc94128082d2) / Ubuntu: no undo step anymore, but presentation still becomes modified. Let's keep this bug report open on that. The commit that fixed the undo, reverse-bibisected in 7.5: https://cgit.freedesktop.org/libreoffice/core/commit/?id=50a52eda9b22ea6659c93b2619700f483b06f09c author Caolán McNamara <caolanm@redhat.com> 2022-07-18 09:01:32 +0100 committer Caolán McNamara <caolanm@redhat.com> 2022-07-18 15:49:18 +0200 cid#1507360 Uninitialized scalar field
(In reply to Aron Budea from comment #7) > no undo step any more, The undo step is back in 24.8 with commit c45c64aeb57dce91965d7be54601128946455c90 Author: Michael Weghorn on Mon May 6 14:44:36 2024 +0200 tdf#160806 tdf#160837 gtk3 a11y: Drop handling of some VclEventIds
(In reply to Justin L from comment #8) > (In reply to Aron Budea from comment #7) > > no undo step any more, > The undo step is back in 24.8 with commit > c45c64aeb57dce91965d7be54601128946455c90 > Author: Michael Weghorn on Mon May 6 14:44:36 2024 +0200 > tdf#160806 tdf#160837 gtk3 a11y: Drop handling of some VclEventIds Interestingly, non-gtk3, e.g. gen or kf5 have the undo step even with the commit before this one, so I'm wondering whether this commit is problematic by itself or just triggers some pre-existing issue on gtk3 as well now.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bd6349d3fe1e2c9278aa333e2daf6a9e1a413075 tdf#121741 sd: not modified when leaving an empty placeholder It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Comment 10 fixes the bug mentioned in comment 7. The issue of comment 0 is still unsolved. It will require someone who is quite familiar with the SD UNDO mechanism to deal with it. I gave it a try with https://gerrit.libreoffice.org/c/core/+/174861.
Created attachment 197089 [details] EmptyPresentation.odp: The title was clicked in, but the text content never was (In reply to Justin L from comment #8) > The undo step is back in 24.8 Interestingly, this ONLY seems to happen on a new document, not on a loaded document. (Or more specifically, if the textbox has NEVER BEEN CLICKED IN, an undo step will be created - even for a loaded document.)
(In reply to Justin L from comment #12) Deep in the bowels of SdrObject::SetOutlinerParaObject, we have an innocent-looking SendUserCall(SdrUserCallType::Resize) which triggers an Undo if m_pUserCall. Well, the "I've already been clicked in textbox" does not have an m_pUserCall, but the other one does have it. Of course, there is no documentation about "user call". It is obviously important as comment "creates a presentation object with the given PresObjKind on this page. A user call will be set" suggests. But WHY???
given the limited scope indicated by comment 12, and the cause of the undo step (an apparent resize - despite the wording of the undo), there probably is no point in spending any more time trying to solve this.