Bug 121927 - UI: Make creating a new slide by double click more easy by letting a few pixels at the bottom
Summary: UI: Make creating a new slide by double click more easy by letting a few pixe...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.4 all versions
Hardware: All All
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, implementationError
Depends on:
Blocks: ImpressDraw-Enhancements
  Show dependency treegraph
 
Reported: 2018-12-05 18:14 UTC by Rüdiger Kupper
Modified: 2022-01-17 21:14 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rüdiger Kupper 2018-12-05 18:14:58 UTC
Description:
Version: 6.1.3.2
Build-ID: libreoffice-6.1.3.2-snap1

You can create new slides in impress by double clicking on the empty part of the slides pane (below the existing slide). However, this works only as expected while the slides pane actually has empty space at the bottom.

As soon as I have created a few slides, the slides pane is completely filled, and two things happen:

(1) Improvement: It is very hard to double click on the thin white space at the bottom of the filled slides pane. This could be improved by always letting a few pixels at the bottom to click on.

(2) Bug: You can actually manage to double click there and this creates a new slide. However, this new slide is not filed at the end of slides (as it should) but appears at a strange location somewhere in the middle of slides. This is definitely wrong.

Steps to Reproduce:
1. Create new slides until the slides pane is filled.
2. Observe that there's almost no (just very thin) space at the bottom of slides pane to click at.
3. Try to create another slide by double-clicking on that (very thin) space. 

Actual Results:
The new slide is created not at the end of slides, but somewhere in the middle.

Expected Results:
The new slide is created at the end of slides.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Version: 6.1.3.2
Build-ID: libreoffice-6.1.3.2-snap1
CPU-Threads: 4; BS: Linux 4.18; UI-Render: Standard; VCL: gtk3; 
Gebietsschema: de-DE (de_DE.UTF-8); Calc: group threaded
Comment 1 Vera Blagoveschenskaya 2018-12-06 06:29:53 UTC
Confirmed from my side for

Version: 6.3.0.0.alpha0+
Build ID: e4c2d0bb57ab8ea8f5c400d103d01376b8140f22
CPU threads: 1; OS: Linux 4.14; UI render: default; VCL: kde5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2018-11-30_21:37:10
Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US
Calc: threaded
Comment 2 Xisco Faulí 2018-12-07 13:30:57 UTC
Also reproduced in

Version: 4.4.0.0.alpha2+
Build ID: b21df5a993a3815cf736fe3d2eab73eee646b38e

in

Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)

the double click wasn't implemented...
Comment 3 raal 2019-01-10 16:25:26 UTC
This seems to have begun at the below commit.
Adding Cc: to Andrzej J.R. Hunt ; Could you possibly take a look at this one?
Thanks

Implemented in this commit
 bc2d7d4d0ac466a92703f7ba85cf75c19488aa70 is the first bad commit
commit bc2d7d4d0ac466a92703f7ba85cf75c19488aa70
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Sat Sep 5 22:43:10 2015 +0800

    source-hash-61a20e43b1ec7641bed073244c988e3ea981f086
    
    commit 61a20e43b1ec7641bed073244c988e3ea981f086
    Author:     Andrzej J.R. Hunt <andrzej@ahunt.org>
    AuthorDate: Sat Oct 26 17:10:52 2013 +0100
    Commit:     Caolán McNamara <caolanm@redhat.com>
    CommitDate: Fri Nov 8 10:25:49 2013 -0600
    
        SlideSorter: insert new slide on double-click.
    
        Previously inserting a new slide required using a context menu
        (via right-click) or the main menu-bar. It is now possible
        to insert a blank slide by double-clicking in an empty area
        of the slide sorter.
    
        Change-Id: Id7ac5f9d3befd02d0a89ad5e1631885c0493ad3d
        Reviewed-on: https://gerrit.libreoffice.org/6442
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>
Comment 4 Timur 2019-12-03 20:35:59 UTC
As for improvement, that's welcome.
As for bug, I don't understand it. To me it looks like new slide is created at the end. Anyway, it's the same as the previous one, so how could you tell the difference.
Comment 5 Rüdiger Kupper 2019-12-08 13:53:06 UTC
No, you can easily tell where the new slide is created, simply by tying defferent text into the existing slides (suggestion: Type "1" into slide 1, "2" into slide 2, etc.). If you do so, you will find that as soon as the existing slides fill the side bar, the new slide will be created at an unexpected position.

I just tested it again (Version: 6.3.3.2.0+), and new slides consistently appear at position #8 (although I have more than 10 slides). That's definitiely the wrong place. Try it.
Comment 6 QA Administrators 2022-01-06 03:45:49 UTC Comment hidden (obsolete)
Comment 7 Rüdiger Kupper 2022-01-17 21:14:30 UTC
This bug is still present in the originally described form in LO 7.2.4.1 Build b8e68b5bf61ce56d972a163ea31a18aecdcd64cd as of Ubuntu 21.10.