Bug 122052 - Undo Sequence Seems Incorrect When Undo-ing Auto Link/Email Formatting Created on Enter/Newline
Summary: Undo Sequence Seems Incorrect When Undo-ing Auto Link/Email Formatting Create...
Status: NEEDINFO
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.1.2.1 release
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Undo-Redo
  Show dependency treegraph
 
Reported: 2018-12-12 17:59 UTC by Scott C
Modified: 2019-01-16 22:44 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Scott C 2018-12-12 17:59:14 UTC
Description:
The Undo step for undoing auto-formatting of email addresses/links after a newline seems like it is in the wrong order with the enter/new line action. User can’t undo auto formatting and continue with next paragraph as expected.

The undo action for auto-formatting seems to work correctly when the link is not at the end of the paragraph.

I’m using version 6.1.2.1 on Fedora 29

Steps to Reproduce:
1) Write a paragraph with a link or email address at the end. Last sentence may have closing punctuation or it may not. For example as the last sentence in the paragraph:

My email address is somebody@libreoffice.org

LibreOffice is a cool project. Their website is http://libreoffice.org

LibreOffice is a cool project. Their website is http://libreoffice.org.

2) Type “Enter” to move to new line/paragraph
- LibreOffice performs auto-formatting at this point

3) Realize that auto-formatting of link/email is not desired.
4) Click Undo to remove auto formatting.

Actual Results:
5) On first undo, LibreOffice undoes the enter/newline.
6) formatting still remains. Undo again.
7) On second undo, if there was closing punctuation, LibreOffice skips the cursor back one character but still does not undo the formatting. If there was no closing punctuation, LibreOffice appears to do nothing.
8) formatting still remains. Undo again.
9) On third undo, formatting is removed.
10) Attempt to continue with document. Press enter to move to new line as was originally desired in step 2.
- As in step 2, LibreOffice again auto-formats the link/email
12) User does not want auto formatting but now realizes they are in a loop. They want to undo the auto formatting and also create a newline at the end of the paragraph but there isn’t a way to do this short of creating the newline prior to writing the end of the paragraph, and then going back to the paragraph to add the link.

Expected Results:
5) auto-formatting is removed
6) continue with work


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.1.2.1
Build ID: 6.1.2.1-3.fc29
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); Calc: group threaded
Comment 1 raal 2018-12-19 17:17:58 UTC
Confirm in Version: 6.3.0.0.alpha0+
Build ID: f8d6de19181d749d7c2b345ce7084c0c07fa3eab
CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win;
Comment 2 Xisco Faulí 2019-01-16 22:44:58 UTC
i can't reproduce it in

Version: 6.3.0.0.alpha0+
Build ID: 1bf68dbf53f4b5308e295058226abd6d6fb49c3d
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

Steps:
1. I paste My email address is somebody@libreoffice.org
2. Enter
3. Undo -> Formatting is removed
4. Undo -> newline is removed

Could you please try to reproduce it with a master build from http://dev-builds.libreoffice.org/daily/master/ ?
You can install it alongside the standard version.
I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the master build