Bug 122191 - Fileopen and Filesave: XLSX with Boolean value wrong if saved and resaved, MSO repairs file
Summary: Fileopen and Filesave: XLSX with Boolean value wrong if saved and resaved, MS...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.0.2.1 release
Hardware: All All
: medium normal
Assignee: Eike Rathke
URL:
Whiteboard: target:7.3.0 target:7.2.0.0.beta2
Keywords: bibisected, bisected, filter:xlsx, regression
: 120664 (view as bug list)
Depends on:
Blocks: XLSX-Corrupted
  Show dependency treegraph
 
Reported: 2018-12-19 09:33 UTC by BUATOIS
Modified: 2021-07-08 14:02 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Simpe test ODS (7.23 KB, application/vnd.oasis.opendocument.spreadsheet)
2018-12-19 17:29 UTC, Timur
Details
Example file saved to xlsx twice with en-US locale - good (4.31 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2020-02-05 10:03 UTC, NISZ LibreOffice Team
Details
Example file saved to xlsx twice with hu-HU locale - bad (4.31 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2020-02-05 10:03 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description BUATOIS 2018-12-19 09:33:38 UTC
Description:
I use cell format logic value 'Valeur logique' using VRAI/FAUX values in french version.
I save the file in .xlsx using format Microsoft Excel 2007-2013 XML.
If I save with "Save under" it works fine, if I store with "Save", when I reload the file the cell format is changed to category "Date" Format "BOOL99AN" wich is a user defined format, the description format is "BOOL"E"AN"
and the value dispayed of the cell is "BOOL99AN"

Steps to Reproduce:
1.In french version, clic right on a cell and select "Formater des cellules" choose "Valeur logique" and type "VRAI" in the cell. Then Save file with "Fichier > Enregistrer sous" choose type "Microsoft Excel 2007_2013 XML (.xlsx)(*.xlsx)" confirm "Utiliser le format Microsoft Excel 2007_2013 XML" then close the file.
2.Reload file and Save file with "Fichier > Enregistrer" then close the file.
3.Reload the file the format of the cell has been changed.

Actual Results:
The Cell display "BOOL99AN" instead of "VRAI" or "FAUX"

Expected Results:
"VRAI" or "FAUX"


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Timur 2018-12-19 17:28:22 UTC
No repro LO 5.0 and 6.0. Reproduced in LO 6.3+. 
But, as they say, if it looks like a regression and behaves like regression, it still doesn't have to be regression. Unless proved differently with some quick bibisect.

English UI will also do and show bug. Steps: 
1. make a cell with Boolean value TRUE
2. Save as XLSX and close
3. Reopen, see that value is right in LO (and MSO)
4. Save again as XLSX and close
5. Reopen in LO, see "BOOL99AN" (and reopen in MSO and see problem with content)
Comment 2 Timur 2018-12-19 17:29:07 UTC
Created attachment 147675 [details]
Simpe test ODS
Comment 3 Timur 2018-12-19 17:33:59 UTC
*** Bug 120664 has been marked as a duplicate of this bug. ***
Comment 4 Buovjaga 2018-12-26 17:40:04 UTC
Bibisected with win32-6.1 to
https://gerrit.libreoffice.org/plugins/gitiles/core/+/ce4fc2fc08be8ea2773194e303ed42d2579e93a0%5E!/

Resolves: tdf#115351 convert boolean equivalent format codes to proper Boolean

Adding Cc: to Eike Rathke
Comment 5 NISZ LibreOffice Team 2020-02-05 10:01:20 UTC
This also seems to be locale-dependent: 
- Not reproduced with en-US
- Reproduced with hu-HU

Version: 7.0.0.0.alpha0+ (x64)
Build ID: 54b28638ab15f68731861ae903c732273b41f78a
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; 
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc: CL
Comment 6 NISZ LibreOffice Team 2020-02-05 10:03:13 UTC
Created attachment 157663 [details]
Example file saved to xlsx twice with en-US locale - good
Comment 7 NISZ LibreOffice Team 2020-02-05 10:03:44 UTC
Created attachment 157664 [details]
Example file saved to xlsx twice with hu-HU locale - bad
Comment 8 Eike Rathke 2021-07-07 09:29:22 UTC
This somehow went under my radar, taking.
Comment 9 Commit Notification 2021-07-07 22:15:09 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7a58221f800e215934cbcb2d3907c35b44981611

Resolves: tdf#122191 BOOLEAN is a keyword, treat it as such

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2021-07-08 09:55:15 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/b92718fe3e9c873dc7d5a3aee66fb2adb780861a

Resolves: tdf#122191 BOOLEAN is a keyword, treat it as such

It will be available in 7.2.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2021-07-08 14:02:49 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/aa5acdda9a1bd05263e482c4f527be6d088edde6

tdf#122191: sc_subsequent_export-test2: Add unittest

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.