Download it now!
Bug 122311 - Find & Replace dialog could save search history on closing of the application
Summary: Find & Replace dialog could save search history on closing of the application
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Find-Search Dialog-Remember-Settings
  Show dependency treegraph
 
Reported: 2018-12-24 19:12 UTC by Abboot
Modified: 2019-06-13 14:36 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
the dialog history (15.66 KB, image/png)
2018-12-24 19:19 UTC, Abboot
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Abboot 2018-12-24 19:12:28 UTC
Description:
Find & Raplace dialogue don't save history of entered strings from previous sessions of the applications, e.g. calc and writer. It would be better if the apps kept the history of the dialogue on exit, i.e. between apps sessions. An appropriate option could be added.


Steps to Reproduce:
1. run writer
2. open a document
3. open dialog Find & Replace
4. enter first string for searching "string 1" and press enter
5. enter second string to find "string 2" and press enter again
6. close the dialog and exit writer
7. open writer
8. open the dialog and view history of "find" field

Actual Results:
The history is empty

Expected Results:
The history must contain the previous entered strings "string 1" and "string 2"


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.1.0.3
Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1
CPU threads: 2; OS: Windows 6.1; UI render: default; 
Locale: ru-RU (ru_RU); Calc: group threaded
Comment 1 Abboot 2018-12-24 19:19:25 UTC
Created attachment 147804 [details]
the dialog history
Comment 2 V Stuart Foote 2018-12-25 05:38:10 UTC
Believe currently the Find strings will persist until LibreOffice is fully closed. A new LibreOffice launch will have default search settings and empty Find string.

Would agree with OP, there is a case to be made for allowing find and replace strings to persist in user profile between LO sessions. But it should be configurable.

As an example, the Windows Notepad++ has this behavior and it is convenient to use.

=> NEW
Comment 3 Heiko Tietze 2018-12-31 09:38:13 UTC
For security reason I wouldn't store those information on the application level but perhaps in the document. How does MS handles this?
Comment 4 V Stuart Foote 2018-12-31 18:28:29 UTC
(In reply to Heiko Tietze from comment #3)
> For security reason I wouldn't store those information on the application
> level but perhaps in the document. How does MS handles this?

Recording search strings into an ODF archive seems no more "secure" than recording to user profile, probably less so since once a document is out of users control those prior searches would be exposed.

As to what could be done to record search strings (and probably replacement strings as well, not results of course) for LibreOffice the user profile seems the correct location.

Notepad++ records per user search strings into <FindName> stanzas in a  <FindHistory> XML file--config.xml. 

We already do similar in LibreOffice's application registry to hold the picklist for our MRU per user profile.
Comment 5 Roman Kuznetsov 2019-01-09 19:52:46 UTC
I agree with this enhancement
Comment 6 Heiko Tietze 2019-01-10 11:46:40 UTC
We discussed the idea in the design meeting and agree with the request. The search history should be stored in the user profile up to ~20 items, ideally with an option to disable it. That could be realized per Expert Configuration with changing the NumberOfStoredFindReplaceSearches to 0. 

Maybe it's an easyhack.