Bug 122323 - FILEOPEN PPTX large swing angles in arcTo command are not clipped to 360deg
Summary: FILEOPEN PPTX large swing angles in arcTo command are not clipped to 360deg
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.1 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: filter:pptx
Depends on:
Blocks: OOXML-Shapes
  Show dependency treegraph
 
Reported: 2018-12-25 18:27 UTC by Regina Henschel
Modified: 2020-06-14 16:01 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
arcTo command with large swing angle (31.46 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2018-12-25 18:27 UTC, Regina Henschel
Details
Same file in transitional (31.46 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2019-02-07 17:31 UTC, Regina Henschel
Details
Comparison LibreOffice 6.3 Master and MSO 2010 (56.83 KB, image/png)
2019-02-07 20:51 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2018-12-25 18:27:22 UTC
Created attachment 147817 [details]
arcTo command with large swing angle

The attached document contains a shape with swing angle 412deg on left side of slide 1 and a shape with swing angle -400° on right side of slide 1. Slide 2 contains an image which shows how PowerPoint renders the shapes. The shapes have a lineTo command to the center after the arcTo command, so that the end point point of the arcTo command becomes visible.

It seems, that PowerPoint clips swing angles larger than 360deg to 360deg and swing angles smaller than -360deg to -360deg. But LibreOffice seems to calculate the resulting end angle and use it modula 360deg, likely implicit by using sin and cos.

The command ARCANGLETO (G) does not belong to ODF but was introduced in LibreOffice to be able to handle the OOXML command arcTo. Therefore it should render such shapes the same as PowerPoint in edge cases too.
Comment 1 Xisco Faulí 2019-02-07 16:58:14 UTC
Hi Regina,
I tried to open the attached document in PowerPoint 2010 but it seems to be corrupted. Could you please doublecheck ?
Comment 2 Regina Henschel 2019-02-07 17:31:42 UTC
Created attachment 148985 [details]
Same file in transitional

It is a file in strict(=ISO) OOXML format. I'm not sure, whether PowerPoint 2010 is able to read such file. I use MS Office 365.

I have now attached the same file in transitional (=MS) OOXML. That should be readable by PowerPoint 2010.
Comment 3 Regina Henschel 2019-02-07 17:37:32 UTC
The adaption should not be made in the rendering part. There will be arbitrary swing angles when the command will be added to ODF, and OOXML has no restriction on the swing angle. The adaption has to be made in the import part.
Comment 4 Xisco Faulí 2019-02-07 20:51:17 UTC
Created attachment 148994 [details]
Comparison LibreOffice 6.3 Master and MSO 2010
Comment 5 Xisco Faulí 2019-02-07 20:55:08 UTC
Reproduced in

Version: 6.3.0.0.alpha0+
Build ID: 31d3369803ce4eceab5ef708f2cd33748b6d10ea
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

Version: 5.2.0.0.alpha0+
Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53
Threads 4; Ver: 4.15; Render: default; 

Version: 4.3.0.0.alpha1+
Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e

Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)
Comment 6 Regina Henschel 2020-06-14 16:01:40 UTC
It is fixed with https://git.libreoffice.org/core/commit/6de8d3109dffa7d4d0cc06f319cca70134f0a8f3

I have decided to restrict the angles in rendering OOXML-shapes.