Bug 122335 - Crash in debug build, when save a pptx file with custom shape to strict ODF 1.2
Summary: Crash in debug build, when save a pptx file with custom shape to strict ODF 1.2
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha0+ Master
Hardware: x86-64 (AMD64) All
: high major
Assignee: Julien Nabet
URL:
Whiteboard: target:6.3.0 target:6.2.0.2 target:6.1.5
Keywords: haveBacktrace
Depends on:
Blocks:
 
Reported: 2018-12-26 15:48 UTC by Regina Henschel
Modified: 2018-12-31 20:49 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
File with custom shape, not preset shape (31.15 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2018-12-26 15:48 UTC, Regina Henschel
Details
Crash information by Visual Studio 2017 (7.10 KB, text/plain)
2018-12-26 15:49 UTC, Regina Henschel
Details
bt with debug symbols (13.52 KB, text/plain)
2018-12-26 16:57 UTC, Julien Nabet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2018-12-26 15:48:03 UTC
Created attachment 147840 [details]
File with custom shape, not preset shape

Take a debug build and set it to save to "ODF 1.2".
Open attached file and save it to .odp.
Near the end of progress bar it crashes.
Comment 1 Regina Henschel 2018-12-26 15:49:45 UTC
Created attachment 147841 [details]
Crash information by Visual Studio 2017

The file contains the crash message and the "Aufrufliste" as generated by Visual Studio.
Comment 2 Regina Henschel 2018-12-26 16:47:23 UTC
The problem seems to be rLocalName="sub-view-size". Then it is likely related to bug 105603.
Comment 3 Julien Nabet 2018-12-26 16:57:47 UTC
Created attachment 147845 [details]
bt with debug symbols

On pc Debian x86-64 with master sources updated today, I could reproduce this.
Comment 4 Julien Nabet 2018-12-26 16:58:30 UTC
Let's increase the importance since:
- it's a crash
- it occurs on several platforms
Comment 5 Julien Nabet 2018-12-26 17:43:46 UTC
Regina: as you may have seen, I submitted this patch on gerrit for master: https://gerrit.libreoffice.org/#/c/65623/
Comment 6 Regina Henschel 2018-12-26 19:08:16 UTC
Julien: Yes, that works. I had just tried with
if (rExport.getDefaultVersion() > SvtSaveOptions::ODFVER_012)
{
...
}

Please change the comment. It is not about draw:display but about attribute sub-view-size.
Comment 7 Commit Notification 2018-12-26 19:11:02 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/1141fc3247bf8cf901af3f9c0194cbb2621ff707%5E%21

tdf#122335: sub-view-size can only be used with ODF ver > 1.2

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Julien Nabet 2018-12-26 19:11:40 UTC
Backports here:
6.2: https://gerrit.libreoffice.org/#/c/65626/
6.1: https://gerrit.libreoffice.org/#/c/65627/
Comment 9 Commit Notification 2018-12-26 22:11:23 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/f23b7a8a73114d65d1aa38e5a648e622a56f6ee6%5E%21

tdf#122335 follow-up, typo

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2018-12-31 20:47:04 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/e694119f1246e46b2f525e6111b3c7c775909f91%5E%21

tdf#122335: sub-view-size can only be used with ODF ver > 1.2

It will be available in 6.2.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2018-12-31 20:49:51 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

https://git.libreoffice.org/core/+/26ad33a6f1e894d7352fb3d175c8d15dd28673b2%5E%21

tdf#122335: sub-view-size can only be used with ODF ver > 1.2

It will be available in 6.1.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.