Bug 122359 - Scrolling to top of page in a odg file in CODE doesn't work on other page
Summary: Scrolling to top of page in a odg file in CODE doesn't work on other page
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice Online
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.3.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2018-12-28 10:36 UTC by Michiel Janssens
Modified: 2021-02-15 11:48 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michiel Janssens 2018-12-28 10:36:28 UTC
Collabora Office 6.0-18 (git hash: e74e598)
Loolwsd 4.0.0 (git hash: 173510f) RC2
Ubuntu 18.04.1 LTS via code repo installed

When opening a odg file inside Nextcloud, the content is nicely displayed from the CODE instance.
On the first page scrolling  to top, to bottom and back to top works.
When scrolled to bottom, and selecting the next page, you end up at the bottom of that page, however you cannot scroll back to top.
Tested with Chromium and Firefox
Comment 1 Aron Budea 2019-01-02 02:46:09 UTC
Confirmed with a local master build.

LOOLWSD master.. (git hash: 07155e3b)
LOKit   LibreOfficeDev 6.3.0.0.alpha0 (git hash: d23ab72)

It's actually a regression from the commit referenced below. Before that the view jumped to the top of page when switching pages, which is the expected behavior.

https://cgit.freedesktop.org/libreoffice/online/commit/?id=e27ae38bebf4b57aa7563357a188e33d0e1e0be8
author		Tor Lillqvist <tml@collabora.com>	2018-11-22 14:15:38 +0200
committer	Tor Lillqvist <tml@collabora.com>	2018-11-22 14:58:56 +0200

Fix jumping after touch zooming also for mobile clients of normal Online
Comment 2 Commit Notification 2019-01-23 15:57:52 UTC
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/+/ec24337b11e097e98266c51d8fe56c42a8ec613a%5E%21

tdf#122359: Revert e27ae38bebf4b57aa7563357a188e33d0e1e0be8 for non-MOBILEAPP
Comment 3 Commit Notification 2019-01-25 10:23:58 UTC
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/+/f028fd58f246d0139b35af8e7f48fed8c4a6173c%5E%21

tdf#122359: Un-revert and edit in a attempt to reach a compromise
Comment 4 Aron Budea 2021-02-14 09:59:18 UTC
I assume this has been fixed, if not, please open an issue over at
https://github.com/CollaboraOnline/online/issues
Comment 5 Michiel Janssens 2021-02-15 11:17:46 UTC
I just checked to be sure and can confirm it's fixed, thanks.
Comment 6 Aron Budea 2021-02-15 11:48:01 UTC
Great, thanks for retesting and confirming!