Bug 122451 - iframe is not loaded when WOPI host is running on a non-standard port
Summary: iframe is not loaded when WOPI host is running on a non-standard port
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice Online
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Samuel Mehrbrodt (allotropia)
URL:
Whiteboard: target:6.3.0 target:6.2.0.2
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-03 20:39 UTC by Andras Timar
Modified: 2019-01-09 12:48 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Timar 2019-01-03 20:39:17 UTC
My test was:
1. docker run -d -p 8080:80 nextcloud
2. My IP is 192.168.100.20. I opened http://192.168.100.20:8080 in browser, set up Nextcloud and installed Collabora Online app
3. docker run -t -d -p 9980:9980 -e "extra_params=--o:ssl.enable=false" collabora/code
4. I set up the WOPI URL in Nextcloud to http://192.168.100.20:9980

The iframe is not loaded because of CSP violation. Since:

commit 296aba1beae64a65e4e86631a9c1458073ec8c2e
Author: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Date:   Fri Nov 23 09:33:13 2018 +0100

    Improve allowed frame-ancestors

and

commit 8f1abe48397d7da4629fb50324289ad39102cfc7
Author: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Date:   Wed Nov 28 09:36:24 2018 +0100

    Only add the host to frame-ancestors

Not a big deal, but ideally port number should be taken into account, in case someone runs the WOPI host on a non-standard port.
Comment 2 Aron Budea 2019-01-08 14:21:24 UTC
Let's set this to confirmed, then.
Comment 3 Commit Notification 2019-01-09 09:46:00 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/+/9d1c6f03cad9e6aa023807031b22aba6e9df4909%5E%21

tdf#122451 CSP: Allow all ports of known hosts
Comment 4 Samuel Mehrbrodt (allotropia) 2019-01-09 09:47:26 UTC
Should be better now hopefully.
Comment 5 Commit Notification 2019-01-09 12:48:36 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/online/+/532bc18a2c7afe5cc224e07a74d593435a29e2f1%5E%21

tdf#122451 CSP: Allow all ports of known hosts