Created attachment 148268 [details] Sample Calc document When using a currency format with asterisk (*) and space, the formatting is wrong when the result contains a space as a thousand separator. Please see attached document (the Format was created by LO when converting from XLS document). The idea is that the "minus" sign should be aligned to the left for all cells, where the numbers remains right-aligned.
Created attachment 148269 [details] Screenshot of the sample document As the issue is supposedly locale dependent, I have also made a screenshot of the sample document as it appears in Czech locale (space as a thousand separator).
Created attachment 150152 [details] how it looks for me in master
Same result in Versión: 6.2.2.1 Id. de compilación: fcd633fb1bf21b0a99c9acb3ad6e526437947b01 Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; VCL: win; Configuración regional: es-ES (es_ES); Idioma de IU: es-ES Calc: threaded with spanish locale. @Raal, do you reproduce it in czech locale ?
Created attachment 150279 [details] printscreen Czech locale printsreen from In Version: 6.3.0.0.alpha0+ Build ID: 82463bdde75447d45e0cd6ed9ab579e0e51ea912 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: cs-CZ (cs_CZ.UTF-8); UI-Language: en-US Calc: threaded and Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a) in both versions is space as thousand separator. Format code in 4.1 copied from format cell dialog: [>0]# ##0" € ";[<0]# ##0" € ";-#" € ";@ Format code in 6.3: [>0]" "* # ##0" € ";[<0]-* # ##0" € ";" "* -#" € ";" "@" "
NEW per Raal's result.
Dear Joe, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Hello, I have retested this bug with the current LibreOffice 7.1.5.2 and the upcoming LibreOffice 7.2.0.2 (on Windows 10 x64 with Czech locale). The behavior remains the same: The "minus" sign is still not aligned properly if the number contains a space as a thousand separator (e.g. in Czech locale). I have also checked how older versions behave (on Windows 7 x86 with Czech locale): * with versions 3.3.0.4, 4.0.0.3 and up to 4.3.7.2 the "minus" sign is not shown at all (displaying the negative numbers incorrectly). * with versions 4.4.0.3 and newer, the display behaves just like the current releases (number shown correctly, just the alignment of the "minus" sign is wrong).
Note: there is a better solution for the layout problem: using narrow no-break space (U-202F), which doesn't enable the different layout, and this is the proposed thousand separator in typography.
Czeber László Ádám committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/72e70088dc45fbe15f809abf5263247b13d937ac tdf#122676 sc: fix format with * (filling) and NBSP thousand separator It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
@Joe and all: thanks for the report and feedback! @László: thanks for the nice fix! Commit description: tdf#122676 sc: fix format with * (filling) and NBSP thousand separator Numbers containing no-break space (NBSP) thousand separator enabled the EditEngine layout, losing filling e.g. for stretching spaces. Enable EditEngine for NBSP characters only if there is no filling in the number format code, fixing MSO interoperability, too. In number format codes, asterisk (*) followed by a character is used to fill the available space in the column with that character, e.g. format code [>0]" "* # ##0" € ";[<0]-* # ##0" € ";" "* -#" € ";" "@" " put the minus sign at the left side of the column, while the number at the right side of the column. Because of the NBSP thousand separator, bigger numbers got different layout previously, i.e. minus signs right next to the numbers. Note: there is a better solution for the layout problem: using narrow no-break space (U-202F), which is the proposed thousand separator in typography, and it's back-compatible, because it doesn't enable the different layout.
Czeber László Ádám committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/68bbbfd3b93c546c8004e916ea58a4c16f95c648 tdf#122676 sc: fix format with * (filling) and NBSP thousand separator It will be available in 7.6.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 986c2d86a7b53a6599d014db7327f47cb33d4fea CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: CL threaded
Czeber László Ádám committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/56c965372e2de4ea53b1ab09056906c85fbff06b tdf#122676 sc: fix format with * (filling) and NBSP thousand separator It will be available in 7.5.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.