Bug 122735 - objects outside the selected group don't become pale
Summary: objects outside the selected group don't become pale
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2019-01-15 15:34 UTC by Telesto
Modified: 2019-05-22 17:10 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Group and single shape for testing (10.77 KB, application/vnd.oasis.opendocument.graphics)
2019-05-22 16:32 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2019-01-15 15:34:44 UTC
Description:
It's rather hard to detect being inside a grouping after entering one. Even harder if you aren't aware a grouping is present (3D objects). And press ESC doesn't help in that case

Steps to Reproduce:
1. Open Draw
2. Insert a 3D object (say Cube)
3. Rotate the cube (double clicking it & drag)
4. Click on the empty page -> Object deselected, still in grouping mode


Actual Results:
Not aware of being inside a grouping

Expected Results:
The grouping should be a little more prominent 
* Add the Leave grouping button to the toolbar (minimum)
* Some sort visual indication? Frame border/Info Bar/ frame around the page.. or anything else which makes it clear


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.3.0.0.alpha0+
Build ID: 61778fd20395794d2de3b52d60dcc65083aecd93
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL
Comment 1 Xisco Faulí 2019-05-22 15:09:09 UTC
I guess the only way to know it now is with the content menu, checking if it's says, Enter Group or Exit Group...

UX Team, what's your opinion ?
Comment 2 Heiko Tietze 2019-05-22 15:40:36 UTC
What's the problem with knot knowing if you are in a group? Maybe the 3D cube is a bad example: two grouped shapes should display their relation when you enter. This is achieved with the Navigator that takes the hierarchy. => WFM

A super-cool solution would be to gray out objects that are not in the current group. But I guess that's a lot of work for not much benefit.
Comment 3 Regina Henschel 2019-05-22 16:32:26 UTC
Created attachment 151600 [details]
Group and single shape for testing

The attached document has a single shape 'star' and a group containing 'smiley' and 'diamond'. Double-click the smiley. Expected behavior: The star becomes pale, only shapes inside the group are shown normally. Same for 3D-Scenes, shapes outside the scene need to become pale, when you enter the scene.

That had worked in Version: 6.0.7.3 (x64)
Build ID: dc89aa7a9eabfd848af146d5086077aeed2ae4a5
CPU threads: 8; OS: Windows 10.0; UI render: default; 
Locale: de-DE (en_US); Calc: CL

It is broken at least since
Version: 6.1.4.2 (x64)
Build-ID: 9d0f32d1f0b509096fd65e0d4bec26ddd1938fd3
CPU-Threads: 8; BS: Windows 10.0; UI-Render: Standard; 
Gebietsschema: de-DE (en_US); Calc: CL

So this is not an 'enhancement' but a true bug.

Heiko: If you do not know, that you are inside a group, you have no clue, why an object is not selectable. Try to select the star by clicking on it, after you have double-clicked the smiley.

A 3D-scene has the additional problem, that users often not even know, that a 3D-scene always acts as group, even if it only contains one objects.
Comment 4 Xisco Faulí 2019-05-22 17:10:35 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=726d7e7b8b50dca9914329dbfd9491f7c8961f68

author	Armin Le Grand <Armin.Le.Grand@cib.de>	2018-05-25 12:58:10 +0200
committer	Armin Le Grand <Armin.Le.Grand@cib.de>	2018-05-25 12:59:48 +0200
commit	726d7e7b8b50dca9914329dbfd9491f7c8961f68 (patch)
tree	aba7b05720e84dc38dabe93f6a51825326c2a7be
parent	a28a839b9f9eeec1544c5ceeeabe7b1083ce1655 (diff)
tdf#117629: Remove again after next step of SOSAW080 is done

Bisected with: bibisect-linux64-6.2

Adding Cc: to Armin Le Grand