Bug 122788 - Find and replace dialog - Replace all doesn't work in specific situation
Summary: Find and replace dialog - Replace all doesn't work in specific situation
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
5.2.0.4 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.3.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Find&Replace-Dialog
  Show dependency treegraph
 
Reported: 2019-01-17 15:23 UTC by raal
Modified: 2021-11-24 15:14 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
file for test (12.50 KB, application/vnd.oasis.opendocument.presentation)
2019-01-17 15:25 UTC, raal
Details
bt with debug symbols (4.42 KB, text/plain)
2019-03-10 09:22 UTC, Julien Nabet
Details
bt orig (4.33 KB, text/plain)
2019-03-10 09:23 UTC, Julien Nabet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description raal 2019-01-17 15:23:31 UTC
Description:
works in Writer, doesn't work in Impress. Regression, works OK in LO 4.1

Steps to Reproduce:
open attached file
find and replace dialog
    textbox Find: First
    textbox Replace: replace
click button Replace twice - on first slide is text "replace first first"
do not close dialog
    click Replace all

Actual Results:
nothing happens. "replace all" not work

Expected Results:
on first slide is text "replace replace replace"


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 raal 2019-01-17 15:24:45 UTC
This seems to have begun at the below commit.
Adding Cc: to Marco Cecchetti  ; Could you possibly take a look at this one?
Thanks
 f71921a0a1347ef20491cd6554f5be929431a7fd is the first bad commit
commit f71921a0a1347ef20491cd6554f5be929431a7fd
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Fri Dec 8 09:44:48 2017 +0100

    source fd0be5e94fd4f591cb7746ac5a373b1fa0ca1455

author	Marco Cecchetti <marco.cecchetti@collabora.com>	2016-01-06 17:00:09 +0100
committer	Jan Holesovsky <kendy@collabora.com>	2016-01-07 10:59:21 +0100
commit fd0be5e94fd4f591cb7746ac5a373b1fa0ca1455 (patch)
tree 2c1bf98a798f87fc1da251fd6e4bc882b5034a52
parent 098bcbc7dcc5c3506911ea8ab5a44685a9bb35fd (diff)
sd: lool search all - 2nd search did not work - fixed
Comment 2 raal 2019-01-17 15:25:10 UTC
Created attachment 148401 [details]
file for test
Comment 3 Durgapriyanka 2019-01-18 15:43:39 UTC
Reproducible in 

Version: 6.3.0.0.alpha0+
Build ID: 3c964980da07892a02d5ac721d80558c459532d0
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-12-12_02:07:45
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
Comment 4 raal 2019-01-18 15:45:36 UTC
confirmed in comment 3
Comment 5 Julien Nabet 2019-03-10 09:22:14 UTC
Created attachment 149853 [details]
bt with debug symbols

On pc Debian x86-64 with master sources updated today, I got an assert.
Comment 6 Julien Nabet 2019-03-10 09:23:25 UTC
Created attachment 149854 [details]
bt orig

I got an assert because it's already in text edit mode.
See this other bt.
Comment 7 Commit Notification 2019-03-21 09:49:13 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/3d9f973e6648c5819608237f390df523b6a32ed8%5E%21

Related tdf#122788: avoid assert

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Julien Nabet 2019-03-21 10:17:56 UTC
Let's remove target, it was just to avoid assert.
Comment 9 Justin L 2021-11-23 16:18:29 UTC
fixed in LO 7.1 with commit 2ebc26aeefefe33ee6180862509e4971ff2dfc6f
Author: Tomaž Vajngerl on Sat Aug 22 21:45:44 2020 +0200
    sd: Make search bound to a view - to allow independent searching
Comment 10 Commit Notification 2021-11-24 15:14:48 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4b98cdc9ed51186cd0a7ef5041bf8e8e29420289

tdf#122788: sd: Add UItest

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.