Bug 122889 - Mail config dialog is empty
Summary: Mail config dialog is empty
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.2.0.2 rc
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:6.3.0 target:6.2.0
Keywords: regression
Depends on:
Blocks:
 
Reported: 2019-01-23 07:12 UTC by Mike Kaganski
Modified: 2019-01-23 14:07 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Empty dialog (11.89 KB, image/png)
2019-01-23 07:12 UTC, Mike Kaganski
Details
Screenshot in 6.0 (5.86 KB, image/png)
2019-01-23 07:34 UTC, Mike Kaganski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2019-01-23 07:12:05 UTC
Created attachment 148537 [details]
Empty dialog

If mail merge mail configuration (Options→Writer→Mail Merge E-mail) is not set, trying to send merged documents gives a confirmation dialog:

> In order to be able to send mail merge documents by e-mail, LibreOffice
> requires information about the e-mail account to be used.
> 
> Do you want to enter e-mail account information now?

and if user agrees, the next dialog (SwMailConfigDlg) is shown, which is empty (without caption and content, only with [Help] [OK] [Cancel] buttons - see screenshot).

It should contain the same options page as Options→Writer→Mail Merge E-mail (i.e., SwMailConfigPage).

Tested with Version: 6.2.0.2 (x64)
Build ID: 2ce5217b30a543f7666022df50f0562f82be0cff
CPU threads: 12; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: CL

and with Version: 6.3.0.0.alpha0+ (x64)
Build ID: 13279b94080d87dde51bc8b8c669212bf71cacca
CPU threads: 12; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: CL
Comment 1 Mike Kaganski 2019-01-23 07:33:51 UTC
Works OK in 6.0 with Version: 6.0.0.1 (x64)
Build ID: d2bec56d7865f05a1003dc88449f2b0fdd85309a
CPU threads: 12; OS: Windows 10.0; UI render: GL; 
Locale: ru-RU (ru_RU); Calc: CL
Comment 2 Mike Kaganski 2019-01-23 07:34:20 UTC
Created attachment 148538 [details]
Screenshot in 6.0
Comment 3 Mike Kaganski 2019-01-23 08:15:48 UTC
Suspecting Caolán's work on welding dialogs (SwMailConfigDlg got welded in https://git.libreoffice.org/core/+/7ec12ce7e449d7849b3e67c443783110e2a50a17, in the master toward of 6.2). But it's hard to tell, since the dialog crashes LO in a large range of commits around that.

Caolán, could you please take a look?
Comment 4 Caolán McNamara 2019-01-23 10:24:53 UTC
looks like the page wasn't converted so the dialog conversion was premature
Comment 5 Commit Notification 2019-01-23 12:03:54 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/0750be852e865c6c5f6f26365064126c10770f31%5E%21

Resolves: tdf#122889 Mail config dialog is empty

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Caolán McNamara 2019-01-23 12:11:09 UTC
backports in gerrit
Comment 7 Commit Notification 2019-01-23 12:56:18 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-2-0":

https://git.libreoffice.org/core/+/d5344e45ab0b7f096efd6e86ecdecd96cfa68fa5%5E%21

Resolves: tdf#122889 Mail config dialog is empty

It will be available in 6.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Xisco Faulí 2019-01-23 13:32:48 UTC
Verified in

Version: 6.3.0.0.alpha0+
Build ID: 0750be852e865c6c5f6f26365064126c10770f31
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Caolán, Thanks for the quick fix!
Comment 9 Commit Notification 2019-01-23 14:07:48 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/ac163b519fc56e3695617315579bbcafeb3a9fe1%5E%21

Related: tdf#122889 weld SwMailConfigPage

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.