Bug Hunting Session
Bug 122898 - FILESAVE DOCX, Shape loses its resize option when odt is saved as docx
Summary: FILESAVE DOCX, Shape loses its resize option when odt is saved as docx
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.4.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, filter:docx, implementationError
: 123331 (view as bug list)
Depends on:
Blocks: OOXML-Shapes
  Show dependency treegraph
 
Reported: 2019-01-23 13:26 UTC by NISZ LibreOffice Team
Modified: 2019-06-18 12:55 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments
The original odt containing a two-way arrow. (32.26 KB, image/png)
2019-01-23 13:27 UTC, NISZ LibreOffice Team
Details
Screenshot of the exported document. (32.33 KB, image/png)
2019-01-23 13:28 UTC, NISZ LibreOffice Team
Details
Screenshot of the original document. (32.26 KB, image/png)
2019-01-23 13:29 UTC, NISZ LibreOffice Team
Details
The original odt containing a two-way arrow. (13.34 KB, application/binary)
2019-01-23 13:30 UTC, NISZ LibreOffice Team
Details
The exported docx file. (17.11 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2019-01-23 13:33 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2019-01-23 13:26:16 UTC
Description:
When a odt file with a shape that has an inner resize slider gets saved as docx the resize option is missing.

Steps to Reproduce:
    1. Create a new .odt file in Writer.
    2. Insert a shape which has an inner resize slider like two-way arrows.
    3. Save it as .docx.
    4. Open the docx in Writer.

Actual Results:
The inner resize slider is missing.

Expected Results:
The shape should keep its resize capabilities even after exporting to docx.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 NISZ LibreOffice Team 2019-01-23 13:27:12 UTC
Created attachment 148556 [details]
The original odt containing a two-way arrow.
Comment 2 NISZ LibreOffice Team 2019-01-23 13:28:05 UTC
Created attachment 148557 [details]
Screenshot of the exported document.
Comment 3 NISZ LibreOffice Team 2019-01-23 13:29:48 UTC
Created attachment 148558 [details]
Screenshot of the original document.
Comment 4 NISZ LibreOffice Team 2019-01-23 13:30:48 UTC
Created attachment 148559 [details]
The original odt containing a two-way arrow.
Comment 5 NISZ LibreOffice Team 2019-01-23 13:33:39 UTC
Created attachment 148561 [details]
The exported docx file.
Comment 6 raal 2019-01-23 14:01:50 UTC
Confirm with Version: 6.3.0.0.alpha0+
Build ID: 3fa4674615b747e219afe5bf0a9b689df3840439
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 

regression, works in LO 4.1
Comment 7 raal 2019-01-23 14:21:17 UTC
This seems to have begun at the below commit.
Adding Cc: to Miklos Vajna ; Could you possibly take a look at this one?
Thanks

c5acfdcd1ec0e9f15a8068f1c07cae15c9b52356 is the first bad commit
commit c5acfdcd1ec0e9f15a8068f1c07cae15c9b52356
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Wed May 27 18:55:55 2015 +0800

    source-hash-b1751e6ed0fd6d6d26141e4405df92520e3c04cd
    
    commit b1751e6ed0fd6d6d26141e4405df92520e3c04cd
    Author:     Andras Timar <andras.timar@collabora.com>
    AuthorDate: Thu Feb 5 22:36:24 2015 +0100
    Commit:     Miklos Vajna <vmiklos@collabora.co.uk>
    CommitDate: Fri Feb 6 09:37:36 2015 +0000
    
        bnc#637947 improve DrawingML export of custom shapes
    
        Change-Id: Iaa880528cf3c899ce66e4349c6d989dfbe5cbeb6
        Reviewed-on: https://gerrit.libreoffice.org/14346
        Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
        Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Comment 8 Miklos Vajna 2019-01-23 14:38:35 UTC
I'm happy to help Andras here, but please don't just CC
Comment 9 Miklos Vajna 2019-01-23 14:39:04 UTC
Eh. So please don't just CC me alone -- I've fixed that now. Thanks!
Comment 10 Regina Henschel 2019-04-07 18:14:06 UTC
The adjust handle is still missing in Version: 6.3.0.0.alpha0+ (x64)
Build ID: 287df6cf083a8ebeea8d64108a9e6d74cd834319
CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: de-DE (en_US); UI-Language: en-US
Calc: threaded
Comment 11 Regina Henschel 2019-04-07 18:21:35 UTC
*** Bug 123331 has been marked as a duplicate of this bug. ***
Comment 12 Miklos Vajna 2019-06-11 11:26:56 UTC
Quoting the above commit, the root cause here is:

> we cannot convert ODF equations to DrawingML equations

I.e. a missing feature, so regression -> implementation error.
Comment 13 Regina Henschel 2019-06-18 12:55:35 UTC
We do not need conversion from ODF equation to DrawingML in such cases. We can already roundtrip pptx -> odp -> pptx via "ooxml-foo" preset shapes and we can roundtrip odp -> ppt -> odp via binary preset shapes. So we need a converter from binary preset shapes to DrawingML preset shapes. Because path and handles are defined in the preset shape definition, it would be sufficient, to convert the adjustment values.

Sometimes it is only a conversion between unit-systems, sometimes (as for left-right-arrow) you need to convert between single handle and two handles.

The conversion from DrawingML preset to binary preset is missing too. That is bug 89853.

I thing, there exist 187 DrawingML preset shapes and 230 binary preset shapes. It would be doable without equation conversion, but it is a lot of work. And the conversion from ODF "non-promitive" to DrawingML "custGeom" would still be missing.