Bug 122998 - Move above checkboxes in Autofilter window
Summary: Move above checkboxes in Autofilter window
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
(earliest affected)
Hardware: All All
: medium enhancement
Assignee: Heiko Tietze
Whiteboard: target:6.3.0
Keywords: difficultyBeginner, easyHack, skillCpp
Depends on:
Blocks: AutoFilter
  Show dependency treegraph
Reported: 2019-01-27 16:37 UTC by Roman Kuznetsov
Modified: 2019-02-13 09:49 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

MockUP (17.65 KB, image/png)
2019-01-27 16:39 UTC, Roman Kuznetsov

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2019-01-27 16:37:37 UTC
Move above checkboxes in Autofilter window (see attach).
IMHO it will be better for general UX

Steps to Reproduce:
1. I suggest to move above checkboxes in Autofilter window (see attach)

Actual Results:

Expected Results:

Reproducible: Always

User Profile Reset: No

Additional Info:
Comment 1 Roman Kuznetsov 2019-01-27 16:39:49 UTC
Created attachment 148688 [details]
Comment 2 Heiko Tietze 2019-01-28 08:18:54 UTC
The typical place for parent checkboxes is above the children; this pattern is known from trees (ie. file manager). 

Somehow related is bug 118574 where I added a mockup with the checkboxes below to keep the search bar close to the list that is affected by the search. But the idea here is good anyway. So yes, please do it.
Comment 3 Mike Kaganski 2019-01-28 11:17:29 UTC
A code pointer: see ScCheckListMenuWindow::packWindow and ScCheckListMenuWindow::getSectionPosSize in sc/source/ui/cctrl/checklistmenu.cxx
Comment 4 Heiko Tietze 2019-02-12 09:40:50 UTC
Thanks for the code pointers. Patch is here https://gerrit.libreoffice.org/#/c/67712/
Comment 5 Commit Notification 2019-02-13 07:37:26 UTC
heiko tietze committed a patch related to this issue.
It has been pushed to "master":


Resolves tdf#122998 - Position of all/none checkboxes in Autofilter

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:

Affected users are encouraged to test the fix and report feedback.