Bug 123036 - Assert in customize menu add
Summary: Assert in customize menu add
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha0+
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Julien Nabet
URL:
Whiteboard: target:6.2.1 target:6.3.0
Keywords:
Depends on:
Blocks: Crash-Assert
  Show dependency treegraph
 
Reported: 2019-01-29 12:53 UTC by Regina Henschel
Modified: 2019-09-20 13:57 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Report by VS2017 (6.03 KB, text/plain)
2019-01-29 13:25 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2019-01-29 12:53:13 UTC
Start a new Writer document.
Goto Tools > Customize. Tab 'Menus'. Click on the button at the right side of the 'Target' field. Choose item 'Add'. You get a spinner and then LO crashes.

I see the problem in Version: 6.3.0.0.alpha0+ (x64)
Build ID: 4c8349f138f1269120180c663d82b534d60c1f73
CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: de-DE (en_US); UI-Language: en-US
Calc: threaded

I get no crash report.
Comment 1 Dieter 2019-01-29 13:00:55 UTC
Can't confirm with

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 411f3a050ac2be598019d512f8ccfe041080c28f
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-01-14_03:17:11
Locale: en-US (de_DE); UI-Language: en-US
Calc: threaded

I suppose, your version is a more recent master.
Comment 2 Regina Henschel 2019-01-29 13:25:53 UTC
Created attachment 148734 [details]
Report by VS2017

Yes, my version is newer.
Comment 3 Julien Nabet 2019-01-29 14:28:40 UTC
On Win7 with master sources updated today, I could reproduce this.
I noticed this on console:
Assertion failed: (rImage == "dialog-warning" || rImage == "dialog-error" || rImage == "dialog-information") && "unknown stock image", file C:/BLP/libo-core/vcl/source/app/salvtables.cxx, line 583
Comment 4 Julien Nabet 2019-01-29 14:51:07 UTC
This patch seems to fix this since I got no crash with it and dialog appears:
diff --git a/cui/source/customize/cfg.cxx b/cui/source/customize/cfg.cxx
index 406f89d4f7ac..c8b2e76af427 100644
--- a/cui/source/customize/cfg.cxx
+++ b/cui/source/customize/cfg.cxx
@@ -1934,7 +1934,7 @@ SvxMainMenuOrganizerDialog::SvxMainMenuOrganizerDialog(

         m_sNewMenuEntryId = OUString::number(reinterpret_cast<sal_uInt64>(pNewEntryData));
         m_xMenuListBox->append(m_sNewMenuEntryId,
-                               SvxConfigPageHelper::stripHotKey(pNewEntryData->GetName()), "");
+                               SvxConfigPageHelper::stripHotKey(pNewEntryData->GetName()));
         m_xMenuListBox->select(m_xMenuListBox->n_children() - 1);

         if (mpEntries)
Comment 5 Julien Nabet 2019-01-30 08:16:48 UTC
Patch on gerrit here:
https://gerrit.libreoffice.org/#/c/67104/

Caolán: as you may have seen, I put you on cc of the patch.
I think it was the last occurence of append method with final arg "" in this file.
Comment 6 Commit Notification 2019-01-30 12:43:17 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/1bb9126567becd881453da342315f139b4a564c9%5E%21

tdf#123036: fix assert in cfg.cxx (cui)

It will be available in 6.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2019-01-30 12:43:26 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/4ff272d90b62b591e344e6c4948495fee5208deb%5E%21

tdf#123036: fix assert in cfg.cxx (cui)

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.