Bug 123097 - Elements panel having formatting issues, missing glyphs
Summary: Elements panel having formatting issues, missing glyphs
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Formula Editor (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha0+
Hardware: All Windows (All)
: high normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2019-02-01 05:00 UTC by V Stuart Foote
Modified: 2019-02-01 10:26 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description V Stuart Foote 2019-02-01 05:00:34 UTC 
The Formula editor's Elements panel is presenting a single column of entries in several of the types:  Functions, Attributes, Brackets

Also, a number of glyphs for the element example are not rendering to the GUI, some from the Attributes (Large Vector, Large Tilde, Large Circumflex) and from Brackets (the Operator bracket) and all of the scalable brackets and braces.
Comment 1 V Stuart Foote 2019-02-01 05:29:34 UTC 
Nothing jumps out of a bibisect of on hand builds:

https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=b8e450a54936560cdac00ab4c70ef80c20cfaf99..6d70e04f66cbeb3aeeb1e9b69d5b201ae3d24747

But does coincide with Dmitriy's vcl/win scopeSelecteddHFONT and HBRUSH
Comment 2 Dmitriy Shilin 2019-02-01 06:01:46 UTC 
I am working on the patch [1] that should fix the regressions introduced by the 
scoped version of the GDI resources. I do not have enough knowledge to test if
your problem will be fixed via [1], but if you have time to checkout to my
commit and check I would very appreciate it.

1. https://gerrit.libreoffice.org/#/c/67187
Comment 3 Xisco Faulí 2019-02-01 06:41:15 UTC 
Regression introduced by: f00fc7ee17153ff70fa4fb2052a5b555af0c054c dmitriy shilin
https://cgit.freedesktop.org/libreoffice/core/commit/?id=f00fc7ee17153ff70fa4fb2052a5b555af0c054c

author  Dmitriy Shilin <dshil@fastmail.com>     2019-01-08 04:20:29 -0800
committer       Mike Kaganski <mike.kaganski@collabora.com>     2019-01-18
15:20:43 +0100
commit  f00fc7ee17153ff70fa4fb2052a5b555af0c054c (patch)
tree    a49f2b853a072303b43b04b49b9e93f75224003d
parent  8e50e218d26dfab1038570476e11d616f91d3768 (diff)
tdf#107792 vcl/win: introduce ScopedSelectedHFONT


Bisected with: bibisect-win32-6.3

Adding Cc: to Dmitriy Shilin
Comment 4 Xisco Faulí 2019-02-01 10:26:12 UTC 
Issue fixed by https://git.libreoffice.org/core/+/77c9bcb1af09d20a813cc3a16c50a57ab09eb0b5%5E%21.

Verified in

Version: 6.3.0.0.alpha0+
Build ID: 3839f155874213669c1b1c648879e8e3d36b2f43
CPU threads: 16; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: en-GB (en_GB); UI-Language: en-US
Calc: threaded

Closing as VERIFIED FIXED