Description: When creating and removing annotations as shown in /sw/qa/python/xtext.py, annotations can be removed twice without causing exceptions or any kind of warning. This seems to be a silent failure, but I don't know if there are any side effects of doing this. Steps to Reproduce: 1. Run the xtext unit test: 2. cd sw 3. make PythonTest_sw_python PYTHON_TEST_NAME="xtext" 4. The test completes successfully, even though it removes annotations twice. Actual Results: The test completes - unexpected success. Expected Results: The test as it is at the moment should fail in some way - throw an exception. I expected it to segfault, but it doesn't. Reproducible: Always User Profile Reset: No Additional Info: Throw an exception or issue some other kind of warning or error when an annotation that doesn't exist is removed.
Hello Hamish McIntyre-Bhatty, Thanks for reporting this issue. Would you mind sending an email to the mailing list for discussing this issue ? -> https://wiki.documentfoundation.org/Development/Mailing_List
I have sent an email.
Do you have a suggestion how to do this in a backwards-compatible way? Otherwise the change is probably not worth it.
No, I don't really have enough knowledge of the Libreoffice codebase to really have any idea what this might affect, or in what way :/. Is there any kind of unified set of documents I can read to better understand how everything gels together? Perhaps a warning could be logged - like a deprecation warning or similar, so we can figure out what this affects? If not fixed, maybe this should be documented somewhere though, because whoever wrote the unit test seemed surprised to discover that this happened? Hamish
(In reply to Miklos Vajna from comment #3) > Do you have a suggestion how to do this in a backwards-compatible way? > Otherwise the change is probably not worth it. Closing as RESOLVED WONTFIX