Description: File with lots of comments opens slower compared to 4.4.7.2 Steps to Reproduce: 1. Open attachment 144526 [details] (bug 119075) and monitor time to open Actual Results: 25 seconds Expected Results: 15 seconds with 4.4.7.2 Reproducible: Always User Profile Reset: No Additional Info: Version: 6.3.0.0.alpha0+ Build ID: 0b21f6556b6fff76290d1095089da89532365215 CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL
Slightly better with non-debug build (20 seconds) Version: 6.3.0.0.alpha0+ Build ID: e0745a11597e5d57eb8001a295314e86810a6027 CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-02-12_04:16:22 Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL
Thank you for reporting the bug. I can confirm the bug is present. It takes around 50 sec to open the file. Version: 6.3.0.0.alpha0+ Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04 Locale: en-US (en_US); UI-Language: en-US Calc: threaded
I got this result with win32-5.3: https://gerrit.libreoffice.org/plugins/gitiles/core/+/8f2dd1df1d6cc94ebbc1149de72bc6d6dffa6533%5E!/ Revert "Revert "Enable the new text layout engine by default"" It sounds plausible. As always, it is a bit hazy with these ones as sometimes there are multiple different times to open in the repo commits. I encourage others to bibisect as well. With perf issues, you should avoid doing any background processing while the measured task is going on.
Seems sensible.. I changed the TextLayoutEngine mode to OLD and it's fine: Tools -> Options -> Advanced: Expert Configuration search for "TextLayoutEngine" and edit to change "new|old" (only for LibO 5.3 range) It's maybe possible to narrow it down.. but would mean forcing TextLayoutEngine on when it's off.. there was some command for it.. The Advanced: Expert Configuration is only added at the end, not really helpful..
Created attachment 149366 [details] Callgrind output from master On Windows you can use set SAL_USE_COMMON_LAYOUT=1 to activate it or set SAL_USE_COMMON_LAYOUT= to remove the env variable. Arch Linux 64-bit Version: 6.3.0.0.alpha0+ Build ID: e77beebb0d839f5dc0d4f9c4fd7cc9b7ccfd0175 CPU threads: 8; OS: Linux 4.20; UI render: default; VCL: gtk3; Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US Calc: threaded Built on 16 February 2019
i doubt anything around comments is 'fine', you have about 6k long comments in the sheet, up from 200 you get measureable cpu load, up from 10k drastic delays and freezes - depends on system and version of course - , see #76324 and plenty subsequent reports reg. 'calc' and 'slow', there is! big performance impact by too many comments, it looks to be very difficult, otherwise someone would have fixed it in the past 5 years ...
Created attachment 153291 [details] Flamegraph
Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Still present Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 36efb384a66b6dd645e0ae80fd7df68370a9dc8b CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
@Noel, You might be interested in this one, based on you're history of optimizations...
Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
On current master, it loads in 6.5 seconds on my machine. Assuming that my machine is very very fast (which it is), I am guessing it will load at closer to 12 or 15 seconds on a "normal" machine, which means this is fixed.