Created attachment 149239 [details] Calc vs Excel Screenshot In recent builds, MSO Icon colors are imported with the wrong color. Steps to reproduce. 1. Create a MSO doc with icons such as See attachment 119382 [details] 2. Open in LO Expected results: 1. Yellow stars Actual results 1. Blue stars Version: 6.3.0.0.alpha0+ Build ID: 6e8c9bdf0a55141d3cbd181862aec89b788bb060 TinderBox: Win-x86@42, Branch:master, Time: 2019-02-11_05:52:33 Bad master~2019-02-09_22.11.09_LibreOfficeDev_6.3.0.0 Good
Created attachment 149240 [details] XLSX with multiple icons A more complex example showing how nearly all colors are wrong.
(In reply to Luke from comment #0) > Version: 6.3.0.0.alpha0+ Build ID: 6e8c9bdf0a55141d3cbd181862aec89b788bb060 > TinderBox: Win-x86@42, Branch:master, Time: 2019-02-11_05:52:33 > Bad Win only ? I can't reproduce it with the same commit on linux Version: 6.3.0.0.alpha0+ Build ID: 6e8c9bdf0a55141d3cbd181862aec89b788bb060 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded
Created attachment 149244 [details] Start Center icons are also the wrong color
mmm, that's weird... I can't reproduce it in Version: 6.3.0.0.alpha0+ Build ID: f22ce685260b8b7b792f1f132472c88c6b655589 CPU threads: 16; OS: Windows 6.3; UI render: default; VCL: win; Locale: en-GB (en_GB); UI-Language: en-US Calc: threaded OpenGL enabled? did you try with a clean profile ?
I can reproduce the error with Version: 6.3.0.0.alpha0+ (x64) Build ID: 7c304fa6a99d1c30cf1bc6774612d96b382041d8 CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: threaded If I use the icon-theme "Colibre" or "Automatic(Colibre)" blue and yellow are exchanged. The icon-theme "Colibre (SVG)" is shown correctly.
As the problem is not only visible in document graphics but also the UI, I’m changing this bug’s component. @Xisco: attachment 149244 [details] dues show Luke is testing with GL rendering enabled. (We could just add his graphics card to the blacklist.)
@Adolfo GPU is Intel HD 5000 with latest Win 10 drivers. If that has to be blacklisted, we're probably doing something wrong.
Regression confirmed on Windows 10 Home en-US 1809 with Intel HD Graphics 620 (25.20.100.6471) and build Version: 6.3.0.0.alpha0+ (x64) Build ID: e0745a11597e5d57eb8001a295314e86810a6027 CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-02-12_02:44:15 Locale: en-US (en_US); UI-Language: en-US Calc: threaded Same system and drivers with 2019-02-06 build has correct colors in start center. Version: 6.3.0.0.alpha0+ Build ID: 82fb7f9f90a3ba9d53b3412124e513aa78ddca10 CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: threaded
Bisected this regression to: https://cgit.freedesktop.org/libreoffice/core/commit/?id=bec35535b4cb784800a79cd315b4f761d0a6758e Use PngImageReader for loading the icons from the icon-themes Tomaž, Could you take a look at this?
Damn RGB and BGR on different environments
Tomaž Vajngerl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/0ac4425e1c0c6b5c55933307929fc8d37a927b2c%5E%21 tdf#123420 Fix RGB/BGR issue with PNG reader It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Tomaž, Did you test your patch on Windows? I'm now seeing a crash within seconds of starting up LO. I haven't bisected it yet, but it started right after your patch.
*** Bug 123525 has been marked as a duplicate of this bug. ***
Confirmed fixed on Windows 10 Home 64-bit en-US (1809) with Version: 6.3.0.0.alpha0+ (x64) Build ID: 9712dd74bfb0c9b99cab37bd147fe267b48c6d7d CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-02-17_22:47:09 Locale: en-US (en_US); UI-Language: en-US Calc: threaded
Dennis Francis committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/ea5f1ec4eec4aa609000223aea1bc9ce202de2c5%5E%21 crashtesting: crash on importing tdf#123420-2.xlsx It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.