Bug 123505 - Grey menus after closing macro warning dialog (w/ OpenGL only)
Summary: Grey menus after closing macro warning dialog (w/ OpenGL only)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha0+
Hardware: All All
: medium major
Assignee: Miklos Vajna
URL:
Whiteboard: target:6.3.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Regressions-ViewToDevice-Refactor VCL-OpenGL
  Show dependency tree / graph
 
Reported: 2019-02-17 00:00 UTC by Aron Budea
Modified: 2019-10-30 16:56 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:

Attachments
Reproducer document. (3.61 KB, application/vnd.oasis.opendocument.spreadsheet-flat-xml)
2019-03-25 16:31 UTC, Miklos Vajna 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2019-02-17 00:00:49 UTC 
Enable OpenGL rendering, and reset Macro Security to Very High (just so no macros are run).

- Open attachment 121786 [details] (bug 96952), close the dialog.
- Open any main menu.

=> Menus, dialogs are empty grey blocks.

Observed using LO 6.3.0.0.alpha0+ (eef8c4952da288629f9aad23f75d6f894eba83b4) / Windows 7.
No issue in LO 6.2.0.3.
=> regression

Bibisected to the following commit using repo bibisect-win32-6.3, same commit as in bug 122713 and in bug 121963, but different symptom. Adding Cc: to Armin Le Grand, please take a look.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=d464d505fbf6e53a38afdd3661d320fac8c760d6
author		Armin Le Grand <Armin.Le.Grand@cib.de>	2018-10-12 11:13:09 +0200
committer	Armin Le Grand <Armin.Le.Grand@cib.de>	2018-11-27 11:33:10 +0100

Refactor calc non-linear ViewToDevice transform
Comment 1 m_a_riosv 2019-02-17 09:16:35 UTC 
No issue for me.
Version: 6.3.0.0.alpha0+ (x64)
Build ID: e0745a11597e5d57eb8001a295314e86810a6027
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-02-12_02:44:15
Locale: es-ES (es_ES); UI-Language: en-US
Calc: threaded
Comment 2 Telesto 2019-02-17 15:39:30 UTC 
Repro
Version: 6.3.0.0.alpha0+
Build ID: e0745a11597e5d57eb8001a295314e86810a6027
CPU threads: 4; OS: Windows 6.3; UI render: GL; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-02-12_04:16:22
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL
Comment 3 Miklos Vajna 2019-03-25 13:15:52 UTC 
I'll take a look at this, let's see if I get anywhere. Seems to be GL-specific.
Comment 4 Miklos Vajna 2019-03-25 16:31:39 UTC 
Created attachment 150274 [details]
Reproducer document.

I attach a minimal reproducer. The point is that the form control's size changes constantly (between 952 and 953 units), which causes an invalidation loop. This starves the GL rendering task that would pain the menus.
Comment 5 Commit Notification 2019-03-27 15:09:02 UTC 
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/5b51aa12e8ebfa894ecfdd0c8c9004aa99e6f46d%5E%21

tdf#123505 svx: fix invalidation loop caused by special form control geometry

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Miklos Vajna 2019-03-27 15:10:36 UTC 
Problem was master-only so no backport is needed.
Comment 7 Aron Budea 2019-04-12 22:33:59 UTC 
Verified fixed, thanks Miklos!

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 3fe3bd8a90d6dc53b05b9236185af3916fc5375d
CPU threads: 16; OS: Windows 6.1; UI render: GL; VCL: win; 
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc: CL