Bug Hunting Session
Bug 123513 - Using 0 to add in Optimal Column Width dialog makes width too narrow
Summary: Using 0 to add in Optimal Column Width dialog makes width too narrow
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.1.4.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2019-02-17 09:40 UTC by Mike Kaganski
Modified: 2019-02-17 13:08 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
A sample that shows ### in A2 when optimal-sized with no added width (7.36 KB, application/vnd.oasis.opendocument.spreadsheet)
2019-02-17 09:40 UTC, Mike Kaganski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2019-02-17 09:40:16 UTC
Created attachment 149339 [details]
A sample that shows ### in A2 when optimal-sized with no added width

If I try to set Optimal Column Width in Calc, and set Add to 0 in the dialog, some columns may become too narrow (that is, displaying ### in some cells).

1. Create a new spreadsheet (without any templates, as using File->New->Spreadsheet just after a profile reset). The default cell font is Liberation Sans 10.
2. Put 1, 2, 3, 4 to A1, B1, C1, D1.
3. Select columns A:D, and Format->Columns->Optimal Width...
4. Put 0 to Add:, and confirm.
=> see that the 4 columns are narrow (0.30 mm), and all 4 numbers displayed OK.
5. Put 11, 12, 13, 14 to A2, B2, C2, D2.
6. Repeat steps 3-4.
=> See that now columns are wider: A is 0.46 mm, others are 0.49 mm; and A2 shows ### instead of 11.

Tested with Version: 6.3.0.0.alpha0+ (x64)
Build ID: 177747c44557489760cc00473daecacd99995427
CPU threads: 12; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded

and with Version: 6.2.1.1 (x64)
Build ID: 757c58e8cb70b2982843211a54750fb3cd79acd5
CPU threads: 12; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded

Attached is a spreadsheet created as indicated (but the Optimal Width isn't applied yet), to allow testing this, without possible problems with default templates or different defaults on different versions/OSes/locales.
Comment 1 Oliver Brinzing 2019-02-17 12:42:55 UTC
confirming with:

Version: 6.1.4.2 (x64)
Version: 6.1.5.2 (x64)
Build ID: 90f8dcf33c87b3705e78202e3df5142b201bd805
CPU threads: 4; OS: Windows 10.0; UI render: default; 
Locale: de-DE (de_DE); Calc: 

A = 0,44, B-D = 0,47
column A displays ###

and with 
Version: 5.4.7.2 (x64)
Version: 6.0.7.3 (x64)

A = 0,44, B-D = 0,47
but all numbers are visible

and with AOO 4.1.5:
A-D = 0,5
Comment 2 Oliver Brinzing 2019-02-17 13:08:49 UTC
seems to have started with:

commit	36eed54d3dfed6551fd2ad944feff7e217c56e82 [log]
author	Eike Rathke <erack@redhat.com>	 Tue Jul 03 15:00:26 2018 +0200
committer Eike Rathke <erack@redhat.com> Tue Jul 03 17:12:33 2018 +0200
tree	8db66cec37a3532157442bd256ab8c9fb24d806c
parent	fb84f580025503673ba45684b7c18c41b27c2a06 [diff]

Resolves: tdf#118221 whole cell kerning default is off
So set that at OutputDevice, there is no cell attribute for
kerning, all kerning on is handled by EditEngine output.

https://gerrit.libreoffice.org/plugins/gitiles/core/+/36eed54d3dfed6551fd2ad944feff7e217c56e82

$ git bisect log
# bad: [d60ae8383378fcecc7ab077670bf45208a214c71] source sha:e45c30858dec1dd705b9144fab981a3c8819ba96
# good: [b0a56ec98b1368cb5e3e531e0b3f69565af91609] source sha:3a801799536e6870f2fb111b1cc00b9575a35a39
git bisect start 'master' 'oldest'
# bad: [5180a3b7a5dc530ad7ec5bd6e5cefecf85beab7e] source sha:8bcc4a98d78869d6839821b9747602777f00ebaf
git bisect bad 5180a3b7a5dc530ad7ec5bd6e5cefecf85beab7e
# bad: [5180a3b7a5dc530ad7ec5bd6e5cefecf85beab7e] source sha:8bcc4a98d78869d6839821b9747602777f00ebaf
git bisect bad 5180a3b7a5dc530ad7ec5bd6e5cefecf85beab7e
# bad: [c0ac0d5f5cb9fff4196b80799bd6629b5ad0d33e] source sha:eedeeb63d1287ed0416e1fe3d2f7ba37632626d0
git bisect bad c0ac0d5f5cb9fff4196b80799bd6629b5ad0d33e
# good: [0ad8f16fccf8d53b0bf6abb0490e8f22b9c60cec] source sha:2927c7785d6bf6cef3f4bcc0bc3e463ac6a55b01
git bisect good 0ad8f16fccf8d53b0bf6abb0490e8f22b9c60cec
# good: [657ea27ce49e4cd42f3cb3e52974b2e0d1c28bac] source sha:5be0637827cd987b7b7dda7ca2c54a3548d9ef51
git bisect good 657ea27ce49e4cd42f3cb3e52974b2e0d1c28bac
# good: [bb911bf281ec3f7b0d442aa045a2d8b3a7123ce5] source sha:4c475bc6763e29f7af2caadc7add42d26e1d6f75
git bisect good bb911bf281ec3f7b0d442aa045a2d8b3a7123ce5
# bad: [eaf69fa4daddc66548d9d6a72ced19ec270c535a] source sha:7b101fc549593e2ad8c54f4e53d23fcdf683a4bb
git bisect bad eaf69fa4daddc66548d9d6a72ced19ec270c535a
# bad: [0d548816c730e540e91687d54916160b8522955d] source sha:38733c7daab85793a8d88c58808f8e35d3d25887
git bisect bad 0d548816c730e540e91687d54916160b8522955d
# good: [ed8c4759d24442760e0e72562598a7dfae8903cb] source sha:e3ac0b04324b32a58c6ce94b413de3c3ea2fa9e0
git bisect good ed8c4759d24442760e0e72562598a7dfae8903cb
# bad: [5455f27fc7b6581b1b99e1aae134fc4f27110f9e] source sha:d503b5d50b22fe376d74aadbe518bc616299a019
git bisect bad 5455f27fc7b6581b1b99e1aae134fc4f27110f9e
# good: [602a0e8d82058f08171305a1f74f59467f286926] source sha:11efed740ef5fb96485fe007639f9a0df2b2c28e
git bisect good 602a0e8d82058f08171305a1f74f59467f286926
# bad: [0139b1ba7525d60950fc825a827ba288e7307a2d] source sha:36eed54d3dfed6551fd2ad944feff7e217c56e82
git bisect bad 0139b1ba7525d60950fc825a827ba288e7307a2d
# good: [0b9e0867dba8b303aa4a445fd04bc22b19a8e9e2] source sha:fb84f580025503673ba45684b7c18c41b27c2a06
git bisect good 0b9e0867dba8b303aa4a445fd04bc22b19a8e9e2
# first bad commit: [0139b1ba7525d60950fc825a827ba288e7307a2d] source sha:36eed54d3dfed6551fd2ad944feff7e217c56e82