Bug Hunting Session
Bug 123565 - I Want an Acoustic plus an Optical Signal when Wrap Around happens when Searching or Searching and Replacing
Summary: I Want an Acoustic plus an Optical Signal when Wrap Around happens when Searc...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Find-Search
  Show dependency treegraph
 
Reported: 2019-02-19 08:52 UTC by Adalbert Hanßen
Modified: 2019-02-22 10:25 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adalbert Hanßen 2019-02-19 08:52:17 UTC
Description:
When searching for a keyword (or using the search/replace dialogue) it happens that you repeatedly click on the either the search forward or the search backward button. In version 6.3.0.0.alpha0+ the bug has been fixed that the respective search buttons are shifted up and down if a found instance happens to be part of a table. (resolved bug 120739).

Still using this feature, it may happen that search wraps around the end (or beginning) of the file. When one repeatedly searches for the same search item, wrapping around the end of the file may go unnoticed since the focus of the user is on the found items and not on the elevator bar at the richt margin of the window.

Therefore it is advisable to signal crossing the end or beginning in a search or in a search/replace action. Probably the easiest thing to do is to add a sound. However, in many Xubuntu installations system sounds do not work properly. In addition, working in an environment with many others, switching off all acoustic noise from a computer is often necessary. Therefore, an additional optical signalling of having passed the end of file (in either direction) is desirable. 

This could be done e.g. by altering the screen background in LO's window, e.g. by lowering or by increasing it by 5% in all three channels R, G and B or by 15% in one channel only for say 1/4 to 1/2 second. Changing the background only this much avoids problems for people suffering from epilepsy which might suffer from flickering like switching to inverted for say 1/10 second or less.

Another possible way of signalling having passed the end (or beginning) of the file would be to use another background colour when highlighting the found instance of the search, e.g. doubling the intensity of the background used for that purpose or making the border of it more prominent. 

Steps to Reproduce:
1.create a file which contains many instance of a keyword for which you search in the next step
2.repeatedly search for a keyword and observe the environment of the found items, repeatedly click on the search down button or the search up button
3.eventually wrapping around the file's end happens

Actual Results:
3. often this goes unnoticed because user's focus is on what is the environment of the surroundings of the found places. His/her focus is not on the elevator bar indicating the position in the whole file.

Expected Results:
3. an acoustic signal plus some optical signal indicating that wrap around has happened. We need both of them, because in many instances all system sounds are switched off.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
There was a bug that the buttons search forward and search backward changed their place on the screen depending on whether the found places is in a table or not, see https://bugs.documentfoundation.org/show_bug.cgi?id=120739. But alerting the user of a wrap around is a different thing, therefore this separate call for an enhancement.
Comment 1 Jim Raykowski 2019-02-20 07:56:45 UTC
Hi Adalbert,

Notification of search wrapping is given in the find bar on the right in the [placeholder for message] area and in the Find & Replace dialog below the Match case and Whole words only check boxes.

The messages shown for text searches are "Reached the beginning of the document", "Reached the end of the document" and "Search key not found". For Navigate By element searches the messages show are "Reached the beginning of the document, continued from the end", "Reached the end of the document, continued from the beginning" and "Navigation Element not found"

IMHO, acoustic and animated signaling of these would be an improvement. Let's see what the UX team thinks.
Comment 2 Thomas Lendo 2019-02-20 21:30:29 UTC
Acoustic signals are a no-go for me. In an office with several people nobody wants to hear beeps all the day.

Also playing around with colors or background brightness is not a good solution. We should not change LibO's appearance to transport an information to the user.

In older days, a warning window popped up that informed the user that the end of file was reached - which is a horrible UX in my eyes. Better no indication than a workflow disruptive solution. I can see if I'm starting from the file beginning again when watching the scroll bar.
Comment 3 Heiko Tietze 2019-02-21 10:06:24 UTC
We discussed the proposal in the design meeting. So far LibreOffice has no acoustic notification and we don't recommend to introduce that option. But if it's possible to use the system configuration it could be supportive. Jim, do you want to check this? Not sure if we find a cross-platform solution.

About the second idea, we don't recommend to introduce flashing animations or very specific behavior. However, making the text bold is an option.
Comment 4 Jim Raykowski 2019-02-22 02:29:26 UTC
An acoustic signal would of course be an opt in setting. Impress can play audio media so it might be possible to use in Writer.

I like how Kate and Qt Creator display a toast on search wrapping.

IMHO what we have now is adequate but these seem like they would be nice enhancements.
Comment 5 Heiko Tietze 2019-02-22 07:48:48 UTC
(In reply to Jim Raykowski from comment #4)
> I like how Kate and Qt Creator display a toast on search wrapping.

We should avoid another bunch of options likely with non-familiar signals and trigger the inbuilt sound theme - crossplatform. Don't see any option in Kate (and don't get a beep, just the overlay in the middle of the canvas).