Bug 123765 - Screenshot: Little or no usage in the current implementation
Summary: Screenshot: Little or no usage in the current implementation
Status: RESOLVED INSUFFICIENTDATA
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: framework (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha0+
Hardware: All All
: high normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.4.0
Keywords:
Depends on:
Blocks: Screenshot
  Show dependency treegraph
 
Reported: 2019-02-28 14:03 UTC by Olivier Hallot
Modified: 2021-01-30 04:17 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
cui/.../formatcelldialog screenshot (2.43 KB, image/png)
2019-02-28 14:03 UTC, Olivier Hallot
Details
TextDialog screenshot (2.35 KB, image/png)
2019-02-28 14:04 UTC, Olivier Hallot
Details
Issue with Master 6.4 (12.71 KB, image/png)
2019-06-07 15:50 UTC, Olivier Hallot
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Hallot 2019-02-28 14:03:19 UTC
Created attachment 149656 [details]
cui/.../formatcelldialog screenshot

Using command

cd cui/

make screenshots

results in screenshots with little or no usage. In particular, dialogs that contains tabs are taken with the tab collapsed only with standard buttons Help, OK, Cancel.

For example, the dialog
workdir/screenshots/cui/ui/formatcellsdialog 
produces the image attached

Another example is the dialog
workdir/screenshots/cui/ui/textdialog
produces the second image attached.

The issue also occurs in some modules such as sw and sc.
Comment 1 Olivier Hallot 2019-02-28 14:04:03 UTC
Created attachment 149657 [details]
TextDialog screenshot
Comment 2 Xisco Faulí 2019-04-02 10:47:01 UTC
I guess this is happening because those dialogs are filled at run time, thus, they are empty at compile time
@bubli, is there anything we can do here ?
Comment 3 Xisco Faulí 2019-05-07 08:24:13 UTC
Hi Olivier,
As long as the screenshots are created at build time, I guess there isn't much we can do here...
closing as RESOLVED WONTFIX.
Please, put it back to UNCONFIRMED if you disagree and a better option can be implemented
Comment 4 Olivier Hallot 2019-05-07 12:25:19 UTC
(In reply to Xisco Faulí from comment #3)
> Hi Olivier,
> As long as the screenshots are created at build time, I guess there isn't
> much we can do here...
> closing as RESOLVED WONTFIX.
> Please, put it back to UNCONFIRMED if you disagree and a better option can
> be implemented

The screenshots were working when delivered by the contractor. Later, changes in dialogs structure broke the screenshots.

Turning to UNCONFIRMED
Comment 5 Olivier Hallot 2019-05-07 12:26:09 UTC
It worth to note that the issue prevents using the screenshots is localized documentation, such as the Help system
Comment 6 Olivier Hallot 2019-06-07 15:50:09 UTC
Created attachment 152033 [details]
Issue with Master 6.4

This screenshot was taken with command

cd cui/
SAL_USE_VCLPLUGIN=gtk3 make screenshot

Issue persist.
Comment 7 Buovjaga 2019-08-25 16:00:29 UTC
Let's just set to NEW and bump priority due to this being an important thing
Comment 8 Caolán McNamara 2019-10-08 16:00:07 UTC
I suspect cui/.../formatcelldialog never worked, but that the sc/.../formatcellsdialog used to work and has come unstuck

https://gerrit.libreoffice.org/#/c/80488/ fixes the calc formatcellsdialog and then additionally makes the two mentioned dialogs in cui specifically mentioned here work as well and can act as a guide for supporting any extra dialogs that have multiple tabs which are filled in at run time
Comment 9 Commit Notification 2019-10-09 11:16:48 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/dc78b82db539401cc7e63d96f4727e1e884b86cb

Related: tdf#123765 fix up some screenshotting

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Xisco Faulí 2019-12-03 10:55:00 UTC
Hi Olivier,
Is this issue fixed or are there still dialogs which are failing? If so, could you please mention a couple?
Comment 11 QA Administrators 2020-12-30 03:39:32 UTC Comment hidden (obsolete)
Comment 12 QA Administrators 2021-01-30 04:17:51 UTC
Dear Olivier Hallot,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp