We use clang-format to have consistent formatting on a number of files already. Although most files are currently blacklisted for formatting by 'solenv/clang-format/blacklist'. The task is to find files where enabling clang-format would only cause minor reformatting (maybe less than 5% of the lines on a file). Then this file should be removed from 'solenv/clang-format/blacklist' and be formatted with clang-format. Ideally a (Python/Shell/...) script will be written which does this check for all files. But manually checking is also ok. Please submit suitable files one by one to Gerrit to allow individual review.
Hello, I would like to work on it, can I get some code pointers, as I am new to open source contribution but have a fair amount of interest towards contributing to this project and work on this issue. should I lear
should I get familiar with any other languages as I already have knowledge of python which is mentioned in keywords?
(In reply to Raghu Ram from comment #1) > Hello, I would like to work on it, can I get some code pointers, as I am new > to open source contribution but have a fair amount of interest towards > contributing to this project and work on this issue. > > should I lear Hi Raghu, what kind of information do you need? The task is written in comment 0. Please come to the irc channel #libreoffice-dev if you have general questions.
Hi, I would like to take up this bug. Can you just tell me from where can I access the solenv/clang-format/blacklist file? Or do I just have to write a Python script which given a list of files outputs the list which has less than 5% of lines to be reformatted to be clang-formatted?
(In reply to Anuj Agrawal from comment #4) > Hi, > I would like to take up this bug. Can you just tell me from where can I > access the solenv/clang-format/blacklist file? > Or do I just have to write a Python script which given a list of files > outputs the list which has less than 5% of lines to be reformatted to be > clang-formatted? The blacklist file is part of our "core" repo. You need a LibreOffice build setup to do this task. Please see https://wiki.documentfoundation.org/Development/GetInvolved and ask further questions about the setup on IRC.
@Anuj: Raghu is currently working on this bug, so please choose another one.
As the patch has not seen any progress since 2 months, I mark this issue as unassigned. Anyone can continue the work started here: https://gerrit.libreoffice.org/#/c/69589/
But note that unconditional application of clang-format will, in general, break the meaning of comments. Consider code like LooooooongType1 looooooongVarName1; // lengthy comment about some detail LooooooongType2 looooooongVarName2; where the comment pertains to the preceding line, but needs to go on a new line due to line length limitations, and is indented to make that clear. It will get reformatted as LooooooongType1 looooooongVarName1; // lengthy comment about some detail LooooooongType2 looooooongVarName2; making it less obvious whether the comment pertains to the preceding or to the following line.
Batuhan Taskaya committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/09680b09b2f49e7a37d8b941822f053b5179bf6d tdf#123936: bin/find-clang-format.py for finding files to be formatted It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Batuhan Taskaya committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/958c35bf761cfc05dfd9a2557ed30d5b1457c3ba tdf#123936: remove non-existent files from blacklist It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Dear Batuhan Taskaya, This bug has been in ASSIGNED status for more than 3 months without any activity. Resetting it to NEW. Please assign it back to yourself if you're still working on this.
Working on it.
I wrote a python script which calculates a similarity score between the original file and the clang-formatted files. During this process I found ~250 files which are listed in 'solenv/clang-format/excludelist' but do not exist (anymore). Furthermore, ~2.500 (out of 18.434) files have a similarity score of >0.99; mostly missing spaces and really small modifications. I think we should start by removing the files from 'excludelist' which don't exist anymore and update the ~2.500 files which do not change much after formatting it with clang. In the first post you mentioned "Please submit suitable files one by one to Gerrit to allow individual review.". Although I've worked extensively with git in the past, it's my first time with Gerrit -- how do you expect my results?
Careful with needinfo status: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO
(In reply to philipp.hofer from comment #13) > I wrote a python script which calculates a similarity score between the > original file and the clang-formatted files. > During this process I found ~250 files which are listed in > 'solenv/clang-format/excludelist' but do not exist (anymore). Furthermore, > ~2.500 (out of 18.434) files have a similarity score of >0.99; mostly > missing spaces and really small modifications. > > I think we should start by removing the files from 'excludelist' which don't > exist anymore and update the ~2.500 files which do not change much after > formatting it with clang. Sounds good. > > In the first post you mentioned "Please submit suitable files one by one to > Gerrit to allow individual review.". Although I've worked extensively with > git in the past, it's my first time with Gerrit -- how do you expect my > results? Please submit * one patch (commit) for removing non-existant files from excludelist * one patch per module for formatting the similiar files with clang-format (module == top-level directory like dbaccess, sw, sc, ...)
I submitted two patches so far: 1) one patch (commit) for removing non-existant files from excludelist (https://gerrit.libreoffice.org/c/core/+/105407/1) 2) one patch for module accessibility for formatting the similar files with clang-format (https://gerrit.libreoffice.org/c/core/+/105411) I'm waiting for feedback for 2) before I create 103 more patches (for the other modules).
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e54c3b962e89689b34f96c717de730c8f1077b0f tdf#123936 Remove nonexisting files from excludelist. It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b53fa6344d033f8b8f03b9274dbdd811251c2c1a tdf#123936 Formatting file in module accessibility with clang It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e05af8af958c9caa4bb7a4f6d8600ddf0a22c54b tdf#123936 Formatting files in module avmedia with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/80139bf7977d2e78e3c619956813893f5933f929 tdf#123936 Formatting files in module emfio with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4391c275df68b409a9bf7295934350bffd1abc00 tdf#123936 Formatting files in module drawinglayer with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2c771b7b79a206987241b595712b9026fdcb5e89 tdf#123936 Formatting files in module embeddedobj with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9b88f814309ddf73f92327d526b1e43c813c1de1 tdf#123936 Formatting files in module i18nlangtag with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6ef7a95285f4684113ee8d4e06eada8794f4daac tdf#123936 Formatting files in module jvmaccess with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/dd6e0ab30a120512e39f0d9b2e422243deae7b5f tdf#123936 Formatting files in module jurt with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/635bc2ea81fd9493a2997e89c2de5aa7d8405578 tdf#123936 Formatting files in module l10ntools with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f0126ffa6469d6c43f04596cb6f5ca83919ef8fc tdf#123936 Formatting files in module lingucomponent with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0d3fb848a2995a0869c4c5fa8916214a513865ac tdf#123936 Formatting files in module linguistic with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to philipp.hofer from comment #16) > I'm waiting for feedback for 2) before I create 103 more patches (for the > other modules). Please don't submit that many patches in large batches. It fills up the CI queue, and makes others' work impossible for days. Sending say 3 patches, and waiting them to be finished before sending the next set, is OK, but not 103. (In reply to philipp.hofer from comment #13) > I wrote a python script which calculates a similarity score between the > original file and the clang-formatted files. Please describe how the similarity is measured in the script (or maybe create a gerrit change with the script). That would help answer e.g. the question Stephan asked in https://gerrit.libreoffice.org/c/core/+/105655: > How do you calculate the threshold which files to modify? For example in > configmgr/source/defaultprovider.hxx, affecting 5 out of 35 existing lines > is clearly beyond a 5% line limit?
And we maybe should allow changes that may affect more than 5%, but allow using our .git-blame-ignore-revs to reduce the blame noise. (Then the task would be to amend the list there.)
> Please submit suitable files one by one to Gerrit to allow individual review But please don't have any more than around ten outstanding changes for this bug in Gerrit at any time. Don't submit a hundred such minimal changes. Sadly the Gerrit and Jenkins (never fully understood what to call it) infrastructure apparently has no mechanism to prioritise work based on "importance". I think we can all agree that this "bug" that is about cosmetic changes is less important than bugs that are about actual erroneous behaviour in the software, or functionality enhancements, right?
(In reply to Mike Kaganski from comment #29) > (In reply to philipp.hofer from comment #16) > > I'm waiting for feedback for 2) before I create 103 more patches (for the > > other modules). > > Please don't submit that many patches in large batches. It fills up the CI > queue, and makes others' work impossible for days. > > Sending say 3 patches, and waiting them to be finished before sending the > next set, is OK, but not 103. > > (In reply to philipp.hofer from comment #13) > > I wrote a python script which calculates a similarity score between the > > original file and the clang-formatted files. > > Please describe how the similarity is measured in the script (or maybe > create a gerrit change with the script). That would help answer e.g. the > question Stephan asked in https://gerrit.libreoffice.org/c/core/+/105655: > > > How do you calculate the threshold which files to modify? For example in > > configmgr/source/defaultprovider.hxx, affecting 5 out of 35 existing lines > > is clearly beyond a 5% line limit? Sorry for causing inconvenience, was definitely not my plan. I will only submit a few patches from now on. How do we continue in this particular situation with having so many patches? I used Python's difflib.SequenceMatcher and changed all files with > 99% similarity.
(In reply to philipp.hofer from comment #32) > Sorry for causing inconvenience, was definitely not my plan. I will only > submit a few patches from now on. How do we continue in this particular > situation with having so many patches? Np, here was no warnings/precautions here to let know how to avoid that, so it's not your fault. For the changes that were aborted in Jenkins, please wait next week, and then *rebase* 2 or three of them to be built.
A simple solution to avoiding "spamming" the bots with too many build verification results, is to upload your individual changes as drafts/WIP, those are ignored by the gerrit-trigger in jenkins. And for build-testing, create a *single* commit where you have multiple of the easy-to-handle smaller-chunks combined. e.g. cherry pick 10 or so for verification, and git rebase -i them and use squash option to combine them into a single commit.
(In reply to Christian Lohmaier from comment #34) > A simple solution to avoiding "spamming" the bots with too many build > verification results, is to upload your individual changes as drafts/WIP, > those are ignored by the gerrit-trigger in jenkins. https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch#Submitting_patches_as_private_or_work-in-progress ./logerrit submit-wip master
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/26573395db55ddbd56d4dde39c8d5e5306c7a6ce tdf#123936 Formatting files in module ios with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0eaf2092940dc604926d31ef11b6ffb07abedc5a tdf#123936 Formatting files in module basegfx with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/16389aae367ebfa8ce19f8ee1c26232fec7ff729 tdf#123936 Formatting files in module basic with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6da61d5fa731fc34dc27607b6dc02b91928e4a54 tdf#123936 Formatting files in module basctl with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/79368f81028a05f1d3685f0052806d3f93cd2da8 tdf#123936 Formatting files in module bridges with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d66683f86a719b9961a076237aba07d6b4fea359 tdf#123936 Formatting files in module comphelper with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ec35fc62993111e4e7dd917e7dbc91ef82b02f74 tdf#123936 Formatting files in module cui with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/31fbd2be47819796eb6e7c23a8fc23925004abd6 tdf#123936 Formatting files in module binaryurp with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a079d78439cd371dd270fb5a1de125d5de9cf472 tdf#123936 Formatting files in module codemaker with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/71b69ac75b623fc2f36c5c1a0ba632152aa101b8 tdf#123936 Formatting files in module connectivity with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7ebd82e885b60552464e060236e869162fcadc71 tdf#123936 Formatting files in module cli_ure with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/fddcbd5d28bb58993ee3d210f1d11e57c70a8894 tdf#123936 Formatting files in module cppu with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/eedafe6e5c1c1f598170e6349c29ed19437d1f8c tdf#123936 Formatting files in module desktop with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5035f265cd6e19ef3589db55ca0b780944812365 tdf#123936 Formatting files in module embedserv with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/32b57a159ea6ab3b0cdef7ca9d746639d42aa192 tdf#123936 Formatting files in module editeng with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/951764106e2d82fc59dcf39e14bc17838856a00c tdf#123936 Formatting files in module forms with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/49494bb703107835f83671d9272a0326feec8bb4 tdf#123936 Formatting files in module framework with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4d9e9f2125867adde3558b9866d08f7bafb4386b tdf#123936 Formatting files in module fpicker with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/11aa7dc7a6009c02e681f41f7255902fe578ab7e tdf#123936 Formatting files in module helpcompiler with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/36074893c87f80daf889287c736d604f590c0ae5 tdf#123936 Formatting files in module formula with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7721e7a79733a5ac5e029869eeb88638ec00102e tdf#123936 Formatting files in module hwpfilter with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9c9a8229201bd134df923420c97db84688a7813c tdf#123936 Formatting files in module idl with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to philipp.hofer from comment #32) > I used Python's difflib.SequenceMatcher and changed all files with > 99% > similarity. ...which is IMO not necessarily a useful metric here, where tooling is generally line-based. For example, the "less than 5% of the lines on a file" from comment 0 would ensure that (line-based) `git blame` would have a low chance of hitting random-reformat noise. (And `git blame --ignore-revs-file` is not a generally useful countermeasure against the induced noise, given the issues caused by reformatting of comments, see comment 8, which you might not want `git blame` to paper over.)
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/69397a13d9458174ea3d0160cb65d77ac83c205c tdf#123936 Formatting files in module svx with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/580b4c5f945df4e98bc2bacdf3620da688b2dbdf tdf#123936 Formatting files in module svl with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f05246dc2ae1145f54e1b6e53b47fd53382add96 tdf#123936 Formatting files in module uui with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9d561c5440dd68285aa84fb3dac20a8d1df4870f tdf#123936 Formatting files in module store with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cb0630df7f32232bb3c51c464c28dcc66cdf7729 tdf#123936 Formatting files in module svtools with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/03e79e8ab515e061fbfc435e6660e1f57b4f460d tdf#123936 Formatting files in module apple_remote with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f5e3b2e83ab463064f100a9cd93f09cadaae2292 tdf#123936 Formatting files in module test with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1582d9a2c5ef9f28bc97a74e25c3948a7611fac1 tdf#123936 Formatting files in module tools with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8e7f1188899023de3be07c99f146196b39dfd584 tdf#123936 Formatting files in module ucbhelper with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b58f43e13902517dae5343913e584b7232cc2155 tdf#123936 Formatting files in module ucb with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c4286f91f2d8dce8d42bad2dda85c13658d5e0b9 tdf#123936 Formatting files in module xmlhelp with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/25e14502fdeac6c03dfed125d789b2822f488cfe tdf#123936 Formatting files in module xmlscript with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b9e9ac51a731a1b9515d935fd543218b2ee107c1 tdf#123936 Formatting files in module vbahelper with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/65717f77c43ca7cbf91e4c158d643a02a181e439 tdf#123936 Formatting files in module winaccessibility with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/49fbda99b4e563be54ee7c85560a5929f0627654 tdf#123936 Formatting files in module unoidl with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0ce86801128b0955dd46aca5e5b5add4b719df0a tdf#123936 Formatting files in module toolkit with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/afb92ffc62ba140ee1366ac5ecd526706e3d8a74 tdf#123936 Formatting files in module unotest with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/856bdfb0585cea3c67eedfb535c6477d51e4c352 tdf#123936 Formatting files in module jvmfwk with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6d5ff94b994e7279cea3d54d9d546f4f1a8cdb4d tdf#123936 Formatting files in module o3tl with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/695280feb90729fde1a7ecf1c409ae16f8281a46 tdf#123936 Formatting files in module sw with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6ceb1d0f2e23749fe03fab08ec338ba4d7782173 tdf#123936 Formatting files in module sc with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/69b12a6eb3616d15035310eeb0c3dbc7aefcb5c1 tdf#123936 Formatting files in module lotuswordpro with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/39821e7d24deffa72bd9254414d4b58f22be2fca tdf#123936 Formatting files in module libreofficekit with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/02d65d7a19981d342d9ef3996b296b4efda905a4 tdf#123936 Formatting files in module dbaccess with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7c9a2c4b97c145a358084bed4b875396d3dc3e5c tdf#123936 Formatting files in module shell with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2e4529c0016529325289701080499b3498a270f9 tdf#123936 Formatting files in module sot with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/672ddcb7d7a496f4a4f761b32aceaa72e4f600ed tdf#123936 Formatting files in module soltools with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c19cc6ad7676a987475fc718488007af3672a025 tdf#123936 Formatting files in module external with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5ce88c782e44dae6de8df2933b7c036f0dd48172 tdf#123936 Formatting files in module stoc with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/de80fdc2060abe5b171bcef72944dd7b914ccd33 tdf#123936 Formatting files in module onlineupdate with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c4ab5393e1c2332d92ea6672d3c8ffc3a6220afa tdf#123936 Formatting files in module oox with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/dab1e6435728c6d7e81d6d6158e1fa45470345d2 tdf#123936 Formatting files in module reportdesign with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4d4e95be173e84b5040af46a459b3c071bfd744a tdf#123936 Formatting files in module opencl with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/eb4c2e96f38a6b5280a83709e55fbb5b8d7e9d36 tdf#123936 Formatting files in module package with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5d8cf2021d8f7f171924f2b1adf824532cd67497 tdf#123936 Formatting files in module registry with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/481fdcc619dadf0a65e5af73b0c33b26df2400e5 tdf#123936 Formatting files in module salhelper with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7b49f8c7ebf40048181b56e9bfb11135bd473cab tdf#123936 Formatting files in module writerfilter with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c927d6daa9a6403c53cc41b1ab4dde820f08f387 tdf#123936 Formatting files in module xmloff with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/15d080d2ca19891187a547f66d77183ebed0811b tdf#123936 Formatting files in module xmlsecurity with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/156da5b55362db37d4e61a22e43e489e48797452 tdf#123936 Formatting files in module slideshow with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2d72bc353b9d086e3eb3f9cf00a034c86f13ca21 tdf#123936 Formatting files in module setup_native with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/302d64cb3c21335867b447970ab8db8d1fabdef3 tdf#123936 Formatting files in module canvas with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e8e093f14b698fc710930b2dead57c7d4fb63b8e tdf#123936 Formatting files in module filter with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/70e36068a43cb6747232441ee67e609c86362aa0 tdf#123936 Formatting files in module sal with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d0b3815392d1fb253ed05218422a7f9b37c9df24 tdf#123936 Formatting files in module extensions with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2184efed3943fe9634e6e361e8b0306a374cbf59 tdf#123936 Formatting files in module odk with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0108cd51faf942b3fc3a292522d4b2f421f1cf45 tdf#123936 Formatting files in module starmath with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/01baeab99890e5650b3dabc15f8d900490a5a133 tdf#123936 Formatting files in module include with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/58d98a08aee7bf027c109eeb94183d24351827fa tdf#123936 Formatting files in module vcl with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b35232bdf56fbda34476cf537d53bbea31235a95 tdf#123936 Formatting files in module sfx2 with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c096ab87c8a11e8d75dc689ea7024288419cfd22 tdf#123936 Formatting files in module compilerplugins with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a9bce41c64bda648be2609a0dc4aea728fa8ec77 tdf#123936 Formatting files in module sdext with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1e17165f6643afe583bb97a40fb25ecb7bab24d9 tdf#123936 Formatting files in module sd with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/315f270d2db7541e9400852b070afb30f371f644 tdf#123936 Formatting files in module configmgr with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/79b6055acd1ea27a9f054e6980abbe2024cdc4a2 tdf#123936 Formatting files in module chart2 with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Philipp Hofer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/10b23330a9655658e6d7ef1d008a3302a15e9629 tdf#123936 Formatting files in module i18npool with clang-format It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Stephan Bergmann from comment #58) > (In reply to philipp.hofer from comment #32) > > I used Python's difflib.SequenceMatcher and changed all files with > 99% > > similarity. > > ...which is IMO not necessarily a useful metric here, where tooling is > generally line-based. For example, the "less than 5% of the lines on a > file" from comment 0 would ensure that (line-based) `git blame` would have a > low chance of hitting random-reformat noise. (And `git blame > --ignore-revs-file` is not a generally useful countermeasure against the > induced noise, given the issues caused by reformatting of comments, see > comment 8, which you might not want `git blame` to paper over.) So this has nevertheless carried on with that IMO unuseful metric? So be it. This issue seems to be done now? Should we close it? Will somebody update .git-blame-ignore-revs?
(In reply to Stephan Bergmann from comment #115) > (In reply to Stephan Bergmann from comment #58) > > (In reply to philipp.hofer from comment #32) > > > I used Python's difflib.SequenceMatcher and changed all files with > 99% > > > similarity. > > > > ...which is IMO not necessarily a useful metric here, where tooling is > > generally line-based. For example, the "less than 5% of the lines on a > > file" from comment 0 would ensure that (line-based) `git blame` would have a > > low chance of hitting random-reformat noise. (And `git blame > > --ignore-revs-file` is not a generally useful countermeasure against the > > induced noise, given the issues caused by reformatting of comments, see > > comment 8, which you might not want `git blame` to paper over.) > > So this has nevertheless carried on with that IMO unuseful metric? So be it. The changes were small enough still, IMO, even if the # of lines per file was over 5%. > This issue seems to be done now? Should we close it? Yes I will close it once the commits have been added to the ignore list. > Will somebody update .git-blame-ignore-revs? @Philip: Can you do that (Add the commit hashes of your formatting commits to the file .git-blame-ignore-revs )?
Samuel Mehrbrodt committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/210dd59742e9e0643325efc0dfb7678e5d79e8c7 tdf#123936 Add formatting commits to .git-blame-ignore-revs It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Chris Sherlock committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/591b9daf8cf89dc4e7a01cec9bf9623747094a3d tdf#123936 Add formatting commit to .git-blame-ignore-revs It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.