Description: The thesaurus dialog doesn't show up in the iOS app. Steps to Reproduce: 1. Create/open a document in the iOS app 2. Click the menu entry "Extras > Thesaurus ..." Actual Results: The thesaurus dialog doesn't show up. Expected Results: The thesaurus dialog should show up. Reproducible: Always User Profile Reset: No Additional Info:
Confirmed. I believe this is primarily because no thesauri are bundled with the app, but in this case the menu should be disabled, and I believe will be disabled in the next build. Patch for master: https://gerrit.libreoffice.org/#/c/69264/ Nevertheless, it would be good to test this with an actual thesaurus.
We we're actually hoping to have the Thesaurus functionallity working. So if possible don't just disable it, but add the word lists (and the dialog). For my usecase, the following word list would be relevant: * de_CH (most important) * fr_FR * en_GB (or en_US)
Dear Nicolas Christener, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
How complex is it nowadays to add this functionality?
I will look into this now.
Note to self: Implementation apparently reached by: > #0 0x0000000108f6ded8 in SwView::GetState(SfxItemSet&) at /Volumes/TML13/lo/cp-6.4-ios-debug/sw/source/uibase/uiview/viewstat.cxx:392 > #1 0x0000000108f32d14 in SfxStubSwViewGetState(SfxShell*, SfxItemSet&) at /Volumes/TML13/lo/cp-6.4-ios-debug/workdir/SdiTarget/sw/sdi/swslots.hxx:14032 > #2 0x000000010642120c in SfxShell::CallState(void (*)(SfxShell*, SfxItemSet&), SfxItemSet&) at /Volumes/TML13/lo/cp-6.4-ios-debug/include/sfx2/shell.hxx:199 > #3 0x000000010646d374 in SfxShell::CanExecuteSlot_Impl(SfxSlot const&) at /Volumes/TML13/lo/cp-6.4-ios-debug/sfx2/source/control/shell.cxx:389 > #4 0x00000001064327ac in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) at /Volumes/TML13/lo/cp-6.4-ios-debug/sfx2/source/control/dispatch.cxx:222 > #5 0x00000001064333ac in SfxDispatcher::PostMsgHandler(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >) at /Volumes/TML13/lo/cp-6.4-ios-debug/sfx2/source/control/dispatch.cxx:997 > #6 0x0000000106443ec8 in decltype(*(std::__1::forward<SfxDispatcher*&>(fp0)).*fp(std::__1::forward<std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> > >(fp1))) std::__1::__invoke<void (SfxDispatcher::*&)(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >), SfxDispatcher*&, std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >, void>(void (SfxDispatcher::*&)(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >), SfxDispatcher*&, std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >&&) at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/type_traits:3486 > #7 0x0000000106443dcc in std::__1::__bind_return<void (SfxDispatcher::*)(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >), std::__1::tuple<SfxDispatcher*, std::__1::placeholders::__ph<1> >, std::__1::tuple<std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >&&>, __is_valid_bind_return<void (SfxDispatcher::*)(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >), std::__1::tuple<SfxDispatcher*, std::__1::placeholders::__ph<1> >, std::__1::tuple<std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >&&> >::value>::type std::__1::__apply_functor<void (SfxDispatcher::*)(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >), std::__1::tuple<SfxDispatcher*, std::__1::placeholders::__ph<1> >, 0ul, 1ul, std::__1::tuple<std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >&&> >(void (SfxDispatcher::*&)(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >), std::__1::tuple<SfxDispatcher*, std::__1::placeholders::__ph<1> >&, std::__1::__tuple_indices<0ul, 1ul>, std::__1::tuple<std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >&&>&&) at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/functional:2845 > #8 0x0000000106443d40 in std::__1::__bind_return<void (SfxDispatcher::*)(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >), std::__1::tuple<SfxDispatcher*, std::__1::placeholders::__ph<1> >, std::__1::tuple<std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >&&>, __is_valid_bind_return<void (SfxDispatcher::*)(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >), std::__1::tuple<SfxDispatcher*, std::__1::placeholders::__ph<1> >, std::__1::tuple<std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >&&> >::value>::type std::__1::__bind<void (SfxDispatcher::*)(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >), SfxDispatcher*, std::__1::placeholders::__ph<1> const&>::operator()<std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> > >(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >&&) at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/functional:2878 > #9 0x0000000106443cb4 in decltype(std::__1::forward<std::__1::__bind<void (SfxDispatcher::*)(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >), SfxDispatcher*, std::__1::placeholders::__ph<1> const&>&>(fp)(std::__1::forward<std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> > >(fp0))) std::__1::__invoke<std::__1::__bind<void (SfxDispatcher::*)(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >), SfxDispatcher*, std::__1::placeholders::__ph<1> const&>&, std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> > >(std::__1::__bind<void (SfxDispatcher::*)(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >), SfxDispatcher*, std::__1::placeholders::__ph<1> const&>&, std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >&&) at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/type_traits:3545 > #10 0x0000000106443c44 in void std::__1::__invoke_void_return_wrapper<void>::__call<std::__1::__bind<void (SfxDispatcher::*)(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >), SfxDispatcher*, std::__1::placeholders::__ph<1> const&>&, std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> > >(std::__1::__bind<void (SfxDispatcher::*)(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >), SfxDispatcher*, std::__1::placeholders::__ph<1> const&>&, std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >&&) at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__functional_base:348 > #11 0x0000000106443be4 in std::__1::__function::__alloc_func<std::__1::__bind<void (SfxDispatcher::*)(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >), SfxDispatcher*, std::__1::placeholders::__ph<1> const&>, std::__1::allocator<std::__1::__bind<void (SfxDispatcher::*)(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >), SfxDispatcher*, std::__1::placeholders::__ph<1> const&> >, void (std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >)>::operator()(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >&&) at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/functional:1546 > #12 0x0000000106442624 in std::__1::__function::__func<std::__1::__bind<void (SfxDispatcher::*)(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >), SfxDispatcher*, std::__1::placeholders::__ph<1> const&>, std::__1::allocator<std::__1::__bind<void (SfxDispatcher::*)(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >), SfxDispatcher*, std::__1::placeholders::__ph<1> const&> >, void (std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >)>::operator()(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >&&) at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/functional:1720 > #13 0x000000010677b680 in std::__1::__function::__value_func<void (std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >)>::operator()(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >&&) const at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/functional:1873 > #14 0x000000010677b0a8 in std::__1::function<void (std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >)>::operator()(std::__1::unique_ptr<SfxRequest, std::__1::default_delete<SfxRequest> >) const at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/functional:2548 > #15 0x000000010677afec in SfxHintPoster::DoEvent_Impl(void*) at /Volumes/TML13/lo/cp-6.4-ios-debug/sfx2/source/notify/hintpost.cxx:47 > #16 0x000000010677af28 in SfxHintPoster::LinkStubDoEvent_Impl(void*, void*) at /Volumes/TML13/lo/cp-6.4-ios-debug/sfx2/source/notify/hintpost.cxx:44 > #17 0x000000010647e22c in Link<void*, void>::Call(void*) const at /Volumes/TML13/lo/cp-6.4-ios-debug/include/tools/link.hxx:112 > #18 0x0000000109cd1140 in ImplHandleUserEvent(ImplSVEvent*) at /Volumes/TML13/lo/cp-6.4-ios-debug/vcl/source/window/winproc.cxx:1964 > #19 0x0000000109cce630 in ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) at /Volumes/TML13/lo/cp-6.4-ios-debug/vcl/source/window/winproc.cxx:2517 > #20 0x000000010a4f9c64 in SalFrame::CallCallback(SalEvent, void const*) const at /Volumes/TML13/lo/cp-6.4-ios-debug/vcl/inc/salframe.hxx:299 > #21 0x000000010a501a58 in AquaSalInstance::ProcessEvent(SalUserEventList::SalUserEvent) at /Volumes/TML13/lo/cp-6.4-ios-debug/vcl/headless/svpinst.cxx:307 > #22 0x000000010a26f10c in SalUserEventList::DispatchUserEvents(bool) at /Volumes/TML13/lo/cp-6.4-ios-debug/vcl/source/app/salusereventlist.cxx:110 > #23 0x000000010a502548 in AquaSalInstance::DoYield(bool, bool) at /Volumes/TML13/lo/cp-6.4-ios-debug/vcl/headless/svpinst.cxx:450 > #24 0x000000010a30e540 in ImplYield(bool, bool) at /Volumes/TML13/lo/cp-6.4-ios-debug/vcl/source/app/svapp.cxx:464 > #25 0x000000010a30e344 in Application::Yield() at /Volumes/TML13/lo/cp-6.4-ios-debug/vcl/source/app/svapp.cxx:528 > #26 0x000000010a30e2bc in Application::Execute() at /Volumes/TML13/lo/cp-6.4-ios-debug/vcl/source/app/svapp.cxx:445 > #27 0x00000001069ebf08 in desktop::Desktop::Main() at /Volumes/TML13/lo/cp-6.4-ios-debug/desktop/source/app/app.cxx:1617 > #28 0x000000010a32c08c in ImplSVMain() at /Volumes/TML13/lo/cp-6.4-ios-debug/vcl/source/app/svmain.cxx:191 > #29 0x000000010a32d4c0 in SVMain() at /Volumes/TML13/lo/cp-6.4-ios-debug/vcl/source/app/svmain.cxx:225 > #30 0x0000000106a20948 in soffice_main at /Volumes/TML13/lo/cp-6.4-ios-debug/desktop/source/app/sofficemain.cxx:115
Was easier than I feared. Suggested fix in https://gerrit.libreoffice.org/c/core/+/113066 .
Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/89af24074e9adac4d005dcc322d81db09fc19f54 tdf#124173: Enable thesauruses in the iOS app It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Very nice!! Tested in 6.4.8 (2) with German (Switzerland) words. I think this issue can be closed. Thanks a lot to the Collabora team and especially Tor for taking care of this!