Bug 124176 - Use pragma once instead of include guards
Summary: Use pragma once instead of include guards
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.5.0 target:7.0.0
Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
Depends on:
Blocks:
 
Reported: 2019-03-18 15:46 UTC by Samuel Mehrbrodt (CIB)
Modified: 2020-03-23 20:29 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Mehrbrodt (CIB) 2019-03-18 15:46:40 UTC
Background: https://en.wikipedia.org/wiki/Include_guard

The task is to remove the include guards in the header files and replace them with "#pragma once".

See this commit for an example: https://cgit.freedesktop.org/libreoffice/core/commit/?id=cfdba2b94fd7c0a2ec0250ddc9212d367db50c8c
Comment 1 Ritchie Cunningham 2019-04-17 20:35:37 UTC
I'd like to work on this as my first contribution to LibreOffice.

I personally use #pragma once consistently, I do wonder though if it should be included in LibreOffice given that it isn't considered part of the standards.
Comment 2 Samuel Mehrbrodt (CIB) 2019-04-18 07:34:59 UTC
(In reply to Ritchie Cunningham from comment #1)
> I personally use #pragma once consistently, I do wonder though if it should
> be included in LibreOffice given that it isn't considered part of the
> standards.

Yes, no worries, me made sure that all compilers we use support it.
Comment 3 Xisco Faulí 2019-07-18 11:39:47 UTC
Dear Ritchie Cunningham,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assigned it back to yourself if you're still working on this.
Comment 4 Commit Notification 2019-12-18 18:03:03 UTC
Muhammet Kara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ecd490b6e3e612df117e82675e63237685e3ca36

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2019-12-18 20:21:43 UTC
Yusuf Keten committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/eb57eb632c715bb32d94f5988b295bb766ad0c57

tdf#124176:  Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2019-12-18 21:47:51 UTC
Kemal Ayhan committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0d9e1e364d4a705c87b86e99ef9b4e5a6564b03a

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2019-12-18 22:07:18 UTC
Desmin Alpaslan committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2ded976667af503da29defc3740d0e61c4b0c723

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2019-12-19 00:51:34 UTC
Onur Yilmaz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/42a1a1c6b91907f81e15066ffab219411f18c4db

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2019-12-19 03:41:28 UTC
Yusuf Keten committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/583c1c34ae9c974f68d21ee6b74baf87ab08c6cf

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2019-12-19 03:43:59 UTC
Tolunay Dündar committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9ed0afc79b7da20d08153c2c3e302b061292358f

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2019-12-19 06:38:26 UTC
Mesut Çifci committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0b827a6a64300430b43dfb48daab33f81d3494de

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2019-12-19 06:39:53 UTC
Batuhan Görkem Benzer committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7b1f3135de3211b0b750571ecdcd9dcab752b544

tdf#124176: Use pragma once instead of header guard

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2019-12-20 18:36:12 UTC
Tolunay Dündar committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9f749e97854009697d4263960c966313d3dd19d2

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 Commit Notification 2019-12-20 18:40:15 UTC
Batuhan Görkem Benzer committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d0b69965012a711c0b181bf359c8b27a782be2c3

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Commit Notification 2019-12-20 19:57:40 UTC
Kemal Ayhan committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0cc5185147402f6c5a4ff8e1256aa8348a04f75e

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 Commit Notification 2019-12-20 19:59:19 UTC
Ayhan Yalçınsoy committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7cf98c89c19e68b369a296d55c2e9bdf1b42d356

tdf#124176:Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Commit Notification 2019-12-20 20:00:59 UTC
Selim Şeker committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0d34eb78fd5fe72d9e10438b41e76fe45cb2c2df

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 18 Commit Notification 2019-12-20 20:02:32 UTC
Sıla Genç committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/186fdf0d20162568891763f08e7f99a38535a699

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 19 Commit Notification 2019-12-20 20:12:00 UTC
Onur Yilmaz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1c7fb79ad1c9356424ff1ed489cc2ac04cc1d68d

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 20 Commit Notification 2019-12-27 12:34:48 UTC
Gökay ŞATIR committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c309d478b8304d8779bb2a49e96ac12527762e38

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 21 Andrea Gelmini 2019-12-28 00:16:24 UTC
(In reply to Samuel Mehrbrodt (CIB) from comment #0)

> The task is to remove the include guards in the header files and replace
> them with "#pragma once".


Maybe we have to rework this:
https://github.com/LibreOffice/core/blob/master/writerfilter/source/ooxml/factoryinc.py
Comment 22 Commit Notification 2019-12-28 09:32:50 UTC
Andrea Gelmini committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0104c28ceac5f2802a34305e85edc2d9ffe252ba

tdf#124176: Use "pragma once" on UnoControls/*

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 23 Commit Notification 2019-12-28 10:45:58 UTC
Andrea Gelmini committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/08eccd9db6e7e2240a4053092967add4624a5f6c

tdf#124176: Use "pragma once" on svtools/*

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 24 Commit Notification 2019-12-28 10:58:54 UTC
Andrea Gelmini committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8fd8c0894deb1e9161aa4290c0f9c860ab4b14fb

tdf#124176: Use "pragma once" on udkapi/*

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 25 Commit Notification 2019-12-28 11:02:38 UTC
Andrea Gelmini committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/40f1a46e8d4e4f4a67a1909ae636ec17f7cc7658

tdf#124176: Use "pragma once" on accessibility/*

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 26 Commit Notification 2019-12-28 11:05:12 UTC
Andrea Gelmini committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/77f4eb0bfefff6cb972abd8e1cc2b9d2c6df368d

tdf#124176: Use "pragma once" on xmlscript/*

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 27 Commit Notification 2019-12-28 18:56:48 UTC
Stephan Bergmann committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3bf4af8d187ba21498af5b6ea7a94cdfc3b93613

Revert "tdf#124176: Use "pragma once" on udkapi/*"

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 28 Andrea Gelmini 2019-12-29 13:26:45 UTC
For the future, keep in mind that:

a) udkapi/ doesn't support "pragma once";
b) writerfilter/ is parsed with two Python scripts. If you wanna update it, you have to change .mk
Comment 29 Commit Notification 2019-12-29 15:51:15 UTC
Mesut Çifci committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/53c9a6a0f133b188896eb1a3c40587d7a2c9277d

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 30 Commit Notification 2019-12-29 16:01:46 UTC
erto committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/22db41d4078f56d03905efbc71c16c322b2df091

tdf#124176 Use pragma once instead of header guard

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 31 Commit Notification 2019-12-29 17:42:30 UTC
cagatay committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f1656f7db9c0e00b1c9907d382a3e5e4cbdc5edd

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 32 Commit Notification 2019-12-29 20:01:31 UTC
Aleyna Doğrucan committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/53ba2c95e9ff2a102f29e81a62fcbab39dd0f3e0

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 33 Commit Notification 2019-12-29 20:02:54 UTC
Aleyna Doğrucan committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/349695bf846e6193f78d1a8c8751ad38e9a3a501

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 34 Commit Notification 2020-01-06 18:57:12 UTC
Elzem Atay committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ac91b39d5b8f96063fa5a10e50fa2a8a2738012f

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 35 Commit Notification 2020-01-07 13:27:31 UTC
Aleyna Doğrucan committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8b4aba14bb7ba98346b3ccd77c26dccda4cc1831

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 36 Commit Notification 2020-01-25 16:45:35 UTC
Onur Yilmaz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ef86e72fb06e1b59d1587828d1a9089b50767144

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 37 Commit Notification 2020-01-25 16:47:10 UTC
Efdal İncesu committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e7c6ceb862e997a56b51212e2c4351ba8ce13602

tdf#124176: Use pragma once instead of include guard

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 38 Commit Notification 2020-01-25 16:48:40 UTC
iakarsu committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a43fe4e5c73c44a68fc32b16c1c8db4f3e216f4e

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 39 Commit Notification 2020-01-25 16:50:11 UTC
Eda Nur Var committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d080b07e9a9b6b6c0848debd75c94240c4d45c1e

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 40 Commit Notification 2020-01-25 16:51:48 UTC
Burak Bala committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/db421c41a5cf50303b72a8fd32cd29c500cc113f

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 41 Commit Notification 2020-01-25 17:59:22 UTC
Efdal İncesu committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/99c5669b4f54a3e55625ec0896852ed4154d2765

tdf#124176: Use pragma once instead of include guard

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 42 Commit Notification 2020-01-25 18:03:12 UTC
Faruk Demirbaş committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a44ca770302e8aa7079de96bda0c2fe2e7cc92bb

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 43 Commit Notification 2020-01-25 18:08:09 UTC
Canberk TURAN committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/134507a663871d45951fdbd4291fa337ed70a1f4

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 44 Commit Notification 2020-01-25 18:10:46 UTC
Batuhan Taskaya committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/44139efb6a64735d3c6fe1f1b0f0007eff3a7504

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 45 Commit Notification 2020-01-25 18:12:20 UTC
Faruk Demirbaş committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/37b20089669e5d6f20db863ed770647ba8b1bd37

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 46 Commit Notification 2020-01-26 19:00:34 UTC
Pelin Kuran committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c37d56c6cd161fd67e5aae917dc248f373df7767

tdf#124176: Use pragma once instead of header guard

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 47 Commit Notification 2020-01-26 19:12:19 UTC
Mehmet Emin Başoğlu committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/34330368088109fd140cad345f3de1077d195ddd

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 48 Commit Notification 2020-01-26 19:28:40 UTC
iakarsu committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9accb3c4b5e1861d9a03c655242da5b629f5a6d6

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 49 Commit Notification 2020-01-26 19:30:14 UTC
Mehmet Emin Başoğlu committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/20b5c03ae6406a64ffec328e550fd3c9b3f0306c

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 50 Commit Notification 2020-01-26 19:32:58 UTC
Canberk TURAN committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e337f5b20430e52ef99923a475d05a1191506d21

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 51 Commit Notification 2020-01-26 19:48:13 UTC
Burak Bala committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/47c598260a8f07cf3a1e4cab061df3f2d261932c

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 52 Commit Notification 2020-01-27 08:56:21 UTC
Burak Bala committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ce55090e00394a6a475b2d9be808d4bca94b2838

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 53 Commit Notification 2020-01-27 08:57:59 UTC
Sarper Akdemir committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/04df6666613be69e4eb4dd8a2b195686bb48e5b3

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 54 Commit Notification 2020-01-27 09:04:23 UTC
Sarper Akdemir committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8d4cb2870f34ec1f30ed51bc6071334c80cbe178

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 55 Commit Notification 2020-01-27 09:06:28 UTC
Eda Nur Var committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6f3678f377d532860c0aed4ab97e151927e5b938

tdf#124176 Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 56 Commit Notification 2020-01-27 09:11:02 UTC
Hakan Bakacak committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b29a3b6bac8162ccadc8dcf870bd73b9e1e964a2

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 57 Commit Notification 2020-01-27 09:39:36 UTC
ayhanyalcinsoy committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/33bc192286c0f499c0d420b0e6f4a5d8ffbb9bf7

tdf#124176:Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 58 Commit Notification 2020-01-27 15:13:18 UTC
Kemal Ayhan committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a437ecfd437531a293f69d503f30ac77ccfc75c2

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 59 Commit Notification 2020-01-27 20:30:15 UTC
Cumali Toprak committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4b5ad13fb07f61ff627a0981985ce15f8812a1b9

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 60 Commit Notification 2020-01-27 20:44:41 UTC
Pelin Kuran committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f61ed40fff871a5b301b05c9d8e0755f16bf0a83

tdf#124176: Use pragma once instead of header guard

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 61 Commit Notification 2020-01-27 21:25:08 UTC
Aleyna Doğrucan committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8118d328285ee47556d18aab1efcd2824c1dbcf0

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 62 Commit Notification 2020-01-28 12:40:28 UTC
Serkan Özkaya committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3160d75bac24acd0eb5b6a727d2b68d434921843

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 63 Commit Notification 2020-01-29 21:15:08 UTC
Pelin Kuran committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5d7a526ee784abc3d83835b9e43047baf5dbe0b9

tdf#124176: Use pragma once instead of header guard

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 64 Commit Notification 2020-01-30 11:54:42 UTC
bugrakurt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ee9a15422561dfae0ae259c1641695f6c5c41388

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 65 Commit Notification 2020-01-30 15:54:06 UTC
bugrakurt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1a07ce2112e3b4dc117d8cafe85d2c19957755d2

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 66 Commit Notification 2020-02-08 15:20:27 UTC
Furkan Ahmet Kara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ef877db09c11f7e201a4bc941e05085bd0eef956

tdf#124176: Use pragma once instead of include guards

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 67 Mohamed Sameh 2020-02-10 19:25:16 UTC
I would like to work on this issue. I have a question, Can I fix any arbitrary header file or is there a list I am supposed to follow ?
Comment 68 Muhammet Kara 2020-02-10 19:50:51 UTC
(In reply to Mohamed Sameh from comment #67)
> I would like to work on this issue. I have a question, Can I fix any
> arbitrary header file or is there a list I am supposed to follow ?

You can fix any C++ header (.hxx) file. You can find them by using a command like this on linux terminal while in the core directory: git grep #ifndef

Please make sure your clone of the core git repo is up to date, and do not create a large patch. (Not exceeding 50 lines of change might be a good idea for quick reviews.)
Comment 69 Commit Notification 2020-02-11 11:28:46 UTC
Furkan Ahmet Kara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cb942e1326f2eaf4b1796c20dbb21602d3e02307

tdf#124176: Use pragma once instead of include guards

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 70 Mohamed Sameh 2020-02-11 19:53:47 UTC
(In reply to Muhammet Kara from comment #68)
> (In reply to Mohamed Sameh from comment #67)
> > I would like to work on this issue. I have a question, Can I fix any
> > arbitrary header file or is there a list I am supposed to follow ?
> 
> You can fix any C++ header (.hxx) file. You can find them by using a command
> like this on linux terminal while in the core directory: git grep #ifndef
> 
> Please make sure your clone of the core git repo is up to date, and do not
> create a large patch. (Not exceeding 50 lines of change might be a good idea
> for quick reviews.)

I submitted a commit to gerrit and here it is
https://gerrit.libreoffice.org/c/core/+/88473
did I follow the steps correctly ? And Is there any thing else I should do now to finish contributing to this easy hack ?
Comment 71 Buovjaga 2020-02-11 20:06:23 UTC
(In reply to Mohamed Sameh from comment #70)
> I submitted a commit to gerrit and here it is
> https://gerrit.libreoffice.org/c/core/+/88473
> did I follow the steps correctly ? And Is there any thing else I should do
> now to finish contributing to this easy hack ?

You forgot to include the bug report reference

tdf#124176

at the start of your commit message. Please click the EDIT button in the middle of the gerrit patch interface and add it.
Comment 72 Mohamed Sameh 2020-02-12 19:00:39 UTC
https://gerrit.libreoffice.org/c/core/+/88473/1
I solved this easyhack in one file 'avmedia/source/win/manager.hxx', but for some reason gerrit failed to build can anyone point out to me how I could fix this ? I only made 3 changes and I can't see what could have possibly gone wrong.
I am still building at my local machine to see if I will face a similar problem but it is taking a lot of time.
Comment 73 Muhammet Kara 2020-02-12 19:11:22 UTC
(In reply to Mohamed Sameh from comment #72)
> https://gerrit.libreoffice.org/c/core/+/88473/1
> I solved this easyhack in one file 'avmedia/source/win/manager.hxx', but for
> some reason gerrit failed to build can anyone point out to me how I could
> fix this ? I only made 3 changes and I can't see what could have possibly
> gone wrong.
> I am still building at my local machine to see if I will face a similar
> problem but it is taking a lot of time.

Please check your patch on Gerrit for the comments/review.
Comment 74 Commit Notification 2020-02-13 10:59:54 UTC
Mohamed Sameh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/76d6b4d02d2ad57bbb1b348d9ba9f73ce9201a8f

tdf#124176: Use pragma once instead of include guards

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 75 Commit Notification 2020-02-16 19:52:34 UTC
Mohamed Sameh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3f515b85e08872f1239e599c708fec6fe09a7b3a

tdf#124176: Use pragma once instead of include guards

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 76 Commit Notification 2020-02-29 10:07:22 UTC
james committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/32d08f86d20b2f7e44f6b0506feee90fb7138d33

tdf#124176: Use pragma once instead of include guards

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 77 Commit Notification 2020-02-29 19:20:24 UTC
Bugra committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6800a6dd9a60603badffb7b5bcbef22eee2134cb

tdf#124176: Use pragma once instead of include guards

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 78 Harshit Jain 2020-03-21 08:18:43 UTC
I submitted a patch to gerrit but it shows the build failed message. The exact message is -

" Build Failed 

https://ci.libreoffice.org/job/gerrit_master/52277/ : FAILURE

the build failed because of an issue with the bot itself, not with the code.
The Bot failed to checkout the source ( https://ci.libreoffice.org/job/gerrit_mac/56600/ ) "

Link to the patch: https://gerrit.libreoffice.org/c/core/+/90831

So, is there any issue with my submission or the issue is with the bot only (as the failure statements says)? And if there is anything I can do to get the patch successfully pushed, please suggest.
Comment 79 Buovjaga 2020-03-21 09:33:34 UTC
(In reply to Harshit Jain from comment #78)
> I submitted a patch to gerrit but it shows the build failed message. The
> exact message is -
> 
> " Build Failed 
> 
> https://ci.libreoffice.org/job/gerrit_master/52277/ : FAILURE
> 
> the build failed because of an issue with the bot itself, not with the code.
> The Bot failed to checkout the source (
> https://ci.libreoffice.org/job/gerrit_mac/56600/ ) "
> 
> Link to the patch: https://gerrit.libreoffice.org/c/core/+/90831
> 
> So, is there any issue with my submission or the issue is with the bot only
> (as the failure statements says)? And if there is anything I can do to get
> the patch successfully pushed, please suggest.

As you can see from the console log, it has nothing to do with your patch: https://ci.libreoffice.org/job/gerrit_mac/56600/console
Please never change the statuses of easy hacks to needinfo.
Comment 80 Harshit Jain 2020-03-21 13:10:14 UTC
(In reply to Buovjaga from comment #79)
> (In reply to Harshit Jain from comment #78)
> > I submitted a patch to gerrit but it shows the build failed message. The
> > exact message is -
> > 
> > " Build Failed 
> > 
> > https://ci.libreoffice.org/job/gerrit_master/52277/ : FAILURE
> > 
> > the build failed because of an issue with the bot itself, not with the code.
> > The Bot failed to checkout the source (
> > https://ci.libreoffice.org/job/gerrit_mac/56600/ ) "
> > 
> > Link to the patch: https://gerrit.libreoffice.org/c/core/+/90831
> > 
> > So, is there any issue with my submission or the issue is with the bot only
> > (as the failure statements says)? And if there is anything I can do to get
> > the patch successfully pushed, please suggest.
> 
> As you can see from the console log, it has nothing to do with your patch:
> https://ci.libreoffice.org/job/gerrit_mac/56600/console
> Please never change the statuses of easy hacks to needinfo.

Okay, will keep this in mind.

Now, will the build be automatically triggered or I need to do something, so
that the patch gets pushed successfully.
Comment 81 Commit Notification 2020-03-22 19:00:57 UTC
Furkan Ahmet Kara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f13913d510672cd4f28726ef18c4f3d014b6f06c

tdf#124176: Use pragma once instead of include guards

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 82 Commit Notification 2020-03-23 11:36:50 UTC
Harshit Jain committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fd1cd5522283f279a01d6d673f676a1346e9358b

tdf#124176: Use pragma once instead of include guards

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 83 Commit Notification 2020-03-23 20:29:44 UTC
gokaysatir committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/574e3ddae11a4fa3965bbf8ddf6352f63b41d341

tdf#124176 Use pragma once instead of include guards

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.