Background: https://en.wikipedia.org/wiki/Include_guard The task is to remove the include guards in the header files and replace them with "#pragma once". See this commit for an example: https://cgit.freedesktop.org/libreoffice/core/commit/?id=cfdba2b94fd7c0a2ec0250ddc9212d367db50c8c
I'd like to work on this as my first contribution to LibreOffice. I personally use #pragma once consistently, I do wonder though if it should be included in LibreOffice given that it isn't considered part of the standards.
(In reply to Ritchie Cunningham from comment #1) > I personally use #pragma once consistently, I do wonder though if it should > be included in LibreOffice given that it isn't considered part of the > standards. Yes, no worries, me made sure that all compilers we use support it.
Dear Ritchie Cunningham, This bug has been in ASSIGNED status for more than 3 months without any activity. Resetting it to NEW. Please assigned it back to yourself if you're still working on this.
Muhammet Kara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ecd490b6e3e612df117e82675e63237685e3ca36 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Yusuf Keten committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/eb57eb632c715bb32d94f5988b295bb766ad0c57 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Kemal Ayhan committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0d9e1e364d4a705c87b86e99ef9b4e5a6564b03a tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Desmin Alpaslan committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2ded976667af503da29defc3740d0e61c4b0c723 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Onur Yilmaz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/42a1a1c6b91907f81e15066ffab219411f18c4db tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Yusuf Keten committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/583c1c34ae9c974f68d21ee6b74baf87ab08c6cf tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Tolunay Dündar committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9ed0afc79b7da20d08153c2c3e302b061292358f tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mesut Çifci committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0b827a6a64300430b43dfb48daab33f81d3494de tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Batuhan Görkem Benzer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7b1f3135de3211b0b750571ecdcd9dcab752b544 tdf#124176: Use pragma once instead of header guard It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Tolunay Dündar committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9f749e97854009697d4263960c966313d3dd19d2 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Batuhan Görkem Benzer committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d0b69965012a711c0b181bf359c8b27a782be2c3 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Kemal Ayhan committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0cc5185147402f6c5a4ff8e1256aa8348a04f75e tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Ayhan Yalçınsoy committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7cf98c89c19e68b369a296d55c2e9bdf1b42d356 tdf#124176:Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Selim Şeker committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0d34eb78fd5fe72d9e10438b41e76fe45cb2c2df tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sıla Genç committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/186fdf0d20162568891763f08e7f99a38535a699 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Onur Yilmaz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1c7fb79ad1c9356424ff1ed489cc2ac04cc1d68d tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Gökay ŞATIR committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c309d478b8304d8779bb2a49e96ac12527762e38 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Samuel Mehrbrodt (CIB) from comment #0) > The task is to remove the include guards in the header files and replace > them with "#pragma once". Maybe we have to rework this: https://github.com/LibreOffice/core/blob/master/writerfilter/source/ooxml/factoryinc.py
Andrea Gelmini committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0104c28ceac5f2802a34305e85edc2d9ffe252ba tdf#124176: Use "pragma once" on UnoControls/* It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Andrea Gelmini committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/08eccd9db6e7e2240a4053092967add4624a5f6c tdf#124176: Use "pragma once" on svtools/* It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Andrea Gelmini committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8fd8c0894deb1e9161aa4290c0f9c860ab4b14fb tdf#124176: Use "pragma once" on udkapi/* It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Andrea Gelmini committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/40f1a46e8d4e4f4a67a1909ae636ec17f7cc7658 tdf#124176: Use "pragma once" on accessibility/* It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Andrea Gelmini committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/77f4eb0bfefff6cb972abd8e1cc2b9d2c6df368d tdf#124176: Use "pragma once" on xmlscript/* It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Stephan Bergmann committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3bf4af8d187ba21498af5b6ea7a94cdfc3b93613 Revert "tdf#124176: Use "pragma once" on udkapi/*" It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
For the future, keep in mind that: a) udkapi/ doesn't support "pragma once"; b) writerfilter/ is parsed with two Python scripts. If you wanna update it, you have to change .mk
Mesut Çifci committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/53c9a6a0f133b188896eb1a3c40587d7a2c9277d tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
erto committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/22db41d4078f56d03905efbc71c16c322b2df091 tdf#124176 Use pragma once instead of header guard It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
cagatay committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f1656f7db9c0e00b1c9907d382a3e5e4cbdc5edd tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Aleyna Doğrucan committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/53ba2c95e9ff2a102f29e81a62fcbab39dd0f3e0 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Aleyna Doğrucan committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/349695bf846e6193f78d1a8c8751ad38e9a3a501 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Elzem Atay committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ac91b39d5b8f96063fa5a10e50fa2a8a2738012f tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Aleyna Doğrucan committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8b4aba14bb7ba98346b3ccd77c26dccda4cc1831 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Onur Yilmaz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ef86e72fb06e1b59d1587828d1a9089b50767144 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Efdal İncesu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e7c6ceb862e997a56b51212e2c4351ba8ce13602 tdf#124176: Use pragma once instead of include guard It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
iakarsu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a43fe4e5c73c44a68fc32b16c1c8db4f3e216f4e tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eda Nur Var committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d080b07e9a9b6b6c0848debd75c94240c4d45c1e tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Burak Bala committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/db421c41a5cf50303b72a8fd32cd29c500cc113f tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Efdal İncesu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/99c5669b4f54a3e55625ec0896852ed4154d2765 tdf#124176: Use pragma once instead of include guard It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Faruk Demirbaş committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a44ca770302e8aa7079de96bda0c2fe2e7cc92bb tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Canberk TURAN committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/134507a663871d45951fdbd4291fa337ed70a1f4 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Batuhan Taskaya committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/44139efb6a64735d3c6fe1f1b0f0007eff3a7504 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Faruk Demirbaş committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/37b20089669e5d6f20db863ed770647ba8b1bd37 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Pelin Kuran committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c37d56c6cd161fd67e5aae917dc248f373df7767 tdf#124176: Use pragma once instead of header guard It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mehmet Emin Başoğlu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/34330368088109fd140cad345f3de1077d195ddd tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
iakarsu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9accb3c4b5e1861d9a03c655242da5b629f5a6d6 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mehmet Emin Başoğlu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/20b5c03ae6406a64ffec328e550fd3c9b3f0306c tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Canberk TURAN committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e337f5b20430e52ef99923a475d05a1191506d21 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Burak Bala committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/47c598260a8f07cf3a1e4cab061df3f2d261932c tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Burak Bala committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ce55090e00394a6a475b2d9be808d4bca94b2838 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sarper Akdemir committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/04df6666613be69e4eb4dd8a2b195686bb48e5b3 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sarper Akdemir committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8d4cb2870f34ec1f30ed51bc6071334c80cbe178 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eda Nur Var committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6f3678f377d532860c0aed4ab97e151927e5b938 tdf#124176 Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Hakan Bakacak committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b29a3b6bac8162ccadc8dcf870bd73b9e1e964a2 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
ayhanyalcinsoy committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/33bc192286c0f499c0d420b0e6f4a5d8ffbb9bf7 tdf#124176:Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Kemal Ayhan committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a437ecfd437531a293f69d503f30ac77ccfc75c2 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Cumali Toprak committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4b5ad13fb07f61ff627a0981985ce15f8812a1b9 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Pelin Kuran committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f61ed40fff871a5b301b05c9d8e0755f16bf0a83 tdf#124176: Use pragma once instead of header guard It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Aleyna Doğrucan committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8118d328285ee47556d18aab1efcd2824c1dbcf0 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Serkan Özkaya committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3160d75bac24acd0eb5b6a727d2b68d434921843 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Pelin Kuran committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5d7a526ee784abc3d83835b9e43047baf5dbe0b9 tdf#124176: Use pragma once instead of header guard It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
bugrakurt committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ee9a15422561dfae0ae259c1641695f6c5c41388 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
bugrakurt committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1a07ce2112e3b4dc117d8cafe85d2c19957755d2 tdf#124176: Use pragma once instead of include guards It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Furkan Ahmet Kara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ef877db09c11f7e201a4bc941e05085bd0eef956 tdf#124176: Use pragma once instead of include guards It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I would like to work on this issue. I have a question, Can I fix any arbitrary header file or is there a list I am supposed to follow ?
(In reply to Mohamed Sameh from comment #67) > I would like to work on this issue. I have a question, Can I fix any > arbitrary header file or is there a list I am supposed to follow ? You can fix any C++ header (.hxx) file. You can find them by using a command like this on linux terminal while in the core directory: git grep #ifndef Please make sure your clone of the core git repo is up to date, and do not create a large patch. (Not exceeding 50 lines of change might be a good idea for quick reviews.)
Furkan Ahmet Kara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cb942e1326f2eaf4b1796c20dbb21602d3e02307 tdf#124176: Use pragma once instead of include guards It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Muhammet Kara from comment #68) > (In reply to Mohamed Sameh from comment #67) > > I would like to work on this issue. I have a question, Can I fix any > > arbitrary header file or is there a list I am supposed to follow ? > > You can fix any C++ header (.hxx) file. You can find them by using a command > like this on linux terminal while in the core directory: git grep #ifndef > > Please make sure your clone of the core git repo is up to date, and do not > create a large patch. (Not exceeding 50 lines of change might be a good idea > for quick reviews.) I submitted a commit to gerrit and here it is https://gerrit.libreoffice.org/c/core/+/88473 did I follow the steps correctly ? And Is there any thing else I should do now to finish contributing to this easy hack ?
(In reply to Mohamed Sameh from comment #70) > I submitted a commit to gerrit and here it is > https://gerrit.libreoffice.org/c/core/+/88473 > did I follow the steps correctly ? And Is there any thing else I should do > now to finish contributing to this easy hack ? You forgot to include the bug report reference tdf#124176 at the start of your commit message. Please click the EDIT button in the middle of the gerrit patch interface and add it.
https://gerrit.libreoffice.org/c/core/+/88473/1 I solved this easyhack in one file 'avmedia/source/win/manager.hxx', but for some reason gerrit failed to build can anyone point out to me how I could fix this ? I only made 3 changes and I can't see what could have possibly gone wrong. I am still building at my local machine to see if I will face a similar problem but it is taking a lot of time.
(In reply to Mohamed Sameh from comment #72) > https://gerrit.libreoffice.org/c/core/+/88473/1 > I solved this easyhack in one file 'avmedia/source/win/manager.hxx', but for > some reason gerrit failed to build can anyone point out to me how I could > fix this ? I only made 3 changes and I can't see what could have possibly > gone wrong. > I am still building at my local machine to see if I will face a similar > problem but it is taking a lot of time. Please check your patch on Gerrit for the comments/review.
Mohamed Sameh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/76d6b4d02d2ad57bbb1b348d9ba9f73ce9201a8f tdf#124176: Use pragma once instead of include guards It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mohamed Sameh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3f515b85e08872f1239e599c708fec6fe09a7b3a tdf#124176: Use pragma once instead of include guards It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
james committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/32d08f86d20b2f7e44f6b0506feee90fb7138d33 tdf#124176: Use pragma once instead of include guards It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Bugra committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6800a6dd9a60603badffb7b5bcbef22eee2134cb tdf#124176: Use pragma once instead of include guards It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I submitted a patch to gerrit but it shows the build failed message. The exact message is - " Build Failed https://ci.libreoffice.org/job/gerrit_master/52277/ : FAILURE the build failed because of an issue with the bot itself, not with the code. The Bot failed to checkout the source ( https://ci.libreoffice.org/job/gerrit_mac/56600/ ) " Link to the patch: https://gerrit.libreoffice.org/c/core/+/90831 So, is there any issue with my submission or the issue is with the bot only (as the failure statements says)? And if there is anything I can do to get the patch successfully pushed, please suggest.
(In reply to Harshit Jain from comment #78) > I submitted a patch to gerrit but it shows the build failed message. The > exact message is - > > " Build Failed > > https://ci.libreoffice.org/job/gerrit_master/52277/ : FAILURE > > the build failed because of an issue with the bot itself, not with the code. > The Bot failed to checkout the source ( > https://ci.libreoffice.org/job/gerrit_mac/56600/ ) " > > Link to the patch: https://gerrit.libreoffice.org/c/core/+/90831 > > So, is there any issue with my submission or the issue is with the bot only > (as the failure statements says)? And if there is anything I can do to get > the patch successfully pushed, please suggest. As you can see from the console log, it has nothing to do with your patch: https://ci.libreoffice.org/job/gerrit_mac/56600/console Please never change the statuses of easy hacks to needinfo.
(In reply to Buovjaga from comment #79) > (In reply to Harshit Jain from comment #78) > > I submitted a patch to gerrit but it shows the build failed message. The > > exact message is - > > > > " Build Failed > > > > https://ci.libreoffice.org/job/gerrit_master/52277/ : FAILURE > > > > the build failed because of an issue with the bot itself, not with the code. > > The Bot failed to checkout the source ( > > https://ci.libreoffice.org/job/gerrit_mac/56600/ ) " > > > > Link to the patch: https://gerrit.libreoffice.org/c/core/+/90831 > > > > So, is there any issue with my submission or the issue is with the bot only > > (as the failure statements says)? And if there is anything I can do to get > > the patch successfully pushed, please suggest. > > As you can see from the console log, it has nothing to do with your patch: > https://ci.libreoffice.org/job/gerrit_mac/56600/console > Please never change the statuses of easy hacks to needinfo. Okay, will keep this in mind. Now, will the build be automatically triggered or I need to do something, so that the patch gets pushed successfully.
Furkan Ahmet Kara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f13913d510672cd4f28726ef18c4f3d014b6f06c tdf#124176: Use pragma once instead of include guards It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Harshit Jain committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/fd1cd5522283f279a01d6d673f676a1346e9358b tdf#124176: Use pragma once instead of include guards It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
gokaysatir committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/574e3ddae11a4fa3965bbf8ddf6352f63b41d341 tdf#124176 Use pragma once instead of include guards It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Assigned to myself
(In reply to uplink from comment #84) Please don't assign this task to you: this is the task that may be worked upon in parallel, by many easy-hackers. To coordinate the effort and avoid modifying the same files, please mention which directories you are currently working on, and also pay attention to in-progress changes in gerrit that have "tdf#124176" in their commit message: https://gerrit.libreoffice.org/q/status:open+tdf%2523124176
I think this this complete
Assigned again
(In reply to uplink from comment #86) > I think this this complete No, not even close. There are possibly thousands of files left for this bug report. (In reply to uplink from comment #87) > Assigned again Please stop, and do not edit or comment on this bug report any further. If you would like to work on this, just send your patches, keeping the comment#85 in mind. Thank you for your understanding.
Andrea Gelmini committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/83de7f38b7ae3c0b357974a536ae53fd6a2d231e tdf#124176: Use pragma once instead of include guards It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Andrea Gelmini committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ddcbaf462821d373592f9560d1e1e117cce05709 tdf#124176: Use pragma once instead of include guards It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Andrea Gelmini committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f6b828275af11f8b04a52a9ad5f44e210d4fec0b tdf#124176: Use pragma once instead of include guards It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Yusuf Keten committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b8fb7ecd9cdbe1898c41eaecd9894df8e8f01e25 tdf#124176: Use pragma once instead of include guards It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Shivam Kumar Singh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/845859017a74978a7ad5c6473b473f38f284edf2 tdf#124176: Use pragma once instead of header guard It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Is this issue fixed?
(In reply to pranesh ulleri from comment #94) > Is this issue fixed? No. Not even close to be fixed. You may issue this command to get a list of possible candidates: git grep "#ifndef" | grep hxx
Wyatt Turner committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cf94d52c0537d9291309b10fb3021f9d35bf1796 tdf#124176 Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I am working on this as my first LO bug, using a suitable Python script to make the changes en masse. Currently I've got the script to make the vast majority of changes successfully and have had to edit just the following few files manually: chart2/source/inc/InternalData.hxx include/svx/svdmodel.hxx include/vcl/glxtestprocess.hxx Unfortunately the tests are failing on my machine even with my changes removed but the build at least is successful. The script is: #!/usr/bin/python3 import re import subprocess import sys debug = len(sys.argv) > 1 if debug: files = sys.argv[1:] else: files = subprocess.run(['git', 'grep', '--name-only', '#ifndef INCLUDED_.*_HXX'], text=True, capture_output=True).stdout.splitlines() for file_name in files: with open(file_name, 'r+') as f: lines = list(f) flag_name = None flag_start = None flag_def = None flag_end = None is_bad = False else_in_top_lvl = False if_lvl = 0 if debug: print("Processing %s with %d lines" % (file_name, len(lines))) for i, line in enumerate(lines): if re.match('^\\s*#\\s*if', line): if_lvl += 1 if if_lvl == 1 and flag_start is not None: # There is a top-level if statement after the include guard. is_bad = True elif re.match('^\\s*#\\s*el', line): if if_lvl <= 1: else_in_top_lvl = True elif re.match('^\\s*#\\s*endif', line): if_lvl -= 1 if flag_name is None: if m := re.match('#ifndef (INCLUDED_.*_HXX)', line): flag_name = m.group(1) flag_start = i elif flag_def is None: if m := re.match('#define (INCLUDED_.*_HXX)', line): if m.group(1) == flag_name and i == flag_start + 1: flag_def = i elif flag_end is None: if re.match('^\\s*#\\s*endif', line) and if_lvl == 0: flag_end = i else: if not (re.match('^\\s*$', line) or re.match('^\\s*/\\*.*\\*/\\s*$', line) or re.match('^\\s*//', line)): is_bad = True if debug: print(f"Line {i}\tflags {flag_start}\t{flag_def}\t{flag_end}\t{if_lvl}\t{else_in_top_lvl}\t{is_bad}") if flag_start is not None and (flag_end is None or else_in_top_lvl): is_bad = True if is_bad: print("%s is bad!" % file_name) continue if flag_start is None: continue if debug: continue lines[flag_start] = '#pragma once\n' lines.pop(flag_end) lines.pop(flag_def) f.seek(0) f.truncate() f.write(''.join(lines)) It parses preprocessor commands at a fairly basic level and makes the needed changes if they seem safe (i.e. is_bad is false), or if passed file paths prints debugging information to explain why they are bad. The only outstanding file with a "weird" include guard is vcl/inc/unx/gtk/gtkgdi.hxx. This file has an #else command half-way though the include guard which may not be correct.
(In reply to George Bateman from comment #97) > I am working on this as my first LO bug, using a suitable Python script to > make the changes en masse. Currently I've got the script to make the vast > majority of changes successfully and have had to edit just the following few > files manually: > > chart2/source/inc/InternalData.hxx > include/svx/svdmodel.hxx > include/vcl/glxtestprocess.hxx > > Unfortunately the tests are failing on my machine even with my changes > removed but the build at least is successful. Nice! It might of course happen that you have some local problem preventing you from successful building/testing. That is unfortunate, and you of course should fix it (use help from #libreoffice-dev); but don't hesitate to publish your patch*es* to gerrit nevertheless, to be tested independently by buildbots. Note that you should not create a huge patch with hundreds of files modified at once. Please create multiple changes - say, per module, or even submodule where appropriate. Thanks, and looking forward for your first contribution!
I've submitted some patches to Gerrit (https://gerrit.libreoffice.org/q/owner:george.bateman16%2540gmail.com), one with changes across the whole project (submitted before I read your comment!) and the rest being per-module. Do let me know if these are okay.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/88da6b7b62dc0c391e28a920bb2d355bce89f8bf tdf#124176 Use #pragma once in comphelper It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/269497fff04bb5bbe982a7bcd48ea06d1507fc6b tdf#124176 Use #pragma once in avmedia It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/24491636d36a1d92a4bb9f3f1f1b2e65b81d8429 tdf#124176 Use #pragma once in cppcanvas It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/df9ff47f984bfb8ce265cb73ec10a3dd5837bd10 tdf#124176 Use #pragma once in canvas It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/fb4ddf2fc997f3b0c193b6dce22a0b1313f24240 tdf#124176 Use #pragma once in basic It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/abea8319622848f2228fc9a2736a645b52ab617b tdf#124176 Use #pragma once in basctl It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5381af18b6c5e75b37bdc81d69f376cfedaaf641 tdf#124176 Use #pragma once in binaryurp It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/505795db3fa8cd5bb9868ff99f9a8cdf268f4c0b tdf#124176 Use #pragma once in bridges It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6efb746a8cf876ef00d97aa8bd8f2f4ef9cabcfd tdf#124176 Use #pragma once in configmgr It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4d433b21ec6fdd80e09dc042a8e204e72b1e62c8 tdf#124176 Replace 3 include guards with #pragma once It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1d203d95479d16049c2edb6fa6fc927c1d97067f tdf#124176 Use #pragma once in chart2 It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to George Bateman from comment #99) > I've submitted some patches to Gerrit > (https://gerrit.libreoffice.org/q/owner:george.bateman16%2540gmail.com), one > with changes across the whole project (submitted before I read your > comment!) and the rest being per-module. Do let me know if these are okay. IMHO per-module is better that all in one. For some big modules (sc, sw for example), perhaps you may even cut in different patches for each submodule.
Just a heads up, seeing that this appears to get cleaned up systematically now: There are some source files containing include guards that are meant to (also) be processed by compilers other than LO's build baseline compilers: * All URE include files, see the (generated via odk/CustomTarget_allheaders.mk) workdir/CustomTarget/odk/allheaders/allheaders.hxx for a complete list. * Anything under odk/examples/. For those source files, it is probably better to conservatively stick with include guards than to replace them with #pragma once.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7021dae8115ceac19a2823e8d91e09d952d82c51 tdf#124176 Use #pragma once in compilerplugins It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ce73b526c459bf1ab15220fe78afae44cb436184 tdf#124176 Use #pragma once in codemaker It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/08cc983e26dd3252b12b253af9b0c3430e933321 tdf#124176 Use #pragma once in cppu, cppuhelper It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0743a75a9fd3ef60489154e4ffc706f9dae82399 tdf#124176 Use #pragma once in dbaccess/source/filter It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f93f4c10e6e976009606ecc7bb3b8a02afd80fb0 tdf#124176 Use #pragma once in cui It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ae484ec0fdcd1871ce28e7fcddaa1debc28eca8a tdf#124176 Use #pragma once in dbaccess/source/core It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ffcee12bc09dd1bfd713314788061273ca144efd tdf#124176 Use #pragma once in dbaccess/source/ui It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/91230736fce6d18886cf04902f477b458bf225b4 tdf#124176 Use #pragma once in drawinglayer It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3dbc14db0aad072844b30e873c2d53978ea8e1c3 tdf#124176 Use #pragma once in dtrans It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/66253cace2db6026ec636a4a8b6062f125957da7 tdf#124176 Use #pragma once in editeng It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3d7e089a3def73d45d60de4db4b3fe4a3bbeb453 tdf#124176 Use #pragma once in embeddedobj It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
George Bateman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/dcbe844e291b7efa9ea7eaf280186ce97df075b2 tdf#124176 Use #pragma once in desktop It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Andrea Gelmini committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6505f43b09fda83f26159746083b971bfab8054a tdf#124176 Use #pragma once in some include/ It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Un-assigning myself; final Python script for reference is #!/usr/bin/python3 import re import subprocess import sys debug = '--debug' in sys.argv if debug: files = [x for x in sys.argv[1:] if x != '--debug'] else: files = subprocess.run(['git', 'grep', '--name-only', '#ifndef INCLUDED_.*'] + sys.argv[1:], text=True, capture_output=True).stdout.splitlines() for file_name in files: with open(file_name, 'r+') as f: lines = list(f) flag_name = None flag_start = None flag_def = None flag_end = None is_bad = False else_in_top_lvl = False if_lvl = 0 if debug: print("Processing %s with %d lines" % (file_name, len(lines))) for i, line in enumerate(lines): if re.match('^\\s*#\\s*if', line): if_lvl += 1 if if_lvl == 1 and flag_start is not None: # There is a top-level if statement after the include guard. is_bad = True elif re.match('^\\s*#\\s*el', line): if if_lvl <= 1: else_in_top_lvl = True elif re.match('^\\s*#\\s*endif', line): if_lvl -= 1 if flag_name is None: if m := re.match('#ifndef (INCLUDED_.*)', line): flag_name = m.group(1) flag_start = i elif flag_def is None: if m := re.match('#define (INCLUDED_.*)', line): if m.group(1) == flag_name and i == flag_start + 1: flag_def = i elif flag_end is None: if re.match('^\\s*#\\s*endif', line) and if_lvl == 0: flag_end = i else: if not (re.match('^\\s*$', line) or re.match('^\\s*/\\*.*\\*/\\s*$', line) or re.match('^\\s*//', line)): is_bad = True if debug: print(f"Line {i}\tflags {flag_start}\t{flag_def}\t{flag_end}\t{if_lvl}\t{else_in_top_lvl}\t{is_bad}") if flag_start is not None and (flag_end is None or else_in_top_lvl): is_bad = True if is_bad: print("%s is bad!" % file_name) continue if flag_start is None: continue if debug: continue lines[flag_start] = '#pragma once\n' if lines[flag_end-1].strip() == f"// {flag_name}": lines.pop(flag_end - 1) flag_end -= 1 if len(lines) > flag_end+1: if (len(lines[flag_end-1].strip()) == 0) and (len(lines[flag_end+1].strip()) == 0): lines.pop(flag_end + 1) lines.pop(flag_end) else: lines.pop(flag_end) if len(lines[flag_end-1].strip()) == 0: lines.pop(flag_end - 1) lines.pop(flag_def) f.seek(0) f.truncate() f.write(''.join(lines)) Use as ./make_pragma_once.py text/**/*.h* or similar.
Nikhil committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1b6dead4dc7d11fd3d2e1b88da941857cb1be046 tdf#124176 Use #pragma once in text It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Hello,Can I work on this issue if there is nobody working on it? Thanks.
(In reply to Mariam Fahmy from comment #128) > Hello,Can I work on this issue if there is nobody working on it? Yes, dozens of people can work on this at the same time
mariamfahmy committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e7eaa66d4de5d3c634e8a148f8838276d539546c tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
mariamfahmy committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8feb66ac2f08a2fde2567d2c358aab53b3e42c48 tdf#124176: Using pragma once It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Stephan Bergmann from comment #112) > Just a heads up, seeing that this appears to get cleaned up systematically > now: There are some source files containing include guards that are meant > to (also) be processed by compilers other than LO's build baseline compilers: > > * All URE include files, see the (generated via > odk/CustomTarget_allheaders.mk) > workdir/CustomTarget/odk/allheaders/allheaders.hxx for a complete list. > > * Anything under odk/examples/. > > For those source files, it is probably better to conservatively stick with > include guards than to replace them with #pragma once. I was wondering how to generate allheaders.hxx and Jan-Marek helped me: make odk.check
(In reply to Buovjaga from comment #132) > (In reply to Stephan Bergmann from comment #112) [...] > > * All URE include files, see the (generated via > > odk/CustomTarget_allheaders.mk) > > workdir/CustomTarget/odk/allheaders/allheaders.hxx for a complete list. [...] > I was wondering how to generate allheaders.hxx and Jan-Marek helped me: > > make odk.check or just `make CustomTarget_odk/allheaders`
mariamfahmy committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e6a96b8e9642732082701b01495e3093439ae404 tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Gokce Kuler committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/113c6c9d91c8f8bb90cc29f4dbe73fcafdb995de tdf#124176 Use pragma once instead of header guard It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
gizemozgun committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d1da299ef910e2d75e98bed62110a9e8693aefe3 tdf#124176 Using pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Betül İnce committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5219c6bd804f626b30a783ec012b24c01911c575 tdf#124176 Using pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
diwanshu885 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/44c120ba3f15e31bd506f5bdda26a565ca6ad635 tdf#124176 Using pragma once instead of inclusive guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
shubham656 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9a2d8d30ac2e525963c764794bd3d6bd3462f64b tdf#124176 Use pragma once instead of inclusive guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
TRaXIn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/98076bc83167dca559800ea882c38ef4fca873b7 tdf#124176 Use #pragma once in xmlsecurity It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Roman Kuznetsov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6d74413e5d2b03d84a2f8f748827234b2c22d62c tdf#124176 use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Roman Kuznetsov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/023b77182a5818063f53ecfbe7ec3562ee37dcbc tdf#124176 use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Zeynep İnkaya committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0ea2bda1610eda92d3101fc69a464a6f06b45523 tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mücahid Aydin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/dbdb227219bf2b1bb23400aeac706f882ca0cad1 tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Gül Toksöz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d9929c86bcbd2b3a3abd1579dc87e9a4cf0087c8 tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Gökhan Özeloğlu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/635a77ddc06ddbaaf6eba2d978d2187ddeaa80b9 tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mücahid Aydin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2292ad256f6b3167a0fdb99f4b28064c75616751 tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Arda committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9eb7962a718fae662a8cb26382031f1c10c64597 tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Tolunay Dündar committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d46a2a1373c231f3437a229e2160edf58971d8db tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Umut Emre Bayramoglu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bac71fd104a19e481ed688fba0b0f427e855ce91 tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Umut Emre Bayramoglu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ddc9c95745183e2e6d7791bcd3248db976c89f4e tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Bartu Bayazıt committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c3c9c0505509d69501ed835e97418b82e64bdfab tdf#124176: Use pragma once, instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Gökhan Özeloğlu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/61f2209ac2e744b42da929e79ed9380269a95dd6 tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Umut Emre Bayramoglu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f06083d5714fda562375d12902f704514ec30491 tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Tolunay Dündar committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/17aca7c66fd71b3259e4cb0a964224f371db45d2 tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Tolunay Dündar committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/72bd82016efe7b097736d94af5046a0e55d3c2ac tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Gökhan Özeloğlu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/62c9aeaf0c5f6e23d7d9a091014d22ccd2406463 tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Gökhan Özeloğlu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c9bc63b8f1dbaa1bbf1bbcb3276d511224951ce0 tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Gökhan Özeloğlu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/151bd3cdeaee78ac94e5e349a71aacefcf8f41b6 tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Gökhan Özeloğlu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9cd34d4b2fceb66c3aa22bec5286323cd1070edc tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I will be working in the ./extensions/source/abpilot directory.
Muhammet Kara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e81845679ea6b30d651f76cc8bddc052a52bd227 tdf#124176: Use pragma once instead of include guards It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
lastirembender committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/49890bfe62694ec9ed10204e9874512daf6b4620 tdf#124176: Use pragma once instead of include guards It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
ShyamPraveenSingh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/47bb1e449f8dd1668c4e50ab7df980f4e3de8319 tdf#124176 Use #pragma once in extensions/source/abpilot It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Bayram Çiçek committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/42b0ea1993b7ea223c126f011c78ec4cdfce95ff tdf#124176: Use pragma once instead of include guards It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Gül Toksöz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/843aedb772223189aa2ba3b1e9ffb7dba86db1ac tdf#124176: Use pragma once instead of include guards It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Bartu Bayazıt committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2e93e2c83b3fba9d29783dc4cc9782e142d8a58f tdf#124176: Use pragma once instead of include guards It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
ganeshdevare committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bc833c71cda6595897277013b1ee6273c6296219 tdf#124176 Use #pragma once in connectivity It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
zeynepsninkaya committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3aaff1083a60010ad31342e029ce6e9b8ec62f9c tdf#124176: Use pragma once instead of include guards It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
cu-16bcs1798 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1d3d958e0089429e05265cfd13dc540fce5887d1 tdf#124176 Use #pragma once in framework/inc/uifactory It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Please review the changes made by me: https://gerrit.libreoffice.org/c/core/+/107528
homeboy445 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c17ff0b5dc20d637392562eb59bd5bfdb2694389 tdf#124176 Use #pragma once in idlc It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
DuP-491 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6a279e2d98d3aa2d11cc7b8c09158186795e7fcd tdf#124176 Use #pragma once in connectivity It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
siddheshpatil777 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3420cc1e70b2ed49fc63d6fd30f7b962abbec70f tdf#124176 Use #pragma once in connectivity It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Bayram Çiçek committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6a905223b6caefeace9c5037974462e0b94546f4 tdf#124176: Use pragma once instead of include guards It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
halfhiddencode committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/90be4d003b36428a88847d36354c3572c453c90d tdf#124176 Use pragma once in writerperfect It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Vishwas committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e245217bf4abd70b7395061190557c2b7e6ec952 tdf#124176: Use pragma once instead of include guards It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Alchemist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/74583d24f67f41d15da211cfb00b7eaa8419e685 tdf#124176 Use pragma once instead of include guards It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
anirudhS committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f2254f11e5e381b959dcaab53a7ddb101a83b561 tdf#124176 Use pragma once instead of include guards It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Commit Notification from comment #12) > Batuhan Görkem Benzer committed a patch related to this issue. > It has been pushed to "master": > > https://git.libreoffice.org/core/commit/ > 7b1f3135de3211b0b750571ecdcd9dcab752b544 > > tdf#124176: Use pragma once instead of header guard > > It will be available in 6.5.0. > > The patch should be included in the daily builds available at > https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More > information about daily builds can be found at: > https://wiki.documentfoundation.org/Testing_Daily_Builds > > Affected users are encouraged to test the fix and report feedback.
csegura committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c0e9bda0149b12d072607c744bdf72c6ddb439e5 tdf#124176 Use pragma once instead of include guards in basctl It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
princesinghtomar committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/83f92f0c567ddba9715b2a48836fae78144aa0fd tdf#124176 Use pragma once instead of include guards It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Shobhit committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c098d1a957789f9af930438e60dbcbc5ecfc953a tdf#124176: Use pragma once instead of include guards It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
ViKrAm-Baisclear committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ab559cf3423f29f00697afb9cea4636e9f9069f6 tdf#124176 Used pragma once instead of include guards It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
ViKrAm-Baisclear committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1e195878066f49bd78765e9a05081c496b770525 tdf#124176 used pragma once instead of include guards It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
msrijita18 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/449920770449d7bf1379e2e8da6d634b90e8bace tdf#124176 Use pragma once instead of include guards in xmlscript It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Shobhit committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/741c1b6bb1d10ab217c084278cd8ad5263a1a323 tdf#124176: Use pragma once instead of include guards It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Buse Orak committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/de355293303ace942c6f18df57400e0f26b9af29 tdf#124176: Use pragma once instead of include guards It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Quentin DELAGE committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/409a9dbc04c4b98a3f9ca81618906b16937ff2f0 tdf#124176 Use pragma once in include/oox/drawingml It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Can i work on this issue i am new to LibreOffice and this may be my first issue? Do we have to change it in all header files?
(In reply to heet_2312 from comment #190) > Can i work on this issue i am new to LibreOffice and this may be my first > issue? > Do we have to change it in all header files? You don't have to modify more than a single file.
Suhaas Joshi committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cbb131a617ecf466cc9133dd2a2cffcdb381acaf tdf#124176 Use pragma once in sw/source/core/text It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Suhaas Joshi committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c20ac51dfb4a74a8951b4207fbf9b2ed9c6ef5dc tdf#124176 Use pragma once in sw/source/core/text It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Suhaas Joshi committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/36554a53bd5064cf7cc93fcbbcc7a668f58d4d1d tdf#124176 Use pragma once in sw/source/core/text It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Suhaas Joshi committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/414490ddba424b38ef1c627decdb4af8bbdbd717 tdf#124176 Use pragma once in sc/source/core/opencl It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Suhaas Joshi committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b337df8e74214241b3c2d2facd46331eb62c17be tdf#124176 Use pragma once in sw/source/core/view It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
dante committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1a9dd0084d2c6057eca57cf069c77a7bad4d9724 tdf#124176 on starmath It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
heet-2312 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/311c177f8337403e65fe93ee03129382582b1b5d tdf#124176 Use pragma once in sw/inc/ndtxt.hxx It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Ahmet Hakan Çelik committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/57c8f13d176cccf913573dafaf10a870619822fc tdf#124176 Use pragma once in sw/source/uibase/sidebar It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Hey, I'm solving this as my first contribution, but I doubt that weather I'm supposed to change directive across all header files or just in a single file.
(In reply to Anshal Shukla from comment #200) > Hey, I'm solving this as my first contribution, but I doubt that weather I'm > supposed to change directive across all header files or just in a single > file. Hi! :) This is meant to be a first-patch easy hack for many people. So do just a (bunch of) file(s), not all of them. And please don't assign the bug to yourself.
ViswaasLP committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ce69ab8d61975d5d49142469115798b5b3688a63 tdf#124176 Use pragma once in sw/source/uibase/inc It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
pekka-dev committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a9b31601580fa85cab783b73552489c092403296 tdf#124176 Use pragma once It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Vincent LE GARREC committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/039e90ec011157c9e851221a53ec62d33acb71d1 tdf#124176 Use pragma once in extensions It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Vincent LE GARREC committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1c0c2bb7920f5da7562a053019514d1e4cbdf1f6 tdf#124176 Use pragma once in u* It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Vincent LE GARREC committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e29f53b71058b9468cb6c29f82dbf6de53d4cdd0 tdf#124176 Use pragma once in w* It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Vincent LE GARREC committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6069a66690a10550d54f7641cda1aa83560ff019 tdf#124176 Use pragma once in connectivity It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Vincent LE GARREC committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/90c978f839e5029c69b4acb70f37909ee3016614 tdf#124176 Use pragma once in f* It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Vincent LE GARREC committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/aef40e738842522c050538cc8a62c2d1f4861861 tdf#124176 Use pragma once in x* It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Vincent LE GARREC committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/24552a0b5be620b5e58b10842cba78e36fa26b04 tdf#124176 Use pragma once in s* It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Panos committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9c6da8a14ae571e4ca063e9951c00d3fa2c0b14d tdf#124176 replace include guards with pragma once It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mehmet Sait Gülmez committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e8017041a17a489e56ad4a888c2c2a52225d612b tdf#124176: Use pragma once instead of include guards It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 170671 [details] define_to_pragma.py Python script to convert "#define" include guards to "#pragma once". Remember: "This is meant to be a first-patch easy hack for many people. So do just a (bunch of) file(s), not all of them. And please don't assign the bug to yourself."
Vincent LE GARREC committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7fb85fa0f0a85384f085b13e7d08113f63392445 tdf#124176 Use pragma once in sd It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
anirudh4583 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6e1bd835ed85d9eba9184d0afb5575246a6b7c9a tdf#124176 Use pragma once It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
rounak committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3b704dc06bd39593b14e0dc6b47ba4c9f7d853d0 tdf#124176 Use pragma once instead of include guards It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
sarynasser committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/77419c6f3aba1fd5b1660795923c22a39bdb1bad tdf#124176 Use pragma once in vcl It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I'd like to do something in this issue. Can I take over it?
(In reply to Baltasar from comment #218) > I'd like to do something in this issue. Can I take over it? You have more experience than the people this task is meant for, so I suggest to pick something else. In any case, if you are thinking of some wholesale solution, we would rather keep this open for newbies to nibble at.
All right, I understand.
I would like to solve this issue.
Harshita Nag committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9a94680d6b9f441167644b98c307da3a89963a32 tdf#124176 Use pragma once instead of include guards It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Radhey Parekh from comment #221) > I would like to solve this issue. Please only do a few files as you can see from the earlier commits.
(In reply to Buovjaga from comment #223) > (In reply to Radhey Parekh from comment #221) > > I would like to solve this issue. > > Please only do a few files as you can see from the earlier commits. Sure sir.
Radhey Parekh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/872c54f99c7cd35697ea811b59bbcdc4b31f38d0 tdf#124176 Use pragma once instead of include guards It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I created a rebooted version of this easy hack: bug 143148. It collects all the useful bits into the description, so explaining this task should no longer be a pain in the butt. Closing as fixed for lack of a better status.
Chris Sherlock committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/83070c694c742ef1e86e017a5e684e72b23bf3c9 tdf#124176 - Use pragma once instead of include guards It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Chris Sherlock committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e9f59e76292f815faefa4ca3877d3aacdad3be5a tdf#124176 - Use pragma once instead of include guards It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Chris Sherlock committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/88b72d85ef82a5a6ca019ef9b88f5389db067c83 tdf#124176 - Use pragma once instead of include guards It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Chris Sherlock committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cc81b6353ec1983b652d1c370ee80d77b5f8d1e8 tdf#124176 vcl: Use pragma once instead of include guards It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Chris Sherlock committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c0aacb30b73405f6d0213fcb85b53b6d0f0854d7 tdf#124176 vcl: Use pragma once instead of include guards in inc/textlayout.hxx It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.