Description: The dialog containing the shortcuts won't show up in the iOS app. I'm not sure if this dialog is actually useful on iOS. Steps to Reproduce: 1. Create/open a document in the iOS app 2. Click the menu entry "Help > Shortcuts" Actual Results: Nothing happens. Expected Results: A dialog with the shortcuts should show up or the menu entry should be removed. Reproducible: Always User Profile Reset: No Additional Info:
I'd say, would be best to remove for now. I'm not sure what the possibilities are with an external keyboard.
The About dialog is displayed (same type). So there must be a difference, for example I can imagine that loleaflet-help.html is not present in iOS app.
Probably we should not show such a menu entry in a mobile app. Perhaps not when using server-based Online from a mobile device browser either. "Shortcut" surely is a desktop concept.
Although I notice that iOS itself and some well-known apps do support keyboard shortcuts, see https://www.laptopmag.com/articles/every-ipad-keyboard-shortcut for instance. So maybe we should make the dialog show up? On the other hand, I wonder if our shortcuts on iOS are for PC-style keyboard, or an Apple style, with the ⌘ key mostly used instead of the Control key for instance? (As can be deduced from the link above, the expectation presumably is that shortcuts should be Mac-style, not Windows/Linux -style.)
Created attachment 150549 [details] Tentative patch to hide them But I will check how hard it would be to make the dialog showing the shortcuts appear instead. (And check whether they actually work...)
Nah, the keyboard shortcut window is a HTML file that the code wants to display using HTTP, so would require different code in the app case. Will just remove the menu entry for now.
Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/online/+/e8ba2ca35a79bb3b721f99ba662dee6f40d9aec1%5E%21 tdf#124177: Don't show the Help > Keyboard shortcuts menu entry in mobile apps