Bug 124206 - TABLE: Difference between default style as template and default style as style is not clear
Summary: TABLE: Difference between default style as template and default style as styl...
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.1.5.2 release
Hardware: All All
: medium normal
Assignee: Heiko Tietze
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Sidebar-Styles Writer-Table-Insert-Dialog
  Show dependency treegraph
 
Reported: 2019-03-19 13:23 UTC by Dieter Praas
Modified: 2019-06-13 07:53 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dieter Praas 2019-03-19 13:23:47 UTC
This is a follow up from bug 108227.

Regarding to bug 108227 comment 7, both a table template (Insert Table dialog)and a table style (Sidebar) are named "Default style". This is inconsistent, because you would - for example - expect, that default style is highlighted in the sidebar, if you choose default style in the insert table dialog.


Jim Raykowski proposed as solutions (bug 108227 comment 9):

1) Remove 'Default Style' from the list of table styles shown in the Sidebar table styles panel

2) Add an option in the Insert Table dialog to insert a table using table styles as a template. Document the difference between template and style use.


I think, there is a need for improvement.

cc: Design-Team
Comment 1 Heiko Tietze 2019-03-29 08:54:39 UTC
Unlike paragraphs, newly inserted tables don't receive the default style automatically. That's in fact an inconsistency. We could apply the default automatically but it likely changes the used formatting as the table style doesn't pick up the paragraph settings. Alternatively we could just rename Default Style to "Plain" (or something else), which sounds to me as the most simple solution and close to proposal #1. 

About #2, there is Table > Insert Table, which offers to apply a style with the creation. That works for all but Default. Not sure that this bug would be solved when the style is named differently.

Other opinions?
Comment 2 Cor Nouws 2019-06-12 08:40:22 UTC
(In reply to Heiko Tietze from comment #1)
`> doesn't pick up the paragraph settings. Alternatively we could just rename
> Default Style to "Plain" (or something else), which sounds to me as the most
> simple solution and close to proposal #1.
Souds best to me.

> About #2, there is Table > Insert Table, which offers to apply a style with
> the creation. That works for all but Default. Not sure that this bug would
> be solved when the style is named differently.
Sounds even better.

But be prepared for a can of worms maybe with loading older documents.
Comment 3 Thomas Lendo 2019-06-12 23:07:38 UTC
I thought:
- A table needs to have a style and that it's not possible (and wanted) to have a table without a style. This is the reason why a 'default style' table style should exist.
- Table templates are a dying feature which is implemented with exchanging the old table 'AutoFormat' with table styles.


If it's not possible or wanted that the user must choose a table style like he has to choose a paragraph, then the renaming from 'default style' to 'plain' is good.

For me, the final solution should be to have a real 'default style' for tables as it exists for other styles.

I don't see a problem with paragraph styles as Heiko mentioned in comment 1. The user shouldn't assume that paragraph settings and table settings should be the same or similar.

Does "using table styles as a template" mean that there should be a checkbox in the table insert dialog that the choosen style should be the default for all future inserted tables in this document?
Comment 4 Heiko Tietze 2019-06-13 07:53:18 UTC
(In reply to Thomas Lendo from comment #3)
> - Table templates are a dying feature which is implemented with exchanging
> the old table 'AutoFormat' with table styles.

The "table style" is still a template and what we have in the sidebar is the same functionality as in the autoformat dialog. Having a Default style that doesn't change the paragraph settings (eg. font name) might be possible when the binary format is replaced by a sane xml format.

Meanwhile let's go with "Plain" and see how well this works. Taking... (unless someone else is eager to look into).