Bug Hunting Session
Bug 124221 - Chart in Writer doesn't update after changing of data in the source table
Summary: Chart in Writer doesn't update after changing of data in the source table
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Chart (show other bugs)
Version:
(earliest affected)
5.3.7.2 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Chart
  Show dependency treegraph
 
Reported: 2019-03-20 12:09 UTC by Roman Kuznetsov
Modified: 2019-11-26 00:37 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file with chart (15.65 KB, application/vnd.oasis.opendocument.text)
2019-03-20 12:09 UTC, Roman Kuznetsov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2019-03-20 12:09:01 UTC
Description:
Chart in Writer doesn't update after changing of data in the source table

Steps to Reproduce:
1. Open file from attach
2. Try change any number to another number
3. Chart doesn't update

Actual Results:
Chart doesn't update

Expected Results:
Chart updates


Reproducible: Always


User Profile Reset: No



Additional Info:
Версия: 5.3.7.2
ID сборки: 6b8ed514a9f8b44d37a1b96673cbbdd077e24059
Потоков ЦП: 4; Версия ОС: Windows 6.2; Отрисовка ИП: GL; Способ разметки: новый; 
Локаль: ru-RU (ru_RU); Calc: group

it works as expect in LO 5.2.7 -> regression
Comment 1 Roman Kuznetsov 2019-03-20 12:09:56 UTC
Created attachment 150118 [details]
Example file with chart
Comment 2 Durgapriyanka 2019-03-20 15:16:43 UTC
I cannot reproduce this. 

The numbers in the chart does get updated. Once you change the data in the source table, save the file, close and reopen again, the Chart is updated with correct values.


Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
Comment 3 Roman Kuznetsov 2019-03-20 15:27:35 UTC
(In reply to Durgapriyanka from comment #2)
> I cannot reproduce this. 
> 
> The numbers in the chart does get updated. Once you change the data in the
> source table, save the file, close and reopen again, the Chart is updated
> with correct values.
> 
> 
> Version: 6.3.0.0.alpha0+
> Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
> CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
> TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
> Locale: en-US (en_US); UI-Language: en-US
> Calc: threaded

In 5.2 the chart updates at once after changing of number in table and moving of cursor out of table. Without any additional actions a-la save/reopen.
Now, in LO 6.3 I can update chart if I enter in chart edit mode and then exit from it at once.
Comment 4 Roman Kuznetsov 2019-03-20 17:11:32 UTC
I bisected it

asus@notebook-2 /cygdrive/c/logit/bibisect-win32-5.3
$ git bisect bad
61cb66513bfdaa5e47fb419d476107b40e62e7d0 is the first bad commit
commit 61cb66513bfdaa5e47fb419d476107b40e62e7d0
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Sat Jul 9 12:38:32 2016 -0700

    source sha:64e1113916a6b19b30f95b454018528571ac84df

https://gerrit.libreoffice.org/plugins/gitiles/core/+/64e1113916a6b19b30f95b454018528571ac84df

CC: Armin Le Grand and Thorsten Behrens
Comment 5 Roman Kuznetsov 2019-03-20 17:12:26 UTC
(In reply to Roman Kuznetsov from comment #0)
> Description:
> Chart in Writer doesn't update after changing of data in the source table

Additional:

> Steps to Reproduce:
> 1. Open file from attach
> 2. Try change any number to another number
> 3. Click out of table
> 4. Chart doesn't update
Comment 6 mulla.tasanim 2019-03-22 07:16:38 UTC
(In reply to Roman Kuznetsov from comment #5)
> 
> Additional:
> 
> > Steps to Reproduce:
> > 1. Open file from attach
> > 2. Try change any number to another number
> > 3. Click out of table
> > 4. Chart doesn't update

After following steps from Comment #5 

I can confirm that the bug is present in

Version: 6.2.1.2 (x64)
Build ID: 7bcb35dc3024a62dea0caee87020152d1ee96e71
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: CL


Version: 6.3.0.0.alpha0+ (x64)
Build ID: 91cdf22b88a4f7bec243c8fb187627e766d3294c
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-03-08_00:38:10
Locale: en-US (en_US); UI-Language: en-US
Calc: CL

chart gets updated in both versions once you will change the data in source table and save it as .odt and reopen it
Comment 7 Muhammet Kara 2019-11-14 15:49:16 UTC
After a quick look at the source code, this behavior seems like the result of a design decision to improve performance, but not a random regression.

OTOH, we could improve the situation, thus changing it to enhancement.

Some random thoughts on the ways to improve:
- Put in a timer, so the data update doesn't get triggered during a regular scrolling (Currently, we do the refresh on state change, so the chart gets updated if you double click it)
- Make it optional by putting a checkbox to settings to enable/disable caching chart data (should be enabled by default IMHO)

- ...
Comment 8 Xisco Faulí 2019-11-14 15:54:53 UTC
*** Bug 122995 has been marked as a duplicate of this bug. ***