Steps to reproduce: 1) click on split color button to set font or highlight color 2) click on the drop down part of the color button 3) hover mouse pointer over first color in the recent color list Results: color tool tip displays hex representation of color Expected results: color tool tip displays color name if color is not a custom color
Thank you for reporting the bug. I can confirm the bug present in Version: 6.3.0.0.alpha0+ Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04 Locale: en-US (en_US); UI-Language: en-US Calc: threaded
I can provide code pointers for anyone who would like to work on this.
(In reply to Jim Raykowski from comment #2) > I can provide code pointers for anyone who would like to work on this. Hi Jim, it would be fantastic to provide them and turn this into an easyhack if you can do so...
--- Comment #4 from Jim Raykowski <raykowj at gmail.com> --- Here are some code pointers. Classes to examine: ToolboxButtonColorUpdater class include/svx/tbxcolorupdate.hxx svx/source/tbxctrls/tbxcolorupdate.cxx SvxColorToolBoxControl class include/svx/tbcontrl.hxx svx/source/tbxctrls/tbcontrl.cxx PaletteManager class include/svx/PaletteManager.hxx svx/source/tbxctrls/PaletteManager.cxx Suggested approach: Add a member function to the ToolboxButtonColorUpdater class that gets the current color name. Getting the current color name can be accomplished by: parsing the color name from the tool box quick help text/tool tip text include/svx/tbxcolorupdate.hxx sal_uInt16 const mnBtnId; VclPtr<ToolBox> mpTbx; include/vcl/toolbox.hxx OUString ToolBox::GetQuickHelpText( sal_uInt16 nItemId ) or adding a member variable to the ToolboxButtonColorUpdater class to store the color name that is set in svx/source/tbxctrls/tbxcolorupdate.cxx ToolboxButtonColorUpdater::Update(const NamedColor &rNamedColor) Replace the color hex representation string code with code that uses the created get current color name function svx/source/tbxctrls/tbcontrl.cxx void SvxColorToolBoxControl::execute(sal_Int16 /*nSelectModifier*/) include/svx/PaletteManager.hxx PaletteManger::AddRecentColor HTH Message lost during the BZ outage -> https://lists.freedesktop.org/archives/libreoffice-bugs/2019-March/176596.html
Let's turn this into an easyHack. Jim, thanks for providing the codepointers...
Aditya committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/f512f8818aec08a5b463c8acdf781e7ab27036f5%5E%21 tdf#124247: Fix tooltip message when color added to recent colors It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.